[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

andreip at google.com andreip at google.com
Wed Dec 22 11:32:07 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit e35ec55c936d0fa4b69174d7681473e71465d7d2
Author: andreip at google.com <andreip at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Jul 28 16:27:28 2010 +0000

    2010-07-28  Andrei Popescu  <andreip at google.com>
    
            Reviewed by Jeremy Orlow.
    
            [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
            variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
            https://bugs.webkit.org/show_bug.cgi?id=43120
    
            * storage/indexeddb/script-tests/objectstore-basics.js:
            (openSuccess):
            (createSuccess):
    2010-07-28  Andrei Popescu  <andreip at google.com>
    
            Reviewed by Jeremy Orlow.
    
            [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
            variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
            https://bugs.webkit.org/show_bug.cgi?id=43120
    
            Makes the default WebKit::WebDOMStringList ctor actually create its wrapped
            WebCore::DOMStringList instance.
    
            * public/WebDOMStringList.h:
            * src/WebDOMStringList.cpp:
            (WebKit::WebDOMStringList::WebDOMStringList):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 8d17a65..b5186b9 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-28  Andrei Popescu  <andreip at google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
+        variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
+        https://bugs.webkit.org/show_bug.cgi?id=43120
+
+        * storage/indexeddb/script-tests/objectstore-basics.js:
+        (openSuccess):
+        (createSuccess):
+
 2010-07-28  Xianzhu Wang  <phnixwxz at gmail.com>
 
         Reviewed by Dan Bernstein.
diff --git a/LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js b/LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js
index 2e42e38..9869579 100644
--- a/LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js
+++ b/LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js
@@ -14,7 +14,7 @@ function openSuccess()
 {
     debug("openSuccess():");
     verifySuccessEvent(event);
-    var db = evalAndLog("db = event.result");
+    db = evalAndLog("db = event.result");
 
     // FIXME: remove any previously created object stores.
     // This requires IDBDatabaseRequest::removeObjectStore to be implemented.
@@ -30,9 +30,12 @@ function createSuccess()
     debug("createSuccess():");
     verifySuccessEvent(event);
     var store = evalAndLog("store = event.result");
+    var storeNames = evalAndLog("storeNames = db.objectStores");
 
     shouldBeEqualToString("store.name", "storeName");
     shouldBeNull("store.keyPath");
+    shouldBe("storeNames.contains('storeName')", "true");
+    shouldBe("storeNames.length", "1");
     // FIXME: test store.indexNames, as well as all object store's methods.
 
     result = evalAndLog("store.add('value', 'key')");
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index d75cd98..a50d966 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,18 @@
+2010-07-28  Andrei Popescu  <andreip at google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
+        variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
+        https://bugs.webkit.org/show_bug.cgi?id=43120
+
+        Makes the default WebKit::WebDOMStringList ctor actually create its wrapped
+        WebCore::DOMStringList instance.
+
+        * public/WebDOMStringList.h:
+        * src/WebDOMStringList.cpp:
+        (WebKit::WebDOMStringList::WebDOMStringList):
+
 2010-07-26  Steve Block  <steveblock at google.com>
 
         Reviewed by Jeremy Orlow.
diff --git a/WebKit/chromium/public/WebDOMStringList.h b/WebKit/chromium/public/WebDOMStringList.h
index b3fb533..d88fcee 100644
--- a/WebKit/chromium/public/WebDOMStringList.h
+++ b/WebKit/chromium/public/WebDOMStringList.h
@@ -46,7 +46,7 @@ class WebDOMStringList {
 public:
     ~WebDOMStringList() { reset(); }
 
-    WebDOMStringList() { }
+    WebDOMStringList();
     WebDOMStringList(const WebDOMStringList& l) { assign(l); }
     WebDOMStringList& operator=(const WebDOMStringList& l)
     {
diff --git a/WebKit/chromium/src/WebDOMStringList.cpp b/WebKit/chromium/src/WebDOMStringList.cpp
index cd145bf..4be7fab 100644
--- a/WebKit/chromium/src/WebDOMStringList.cpp
+++ b/WebKit/chromium/src/WebDOMStringList.cpp
@@ -38,6 +38,11 @@ using namespace WebCore;
 
 namespace WebKit {
 
+WebDOMStringList::WebDOMStringList()
+{
+    m_private = WebCore::DOMStringList::create();
+}
+
 void WebDOMStringList::reset()
 {
     m_private.reset();

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list