[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[tonikitoo at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit fd045b09f5857ddbbb31b2161c80bc3e3c175465
Author: tonikitoo at webkit.org <tonikitoo at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Aug 5 03:27:56 2010 +0000

    2010-08-04  Antonio Gomes  <tonikitoo at webkit.org>
    
            Reviewed by Daniel Bates.
    
            Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
            https://bugs.webkit.org/show_bug.cgi?id=43534
    
            As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
            the non-negative checks present in both paddingWidth and paddingHeight methods of
            HitTestResults class are superflous, after we changed the rect based hit testing logic
            of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
    
            No new tests needed.
    
            * rendering/HitTestResult.h:
            (WebCore::HitTestResult::paddingWidth):
            (WebCore::HitTestResult::paddingHeight):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index b1b95e6..d2fcc8d 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-08-04  Antonio Gomes  <tonikitoo at webkit.org>
+
+        Reviewed by Daniel Bates.
+
+        Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
+        https://bugs.webkit.org/show_bug.cgi?id=43534
+
+        As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
+        the non-negative checks present in both paddingWidth and paddingHeight methods of
+        HitTestResults class are superflous, after we changed the rect based hit testing logic
+        of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
+
+        No new tests needed.
+
+        * rendering/HitTestResult.h:
+        (WebCore::HitTestResult::paddingWidth):
+        (WebCore::HitTestResult::paddingHeight):
+
 2010-08-04  Sheriff Bot  <webkit.review.bot at gmail.com>
 
         Unreviewed, rolling out r64674.
diff --git a/WebCore/rendering/HitTestResult.h b/WebCore/rendering/HitTestResult.h
index f47e2a5..e0ffe54 100644
--- a/WebCore/rendering/HitTestResult.h
+++ b/WebCore/rendering/HitTestResult.h
@@ -86,8 +86,8 @@ public:
     IntRect rectFromPoint(int x, int y) const;
     IntRect rectFromPoint(const IntPoint&) const;
     IntSize padding() const { return m_padding; }
-    int paddingWidth() const { return m_padding.width() >= 0 ? m_padding.width() : 0; }
-    int paddingHeight() const { return m_padding.height() >= 0 ? m_padding.height() : 0; }
+    int paddingWidth() const { return m_padding.width(); }
+    int paddingHeight() const { return m_padding.height(); }
     // Returns true if it is rect-based hit test and needs to continue until the rect is fully
     // enclosed by the boundaries of a node.
     bool addNodeToRectBasedTestResult(Node*, int x, int y, const IntRect& rect = IntRect());

-- 
WebKit Debian packaging