[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
dbates at webkit.org
dbates at webkit.org
Wed Dec 22 11:56:18 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 55a0e4deb59793c28675c52277af7813a4308f3e
Author: dbates at webkit.org <dbates at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Aug 11 19:55:37 2010 +0000
2010-08-11 Daniel Bates <dbates at rim.com>
Reviewed by Darin Adler.
Perl warnings when running commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=43856
Fixes Perl warnings introduced by the patch for Bug #40548.
Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.
* Scripts/commit-log-editor:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 1bd9534..8437214 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,19 @@
+2010-08-11 Daniel Bates <dbates at rim.com>
+
+ Reviewed by Darin Adler.
+
+ Perl warnings when running commit-log-editor
+ https://bugs.webkit.org/show_bug.cgi?id=43856
+
+ Fixes Perl warnings introduced by the patch for Bug #40548.
+
+ Perl doesn't have symbolic names for True/False. Instead, we
+ should use boolean values. Moreover, the variable installedEditorApplication
+ is not be used and should be renamed builtEditorApplication so that it
+ uses the existing machinery to set the commit log editor application.
+
+ * Scripts/commit-log-editor:
+
2010-08-11 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
diff --git a/WebKitTools/Scripts/commit-log-editor b/WebKitTools/Scripts/commit-log-editor
index bef0a1f..1be0fd0 100755
--- a/WebKitTools/Scripts/commit-log-editor
+++ b/WebKitTools/Scripts/commit-log-editor
@@ -65,26 +65,26 @@ my $editor = $ENV{SVN_LOG_EDITOR};
$editor = $ENV{CVS_LOG_EDITOR} if !$editor;
$editor = "" if isCommitLogEditor($editor);
-my $splitEditor = true;
+my $splitEditor = 1;
if (!$editor) {
my $builtEditorApplication = "$baseDir/Release/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
if (-x $builtEditorApplication) {
$editor = $builtEditorApplication;
- $splitEditor = false;
+ $splitEditor = 0;
}
}
if (!$editor) {
my $builtEditorApplication = "$baseDir/Debug/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
if (-x $builtEditorApplication) {
$editor = $builtEditorApplication;
- $splitEditor = false;
+ $splitEditor = 0;
}
}
if (!$editor) {
- my $installedEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
+ my $builtEditorApplication = "$ENV{HOME}/Applications/Commit Log Editor.app/Contents/MacOS/Commit Log Editor";
if (-x $builtEditorApplication) {
$editor = $builtEditorApplication;
- $splitEditor = false;
+ $splitEditor = 0;
}
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list