[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
benm at google.com
benm at google.com
Wed Dec 22 11:58:52 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 6daa9f53c81172b670ff9d056f1596a83c8af5cf
Author: benm at google.com <benm at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Aug 12 13:27:53 2010 +0000
2010-08-12 Ben Murdoch <benm at google.com>
Reviewed by Steve Block.
V8 code generator does not add V8BindingMacros.h include in all places it is needed
https://bugs.webkit.org/show_bug.cgi?id=43907
Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
macro.
Build fix so no new tests.
* bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 6f03bc8..936dd4a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-08-12 Ben Murdoch <benm at google.com>
+
+ Reviewed by Steve Block.
+
+ V8 code generator does not add V8BindingMacros.h include in all places it is needed
+ https://bugs.webkit.org/show_bug.cgi?id=43907
+
+ Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
+ macro.
+
+ Build fix so no new tests.
+
+ * bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
+
2010-08-12 Jeremy Orlow <jorlow at chromium.org>
Revert for now
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index 310aafb..aec4d64 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -1230,6 +1230,7 @@ END
} elsif ($nativeType =~ /^V8Parameter/) {
my $value = JSValueToNative($parameter, "args[$paramIndex]", BasicTypeCanFailConversion($parameter) ? "${parameterName}Ok" : undef);
if ($parameter->type eq "DOMString") {
+ $implIncludes{"V8BindingMacros.h"} = 1;
push(@implContentDecls, " STRING_TO_V8PARAMETER_EXCEPTION_BLOCK($nativeType, $parameterName, $value);\n");
} else {
# Don't know how to properly check for conversion exceptions when $parameter->type is "DOMUserData"
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list