[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

abarth at webkit.org abarth at webkit.org
Wed Dec 22 12:18:34 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 8d3f5bc4caf6f665606d4236a80c89fd4946d38b
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Aug 18 21:45:53 2010 +0000

    2010-08-18  Adam Barth  <abarth at webkit.org>
    
            Reviewed by David Levin.
    
            NOT_REACHED is reachable in SVGLength
            https://bugs.webkit.org/show_bug.cgi?id=44150
    
            The author of this code was confused.  This code is reachable.  We just
            haven't implemented it yet.
    
            * svg/SVGLength.cpp:
            (WebCore::SVGLength::setValue):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index c5c1b61..7f0e3f8 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-08-18  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by David Levin.
+
+        NOT_REACHED is reachable in SVGLength
+        https://bugs.webkit.org/show_bug.cgi?id=44150
+
+        The author of this code was confused.  This code is reachable.  We just
+        haven't implemented it yet.
+
+        * svg/SVGLength.cpp:
+        (WebCore::SVGLength::setValue):
+
 2010-08-18  Balazs Kelemen  <kb at inf.u-szeged.hu>
 
         Reviewed by Antonio Gomes.
diff --git a/WebCore/svg/SVGLength.cpp b/WebCore/svg/SVGLength.cpp
index 415dc79..bdd5b27 100644
--- a/WebCore/svg/SVGLength.cpp
+++ b/WebCore/svg/SVGLength.cpp
@@ -27,6 +27,7 @@
 #include "CSSHelper.h"
 #include "FloatConversion.h"
 #include "FrameView.h"
+#include "NotImplemented.h"
 #include "RenderObject.h"
 #include "RenderView.h"
 #include "SVGParserUtilities.h"
@@ -203,7 +204,7 @@ void SVGLength::setValue(float value)
     case LengthTypePercentage:
     case LengthTypeEMS:
     case LengthTypeEXS:
-        ASSERT_NOT_REACHED();
+        notImplemented();
         break;
     case LengthTypePX:
         m_valueInSpecifiedUnits = value;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list