[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
tony at chromium.org
tony at chromium.org
Wed Dec 22 12:20:18 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit f1ce1dd1566d241caa20068207c64383b2b5475e
Author: tony at chromium.org <tony at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Aug 19 16:54:38 2010 +0000
2010-08-19 Tony Chang <tony at chromium.org>
Unreviewed. Just removing \r's from ChangeLog.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 3f41490..788c183 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,763 +1,767 @@
-2010-08-02 Adam Roben <aroben at apple.com>
-
- Tell the patch prettifier about some (not so) new directories
-
- * PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake
- directories.
-
-2010-07-27 Joseph Pecoraro <joepeck at webkit.org>
-
- Reviewed by David Kilzer.
-
- Provide a Helpful Link for Web Inspector Bugs in Bugzilla
- https://bugs.webkit.org/show_bug.cgi?id=43065
-
- * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.
-
-2010-06-09 Julie Parent <jparent at chromium.org>
-
- Reviewed by David Kilzer.
-
- Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
-
- https://bugs.webkit.org/show_bug.cgi?id=40345
-
- * Bugzilla/Flag.pm:
-
-2010-05-17 Julie Parent <jparent at chromium.org>
-
- Reviewed by Ojan Vafai.
-
- Rietveld review page should dedicate more space to Rietveld, less to high level comments form.
-
- https://bugs.webkit.org/show_bug.cgi?id=39244
-
- * template/en/custom/attachment/reviewform.html.tmpl:
- Delete a random BR amongst the hidden elements that was causing extra whitespace.
- * template/en/custom/attachment/rietveldreview.html.tmpl:
- Increase size of Rietveld frame to 80%, from 60%.
-
-2010-05-14 Julie Parent <jparent at chromium.org>
-
- Reviewed by Ojan Vafai.
-
- Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.
-
- https://bugs.webkit.org/show_bug.cgi?id=39141
-
- * template/en/custom/attachment/list.html.tmpl:
-
-2010-05-13 Julie Parent <jparent at chromium.org>
-
- Reviewed by David Kilzer.
-
- Bugzilla: Don't send mail if the only change is to the in-rietveld flag.
-
- https://bugs.webkit.org/show_bug.cgi?id=39090
-
- * Bugzilla/BugMail.pm:
-
-2010-05-12 Julie Parent <jparent at chromium.org>
-
- Reviewed by Ojan Vafai.
-
- Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
- https://bugs.webkit.org/show_bug.cgi?id=39024
-
- * template/en/custom/attachment/list.html.tmpl:
- Removes this flag entirely from the UI, not needed on this page.
- * template/en/custom/flag/list.html.tmpl: Added.
- Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
- Hides the flag rather than removing it completely, so tools can still interact with it.
-
-2010-05-12 Julie Parent <jparent at chromium.org>
-
- Reviewed by David Kilzer.
-
- Adds support for Rietveld reviews. When there is an associated
- Rietveld id for a patch, adds a link to do a Rietveld review instead.
-
- https://bugs.webkit.org/show_bug.cgi?id=38143
-
- * attachment.cgi:
- Added support for handling action=rietveldreview.
- * template/en/custom/attachment/list.html.tmpl:
- Adds a link to use rietveld review iff the in_rietveld flag is set.
- * template/en/custom/attachment/reviewform.html.tmpl:
- Detects if we are in rietveld review mode due to query string paramter,
- and customizes the review form slightly:
- - Changes text describing comment field.
- - Comment field does not include quoted patch.
- - Submit button fetches from Rietveld instead of just submitting.
- * template/en/custom/attachment/rietveldreview.html.tmpl: Added.
- New template for rietveldreview mode. Hosts the rietveld frame in the
- top and the regular comments form in the bottom.
- Uses postMessage to communicate with Rietveld frame.
-
-2010-05-08 Chris Jerdonek <cjerdonek at webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Allow long comment lines to wrap to the window width instead
- of to 80 characters.
-
- https://bugs.webkit.org/show_bug.cgi?id=37792
-
- * Bugzilla/Constants.pm:
- - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS
- inside the wrap_comment() subroutine. The new constant effectively
- disables text wrapping by increasing the value used in wrap_comment()
- from 80 characters to a very large value (8000).
- * Bugzilla/Util.pm:
- - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
- * skins/custom/global.css:
- (.bz_comment_text):
- - Eliminate the width styling on comments to allow long lines
- to wrap at the window width.
- (.bz_comment_text > span.quote):
- - Inherit the "white-space" property. This prevents long quoted
- lines in comments from causing non-quoted lines to extend beyond
- the window width.
-
-2010-04-22 Adam Barth <abarth at webkit.org>
-
- Reviewed by Darin Adler.
-
- The new review tools shouldn't clear the comment box automatically
- https://bugs.webkit.org/show_bug.cgi?id=38004
-
- Instead, we now have a button for doing that explicitly. If people
- like this tool, we can look at fancier solutions.
-
- Also, tried to make the tool work on the edit page as well as the review page.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2010-04-22 Adam Barth <abarth at webkit.org>
-
- Unreviewed. Turns out we need to do more escaping because Ruby was
- explanding our newlines, creating a syntax error.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2010-04-22 Adam Barth <abarth at webkit.org>
-
- Reviewed by Darin Adler.
-
- Hack up PrettyDiff to allow line-by-line comments
- https://bugs.webkit.org/show_bug.cgi?id=37886
-
- Admittedly a bit of a hack, this is a basic line-by-line editor we can
- play with thanks to Andrew Scherkus. It's meant to integrate with the
- "review" page at bugs.webkit.org.
-
- I changed a few things from Andrew's original version:
- 1) Trigger text boxes on single click to make iPhone/iPad reviewing
- easier.
- 2) Clear the main text box on load.
- 3) Reference a version of prototype.js on bugs.webkit.org.
-
- * PrettyPatch/PrettyPatch.rb:
- * prototype.js: Added.
-
-2010-02-22 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
-
- Reviewed by Maciej Stachowiak.
-
- Don't reset the assignee back to default on component change
-
- https://bugs.webkit.org/show_bug.cgi?id=35236
-
- There's a risk of reseting a valid assignee for example when
- triaging a bug. All components in WebKit have the default
- assignee set to webkit-unassigned at webkit.org so this should
- not cause problems for people relying on this functionality.
-
- * template/en/custom/bug/edit.html.tmpl:
-
-2010-01-22 Janusz Lewandowski <lew21 at xtreeme.org>
-
- Reviewed by Maciej Stachowiak.
-
- run-webkit-tests fails on Ruby 1.9
- https://bugs.webkit.org/show_bug.cgi?id=33554
- inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2010-01-20 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
-
- Reviewed by Adam Barth.
-
- Adjust height of status-bubbles to prevent them being cut.
-
- * template/en/custom/attachment/edit.html.tmpl:
- * template/en/custom/attachment/list.html.tmpl:
- * template/en/custom/attachment/reviewform.html.tmpl:
-
-2010-01-08 David Kilzer <ddkilzer at apple.com>
-
- <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
-
- Reviewed by Adam Barth.
-
- This button was broken during a previous Bugzilla upgrade after
- changes were made to the names of objects exposed on templates.
-
- * template/en/custom/attachment/reviewform.html.tmpl: Changed
- attachid to attachment.id and ispatch to attachment.ispatch.
- Also tweaked the format to use 4 table columns instead of 5.
-
-2010-01-08 David Kilzer <ddkilzer at apple.com>
-
- Included UNCONFIRMED bugs by default in advanced search query
-
- Rubber-stamped by Alexey Proskuryakov.
-
- * data/params: Prepended 'bug_status=UNCONFIRMED&' to
- 'defaultquery' parameter.
-
-2010-01-08 David Kilzer <ddkilzer at apple.com>
-
- FIX: Make patch status appear on reviewform.html.tmpl
-
- * template/en/custom/attachment/reviewform.html.tmpl: Check
- attachment.ispatch (not just ispatch) when deciding whether
- to display patch status. Also update layout a bit.
-
-2010-01-08 David Kilzer <ddkilzer at apple.com>
-
- Update data/params parameters
-
- * data/params: Updated 'timezone' to turn off DST. Updated
- 'usebugaliases' and 'usevotes' to turn them off.
-
-2010-01-08 Adam Barth <abarth at webkit.org>
-
- Reviewed by Darin Adler.
-
- Show patch status in bugs.webkit.org
- https://bugs.webkit.org/show_bug.cgi?id=33368
-
- This patch adds an iframe to the show_bug page and the edit attachment
- page that displays whether the attachment passed the various bots.
-
- * template/en/custom/attachment/edit.html.tmpl:
- * template/en/custom/attachment/list.html.tmpl:
- * template/en/custom/attachment/reviewform.html.tmpl:
-
-2009-12-07 Shinichiro Hamaji <hamaji at chromium.org>
-
- Reviewed by David Kilzer.
-
- Bugzilla should show images in git patches
- https://bugs.webkit.org/show_bug.cgi?id=31395
-
- Attempt to go r51748 again using --directory option of git-apply.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-12-06 Shinichiro Hamaji <hamaji at chromium.org>
-
- Unreviewed. Revert r51748.
-
- Bugzilla should show images in git patches
- https://bugs.webkit.org/show_bug.cgi?id=31395
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-12-06 Shinichiro Hamaji <hamaji at chromium.org>
-
- Reviewed by David Kilzer.
-
- Bugzilla should show images in git patches
- https://bugs.webkit.org/show_bug.cgi?id=31395
-
- Show images in git patches using git-apply.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-10-23 Eric Seidel <eric at webkit.org>
-
- Reviewed by Adam Roben.
-
- PrettyPatch should show images even when they have the wrong mime type
- https://bugs.webkit.org/show_bug.cgi?id=29506
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-10-17 Alexey Proskuryakov <ap at apple.com>
-
- Reviewed by Eric Carlson.
-
- https://bugs.webkit.org/show_bug.cgi?id=30470
- Make marking a bug as duplicate easier
-
- * js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
-
-2009-10-16 Alexey Proskuryakov <ap at apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=30470
- Make marking a bug as duplicate easier
-
- * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user
- click again.
-
-2009-09-09 David Kilzer <ddkilzer at apple.com>
-
- Update data/params parameters
-
- * data/params: Updated 'attachment_base' parameter for secure
- attachments. Updated 'mybugstemplate' parameter to search for
- bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to
- NEW status.
-
-2009-08-11 David Kilzer <ddkilzer at apple.com>
-
- Updated data/params parameter
-
- * data/params: Updated 'loginnetmask' parameter to allow users
- to choose whether their cookies are restricted to a single IP
- address or not.
-
-2009-07-07 David Kilzer <ddkilzer at apple.com>
-
- Updated BugsSite with local changes on server
-
- The new files were created by checksetup.pl during the upgrade
- to Bugzilla 3.2.3. The rest are self-explanatory.
-
- * data: Added "bugzilla-update.xml" to svn:ignore.
- * data/attachments: Added "groups.*" to svn:ignore.
- * data/params: Updated for a few changed parameters.
-
- * lib/.htaccess: Added.
- * skins/contrib/Dusk/IE-fixes.css: Added.
- * skins/contrib/Dusk/admin.css: Added.
- * skins/contrib/Dusk/create_attachment.css: Added.
- * skins/contrib/Dusk/dependency-tree.css: Added.
- * skins/contrib/Dusk/duplicates.css: Added.
- * skins/contrib/Dusk/editusers.css: Added.
- * skins/contrib/Dusk/help.css: Added.
- * skins/contrib/Dusk/index.css: Added.
- * skins/contrib/Dusk/panel.css: Added.
- * skins/contrib/Dusk/params.css: Added.
- * skins/contrib/Dusk/release-notes.css: Added.
- * skins/contrib/Dusk/show_bug.css: Added.
- * skins/contrib/Dusk/show_multiple.css: Added.
- * skins/contrib/Dusk/summarize-time.css: Added.
- * skins/contrib/Dusk/voting.css: Added.
- * skins/contrib/Dusk/yui: Added.
- * skins/contrib/Dusk/yui/calendar.css: Added.
- * skins/custom/IE-fixes.css: Added.
- * skins/custom/admin.css: Added.
- * skins/custom/buglist.css: Added.
- * skins/custom/create_attachment.css: Added.
- * skins/custom/dependency-tree.css: Added.
- * skins/custom/duplicates.css: Added.
- * skins/custom/editusers.css: Added.
- * skins/custom/help.css: Added.
- * skins/custom/panel.css: Added.
- * skins/custom/params.css: Added.
- * skins/custom/release-notes.css: Added.
- * skins/custom/show_bug.css: Added.
- * skins/custom/show_multiple.css: Added.
- * skins/custom/summarize-time.css: Added.
- * skins/custom/voting.css: Added.
- * skins/custom/yui: Added.
- * skins/custom/yui/calendar.css: Added.
-
-2009-07-03 David Kilzer <ddkilzer at apple.com>
-
- Bug 26958: Change edit link to review link in request messages
-
- <https://bugs.webkit.org/show_bug.cgi?id=26958>
-
- Reviewed by Dan Bernstein.
-
- * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl.
- Changed link from "action=edit" to "action=review".
-
-2009-07-03 David Kilzer <ddkilzer at apple.com>
-
- Bug 26950: Make the summary and alias fields support click-to-edit
- <https://bugs.webkit.org/show_bug.cgi?id=26950>
-
- Reviewed by Maciej Stachowiak.
-
- Original patch by Maciej Stachowiak.
-
- * js/field.js:
- (hideEditableField): Updated to add click event listeners to the
- alias and short description elements to make them easier to
- edit. Renamed field_id parameter to field2_id (short
- description id) and added a field1_id parameter (alias id).
- (showEditableField): If a third parameter is passed in the
- ContainerInputArray parameter, use it to find the element to
- focus. Otherwise, fall back to the original behavior of
- focusing the first input field.
- (hideAliasAndSummary): Changed to pass the id for the alias
- element to hideEditableField().
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Config file for contrib/recode.pl when upgrading bugs.webkit.org
-
- Current as of midday on Wednesday, July 1, 2009.
-
- * contrib/recode-overrides.txt: Added.
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Workaround for WebKit Bug 9630 when running contrib/recode.pl
-
- A number of WebKit nightly builds included Bug 9630 which caused
- non-breaking space characters (0xA0) to be submitted within the
- content of textarea elements.
-
- * contrib/recode.pl: To work around these 0xA0 characters, try
- an encoding of cp1252 and use it if it works.
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Don't print "Failed to guess" warning if an override is available
-
- * contrib/recode.pl: Check that %overrides does NOT contain a
- key matching the current digest before printing out the warning
- about a failed charset guess.
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Added --[no-]truncate switch to contrib/recode.pl
-
- * contrib/recode.pl: Added --[no-]truncate switch to make
- debugging of failed charset guessing easier. Often times the
- illegal character was truncated in the output.
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Changed Perl scripts to use #!/usr/bin/env perl
-
- perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl
-
-2009-07-02 David D. Kilzer <ddkilzer at apple.com>
-
- Replace Bugzilla favicon with webkit.org favicon
-
- * favicon.ico: Removed.
- * images/favicon.ico: Replaced. Copied from favicon.ico.
-
-2009-07-02 David Kilzer <ddkilzer at webkit.org>
-
- Merged BugsSite to Bugzilla-3.2.3
-
- Updated to the latest-and-greatest stable version.
-
-2009-07-02 David Kilzer <ddkilzer at webkit.org>
-
- Merged BugsSite to Bugzilla-3.0.3
-
- Nothing to see here. Move along.
-
-2009-06-09 Eric Seidel <eric at webkit.org>
-
- Reviewed by Adam Roben.
-
- Add support for displaying added png files in PrettyPatch diffs
- https://bugs.webkit.org/show_bug.cgi?id=26210
-
- Currently this is SVN only (git-send-bugzilla patches exclude binary data)
- and only works for PNG files but could easily be made to work for other images as needed.
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-05-19 Eric Seidel <eric at webkit.org>
-
- Reviewed by Adam Roben.
-
- Make PrettyPatch understand quoted filenames in git diffs.
- https://bugs.webkit.org/show_bug.cgi?id=25881
-
- * PrettyPatch/PrettyPatch.rb:
-
-2009-05-15 Simon Fraser <simon.fraser at apple.com>
-
- Carrying forwards Darin Adler's rubber stamp
-
- Make the comment field wider too.
-
- * skins/custom/global.css:
-
-2009-05-14 Simon Fraser <simon.fraser at apple.com>
-
- Reviewed by Darin Adler
-
- Make the URL, Summary and Keyword fields wider to mitigate the
- effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
- things generally better.
-
- * skins/custom/global.css:
- * template/en/custom/bug/edit.html.tmpl:
-
-2008-11-10 Darin Adler <darin at apple.com>
-
- - fix more of https://bugs.webkit.org/show_bug.cgi?id=21400
- "Edit" links for patches in comments, review queue, review emails
- should be replaced by "Review Patch" links
-
- * globals.pl: Fix cases that are automatically generated, such as links
- in comments in bugs.
-
- * template/en/custom/attachment/created.html.tmpl: Fix the link on the
- "I just created an attachment" page.
-
- * template/en/custom/request/queue.html.tmpl: Fix the link in the queue
- page.
-
-2008-11-10 Darin Adler <darin at apple.com>
-
- * template/en/default/request/queue.html.tmpl: Use review links instead
- of edit links in the review queue.
-
-2008-11-10 Darin Adler <darin at apple.com>
-
- * template/en/custom/request/email.txt.tmpl: Send review links instead
- of edit links when flags are set on a bug.
-
-2008-10-27 Darin Adler <darin at apple.com>
-
- * template/en/custom/attachment/reviewform.html.tmpl: Leave out the
- comment if it's untouched.
-
-2008-10-23 Adam Roben <aroben at apple.com>
-
- Fix Bug 21401: Comments field on "Review Patch" page should be
- initially filled with quoted patch
-
- <https://bugs.webkit.org/show_bug.cgi?id=21401>
-
- Reviewed by Dave Hyatt.
-
- * attachment.cgi:
- (edit): Retrieve the attachment data from the database instead of just
- its length. When the attachment is a patch, create a quotedpatch
- template variable that contains the patch data with each line
- prepended with "> ".
- * template/en/custom/attachment/reviewform.html.tmpl:
- - Changed the comments field to have a monospace font
- - Added an "Enter comments below:" caption above the comments field
- to make it clearer that this is where comments should go, now that
- the comments field is not initially empty
- - Fill the comments field with the quoted patch
-
-2008-10-14 Adam Roben <aroben at apple.com>
-
- Fix Bug 21602: Bugzilla times out trying to display formatted diff for
- attachment 24345
-
- https://bugs.webkit.org/show_bug.cgi?id=21602
-
- Reviewed by Dave Kilzer.
-
- * PrettyPatch/PrettyPatch.rb:
- (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added.
- (PrettyPatch.FileDiff.initialize): If any of the lines in the diff
- are a binary file marker, mark this FileDiff as binary and stop trying
- to process the lines.
- (PrettyDiff.FileDiff.to_html): If we're binary, just print a string
- saying so.
-
-2008-10-02 Adam Roben <aroben at apple.com>
-
- * template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
-
-2008-10-02 Adam Roben <aroben at apple.com>
-
- * template/en/custom/attachment/review.html.tmpl: Fix URLs
-
-2008-10-02 Adam Roben <aroben at apple.com>
-
- Fix Bug 21315: bugs.webkit.org should have a nicer patch review
- interface
-
- https://bugs.webkit.org/show_bug.cgi?id=21315
-
- Reviewed by Tim Hatcher.
-
- * attachment.cgi:
- (top level): Added support for the "review" and "reviewform" actions.
- (sub edit): Accept the template name as a parameter. If no name is
- give, use "edit" as before.
- * template/en/custom/attachment/list.html.tmpl: Added a "Review Patch"
- link for all patch attachments.
- * template/en/custom/attachment/review.html.tmpl: Added. Simple
- <frameset> page to show the patch on the top and a comment form on the
- bottom.
- * template/en/custom/attachment/reviewform.html.tmpl: Added. Simple
- comment form for reviewing patches.
-
-2008-10-02 Adam Roben <aroben at apple.com>
-
- Remove references to some backup files I created when implementing
- PrettyPatch in Bugzilla
-
- Reviewed by Tim Hatcher.
-
- * attachment-aroben.cgi: Removed.
- * template/en/default/attachment/edit-aroben.html.tmpl: Removed.
-
- * template/en/custom/attachment/edit.html.tmpl: Removed an erroneous
- reference to attachment-aroben.cgi. attachment.cgi will work just
- fine.
-
-2008-06-25 David Kilzer <ddkilzer at apple.com>
-
- Make PrettyPatch handle diffs with no Index or diff headers
-
- Part of Bug 19290: More patches not handled by PrettyPatch.rb
- <https://bugs.webkit.org/show_bug.cgi?id=19290>
-
- Reviewed by Adam.
-
- * PrettyPatch/PrettyPatch.rb:
- (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
- match on "+++ " lines for patches with no "Index" or "diff" header.
- (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
- when the first line of a patch has no "Index" or "diff" header.
- (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
- variable to determine when no "Index" or "diff" header has been
- found, but a new patch has started with a "--- " line.
-
-2008-06-08 Dan Bernstein <mitz at apple.com>
-
- Reviewed by Adam Roben.
-
- - update trac URL in PrettyPatch
-
- * PrettyPatch/PrettyPatch.rb:
-
-2008-05-29 Adam Roben <aroben at apple.com>
-
- Update PrettyPatch directory list
-
- * PrettyPatch/PrettyPatch.rb:
-
-2008-05-28 Adam Roben <aroben at apple.com>
-
- Make PrettyPatch able to handle diffs taken from outside the WebKit
- source tree
-
- Part of Bug 19290: More patches not handled by PrettyPatch.rb
- <https://bugs.webkit.org/show_bug.cgi?id=19290>
-
- Reviewed by David Kilzer.
-
- * PrettyPatch/PrettyPatch.rb:
- (PrettyPatch.find_url_and_path): Added. Searches the file path from
- the bottom up looking for a directory that exists in the source tree.
- (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.
-
-2008-05-28 Adam Roben <aroben at apple.com>
-
- Print exceptions from PrettyPatch to stdout
-
- This will make it much easier to debug problems with PrettyPatch,
- since we'll be able to see the exceptions in the browser.
-
- Reviewed by Sam Weinig.
-
- * PrettyPatch/prettify.rb: Added a --html-exceptions option, which
- will print exceptions to stdout as HTML.
- * attachment.cgi: Changed to pass --html-exceptions to prettify.rb.
-
-2008-04-26 David Kilzer <ddkilzer at apple.com>
-
- Removed temp files and added appropriate svn:ignore properties.
-
- Rubber-stamped by Mark Rowe.
-
- * data: Added svn:ignore property for "versioncache" and "versioncache.*" files.
-
- * data/template: Added svn:ignore property for "template" subdirectory.
- * data/template/template: Removed precompiled template subdirectory.
-
- * data/versioncache: Removed.
- * data/versioncache.*: Removed backup versioncache files.
-
- * data/webdot: Added svn:ignore property for "*.dot" files.
- * data/webdot/*.dot: Removed cached webdot files.
-
-2008-04-08 Adam Roben <aroben at apple.com>
-
- Combine :equal operations with the following operation if they are
- fewer than 3 characters long
-
- This keeps us from showing lots of small changes on long lines, just
- because some letters happened to be the same.
-
- Inspired by
- http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147
-
- * PrettyPatch/PrettyPatch.rb:
- (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
- than 3 characters long. The characters from the removed operations
- become part of the subsequent operation.
- (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
- <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
- @toLineNumber.nil? checks as they are no longer reliable now that
- we're removing operations.
-
-2008-04-08 Adam Roben <aroben at apple.com>
-
- Change PrettyPatch to use DiffBuilder for intra-line diffs
-
- This gives us much prettier intra-line diffs, largely because it can
- distinguish multiple changes on the same line. e.g., if a line changes
- from:
-
- const int myConstant = 0;
-
- to
-
- static const unsigned myConstant;
-
- You will see that "static " was inserted, "int" changed to "unsigned",
- and " = 0" was deleted.
-
- This seems to have also gotten rid of some spurious instances of
- "<ins></ins>" and "<del></del>" at the end of a line.
-
- * PrettyPatch/PrettyPatch.rb:
- (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
- setChangeExtentFromLine (which had been copied from Trac's diffing
- code).
- (PrettyPatch::CodeLine):
- - Removed the changeExtent attribute
- - Added the operations attribute
- - Removed the setChangeExtentFromLine method
- (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
- what text to wrap in <ins> and <del> tags.
- * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
- (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
- method, but left out the calls to perform_operation, since we build
- the diff HTML outside of this class.
- (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
- convert_html_to_list_of_words, since we're not diffing HTML.
-
-2008-04-08 Adam Roben <aroben at apple.com>
-
- Check in diff.rb
-
- This came from
- http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
- revision 28521
-
- * PrettyPatch/diff.rb: Added.
-
-2008-03-04 Adam Roben <aroben at apple.com>
-
- * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to
- be omitted from the hunk header.
-
+2010-08-19 Tony Chang <tony at chromium.org>
+
+ Unreviewed. Just removing \r's from ChangeLog.
+
+2010-08-02 Adam Roben <aroben at apple.com>
+
+ Tell the patch prettifier about some (not so) new directories
+
+ * PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake
+ directories.
+
+2010-07-27 Joseph Pecoraro <joepeck at webkit.org>
+
+ Reviewed by David Kilzer.
+
+ Provide a Helpful Link for Web Inspector Bugs in Bugzilla
+ https://bugs.webkit.org/show_bug.cgi?id=43065
+
+ * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.
+
+2010-06-09 Julie Parent <jparent at chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
+
+ https://bugs.webkit.org/show_bug.cgi?id=40345
+
+ * Bugzilla/Flag.pm:
+
+2010-05-17 Julie Parent <jparent at chromium.org>
+
+ Reviewed by Ojan Vafai.
+
+ Rietveld review page should dedicate more space to Rietveld, less to high level comments form.
+
+ https://bugs.webkit.org/show_bug.cgi?id=39244
+
+ * template/en/custom/attachment/reviewform.html.tmpl:
+ Delete a random BR amongst the hidden elements that was causing extra whitespace.
+ * template/en/custom/attachment/rietveldreview.html.tmpl:
+ Increase size of Rietveld frame to 80%, from 60%.
+
+2010-05-14 Julie Parent <jparent at chromium.org>
+
+ Reviewed by Ojan Vafai.
+
+ Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.
+
+ https://bugs.webkit.org/show_bug.cgi?id=39141
+
+ * template/en/custom/attachment/list.html.tmpl:
+
+2010-05-13 Julie Parent <jparent at chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Bugzilla: Don't send mail if the only change is to the in-rietveld flag.
+
+ https://bugs.webkit.org/show_bug.cgi?id=39090
+
+ * Bugzilla/BugMail.pm:
+
+2010-05-12 Julie Parent <jparent at chromium.org>
+
+ Reviewed by Ojan Vafai.
+
+ Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
+ https://bugs.webkit.org/show_bug.cgi?id=39024
+
+ * template/en/custom/attachment/list.html.tmpl:
+ Removes this flag entirely from the UI, not needed on this page.
+ * template/en/custom/flag/list.html.tmpl: Added.
+ Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
+ Hides the flag rather than removing it completely, so tools can still interact with it.
+
+2010-05-12 Julie Parent <jparent at chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Adds support for Rietveld reviews. When there is an associated
+ Rietveld id for a patch, adds a link to do a Rietveld review instead.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38143
+
+ * attachment.cgi:
+ Added support for handling action=rietveldreview.
+ * template/en/custom/attachment/list.html.tmpl:
+ Adds a link to use rietveld review iff the in_rietveld flag is set.
+ * template/en/custom/attachment/reviewform.html.tmpl:
+ Detects if we are in rietveld review mode due to query string paramter,
+ and customizes the review form slightly:
+ - Changes text describing comment field.
+ - Comment field does not include quoted patch.
+ - Submit button fetches from Rietveld instead of just submitting.
+ * template/en/custom/attachment/rietveldreview.html.tmpl: Added.
+ New template for rietveldreview mode. Hosts the rietveld frame in the
+ top and the regular comments form in the bottom.
+ Uses postMessage to communicate with Rietveld frame.
+
+2010-05-08 Chris Jerdonek <cjerdonek at webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Allow long comment lines to wrap to the window width instead
+ of to 80 characters.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37792
+
+ * Bugzilla/Constants.pm:
+ - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS
+ inside the wrap_comment() subroutine. The new constant effectively
+ disables text wrapping by increasing the value used in wrap_comment()
+ from 80 characters to a very large value (8000).
+ * Bugzilla/Util.pm:
+ - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
+ * skins/custom/global.css:
+ (.bz_comment_text):
+ - Eliminate the width styling on comments to allow long lines
+ to wrap at the window width.
+ (.bz_comment_text > span.quote):
+ - Inherit the "white-space" property. This prevents long quoted
+ lines in comments from causing non-quoted lines to extend beyond
+ the window width.
+
+2010-04-22 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Darin Adler.
+
+ The new review tools shouldn't clear the comment box automatically
+ https://bugs.webkit.org/show_bug.cgi?id=38004
+
+ Instead, we now have a button for doing that explicitly. If people
+ like this tool, we can look at fancier solutions.
+
+ Also, tried to make the tool work on the edit page as well as the review page.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2010-04-22 Adam Barth <abarth at webkit.org>
+
+ Unreviewed. Turns out we need to do more escaping because Ruby was
+ explanding our newlines, creating a syntax error.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2010-04-22 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Hack up PrettyDiff to allow line-by-line comments
+ https://bugs.webkit.org/show_bug.cgi?id=37886
+
+ Admittedly a bit of a hack, this is a basic line-by-line editor we can
+ play with thanks to Andrew Scherkus. It's meant to integrate with the
+ "review" page at bugs.webkit.org.
+
+ I changed a few things from Andrew's original version:
+ 1) Trigger text boxes on single click to make iPhone/iPad reviewing
+ easier.
+ 2) Clear the main text box on load.
+ 3) Reference a version of prototype.js on bugs.webkit.org.
+
+ * PrettyPatch/PrettyPatch.rb:
+ * prototype.js: Added.
+
+2010-02-22 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Don't reset the assignee back to default on component change
+
+ https://bugs.webkit.org/show_bug.cgi?id=35236
+
+ There's a risk of reseting a valid assignee for example when
+ triaging a bug. All components in WebKit have the default
+ assignee set to webkit-unassigned at webkit.org so this should
+ not cause problems for people relying on this functionality.
+
+ * template/en/custom/bug/edit.html.tmpl:
+
+2010-01-22 Janusz Lewandowski <lew21 at xtreeme.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ run-webkit-tests fails on Ruby 1.9
+ https://bugs.webkit.org/show_bug.cgi?id=33554
+ inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2010-01-20 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
+
+ Reviewed by Adam Barth.
+
+ Adjust height of status-bubbles to prevent them being cut.
+
+ * template/en/custom/attachment/edit.html.tmpl:
+ * template/en/custom/attachment/list.html.tmpl:
+ * template/en/custom/attachment/reviewform.html.tmpl:
+
+2010-01-08 David Kilzer <ddkilzer at apple.com>
+
+ <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
+
+ Reviewed by Adam Barth.
+
+ This button was broken during a previous Bugzilla upgrade after
+ changes were made to the names of objects exposed on templates.
+
+ * template/en/custom/attachment/reviewform.html.tmpl: Changed
+ attachid to attachment.id and ispatch to attachment.ispatch.
+ Also tweaked the format to use 4 table columns instead of 5.
+
+2010-01-08 David Kilzer <ddkilzer at apple.com>
+
+ Included UNCONFIRMED bugs by default in advanced search query
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ * data/params: Prepended 'bug_status=UNCONFIRMED&' to
+ 'defaultquery' parameter.
+
+2010-01-08 David Kilzer <ddkilzer at apple.com>
+
+ FIX: Make patch status appear on reviewform.html.tmpl
+
+ * template/en/custom/attachment/reviewform.html.tmpl: Check
+ attachment.ispatch (not just ispatch) when deciding whether
+ to display patch status. Also update layout a bit.
+
+2010-01-08 David Kilzer <ddkilzer at apple.com>
+
+ Update data/params parameters
+
+ * data/params: Updated 'timezone' to turn off DST. Updated
+ 'usebugaliases' and 'usevotes' to turn them off.
+
+2010-01-08 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Show patch status in bugs.webkit.org
+ https://bugs.webkit.org/show_bug.cgi?id=33368
+
+ This patch adds an iframe to the show_bug page and the edit attachment
+ page that displays whether the attachment passed the various bots.
+
+ * template/en/custom/attachment/edit.html.tmpl:
+ * template/en/custom/attachment/list.html.tmpl:
+ * template/en/custom/attachment/reviewform.html.tmpl:
+
+2009-12-07 Shinichiro Hamaji <hamaji at chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Bugzilla should show images in git patches
+ https://bugs.webkit.org/show_bug.cgi?id=31395
+
+ Attempt to go r51748 again using --directory option of git-apply.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-12-06 Shinichiro Hamaji <hamaji at chromium.org>
+
+ Unreviewed. Revert r51748.
+
+ Bugzilla should show images in git patches
+ https://bugs.webkit.org/show_bug.cgi?id=31395
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-12-06 Shinichiro Hamaji <hamaji at chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Bugzilla should show images in git patches
+ https://bugs.webkit.org/show_bug.cgi?id=31395
+
+ Show images in git patches using git-apply.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-10-23 Eric Seidel <eric at webkit.org>
+
+ Reviewed by Adam Roben.
+
+ PrettyPatch should show images even when they have the wrong mime type
+ https://bugs.webkit.org/show_bug.cgi?id=29506
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-10-17 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Eric Carlson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=30470
+ Make marking a bug as duplicate easier
+
+ * js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
+
+2009-10-16 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=30470
+ Make marking a bug as duplicate easier
+
+ * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user
+ click again.
+
+2009-09-09 David Kilzer <ddkilzer at apple.com>
+
+ Update data/params parameters
+
+ * data/params: Updated 'attachment_base' parameter for secure
+ attachments. Updated 'mybugstemplate' parameter to search for
+ bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to
+ NEW status.
+
+2009-08-11 David Kilzer <ddkilzer at apple.com>
+
+ Updated data/params parameter
+
+ * data/params: Updated 'loginnetmask' parameter to allow users
+ to choose whether their cookies are restricted to a single IP
+ address or not.
+
+2009-07-07 David Kilzer <ddkilzer at apple.com>
+
+ Updated BugsSite with local changes on server
+
+ The new files were created by checksetup.pl during the upgrade
+ to Bugzilla 3.2.3. The rest are self-explanatory.
+
+ * data: Added "bugzilla-update.xml" to svn:ignore.
+ * data/attachments: Added "groups.*" to svn:ignore.
+ * data/params: Updated for a few changed parameters.
+
+ * lib/.htaccess: Added.
+ * skins/contrib/Dusk/IE-fixes.css: Added.
+ * skins/contrib/Dusk/admin.css: Added.
+ * skins/contrib/Dusk/create_attachment.css: Added.
+ * skins/contrib/Dusk/dependency-tree.css: Added.
+ * skins/contrib/Dusk/duplicates.css: Added.
+ * skins/contrib/Dusk/editusers.css: Added.
+ * skins/contrib/Dusk/help.css: Added.
+ * skins/contrib/Dusk/index.css: Added.
+ * skins/contrib/Dusk/panel.css: Added.
+ * skins/contrib/Dusk/params.css: Added.
+ * skins/contrib/Dusk/release-notes.css: Added.
+ * skins/contrib/Dusk/show_bug.css: Added.
+ * skins/contrib/Dusk/show_multiple.css: Added.
+ * skins/contrib/Dusk/summarize-time.css: Added.
+ * skins/contrib/Dusk/voting.css: Added.
+ * skins/contrib/Dusk/yui: Added.
+ * skins/contrib/Dusk/yui/calendar.css: Added.
+ * skins/custom/IE-fixes.css: Added.
+ * skins/custom/admin.css: Added.
+ * skins/custom/buglist.css: Added.
+ * skins/custom/create_attachment.css: Added.
+ * skins/custom/dependency-tree.css: Added.
+ * skins/custom/duplicates.css: Added.
+ * skins/custom/editusers.css: Added.
+ * skins/custom/help.css: Added.
+ * skins/custom/panel.css: Added.
+ * skins/custom/params.css: Added.
+ * skins/custom/release-notes.css: Added.
+ * skins/custom/show_bug.css: Added.
+ * skins/custom/show_multiple.css: Added.
+ * skins/custom/summarize-time.css: Added.
+ * skins/custom/voting.css: Added.
+ * skins/custom/yui: Added.
+ * skins/custom/yui/calendar.css: Added.
+
+2009-07-03 David Kilzer <ddkilzer at apple.com>
+
+ Bug 26958: Change edit link to review link in request messages
+
+ <https://bugs.webkit.org/show_bug.cgi?id=26958>
+
+ Reviewed by Dan Bernstein.
+
+ * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl.
+ Changed link from "action=edit" to "action=review".
+
+2009-07-03 David Kilzer <ddkilzer at apple.com>
+
+ Bug 26950: Make the summary and alias fields support click-to-edit
+ <https://bugs.webkit.org/show_bug.cgi?id=26950>
+
+ Reviewed by Maciej Stachowiak.
+
+ Original patch by Maciej Stachowiak.
+
+ * js/field.js:
+ (hideEditableField): Updated to add click event listeners to the
+ alias and short description elements to make them easier to
+ edit. Renamed field_id parameter to field2_id (short
+ description id) and added a field1_id parameter (alias id).
+ (showEditableField): If a third parameter is passed in the
+ ContainerInputArray parameter, use it to find the element to
+ focus. Otherwise, fall back to the original behavior of
+ focusing the first input field.
+ (hideAliasAndSummary): Changed to pass the id for the alias
+ element to hideEditableField().
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Config file for contrib/recode.pl when upgrading bugs.webkit.org
+
+ Current as of midday on Wednesday, July 1, 2009.
+
+ * contrib/recode-overrides.txt: Added.
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Workaround for WebKit Bug 9630 when running contrib/recode.pl
+
+ A number of WebKit nightly builds included Bug 9630 which caused
+ non-breaking space characters (0xA0) to be submitted within the
+ content of textarea elements.
+
+ * contrib/recode.pl: To work around these 0xA0 characters, try
+ an encoding of cp1252 and use it if it works.
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Don't print "Failed to guess" warning if an override is available
+
+ * contrib/recode.pl: Check that %overrides does NOT contain a
+ key matching the current digest before printing out the warning
+ about a failed charset guess.
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Added --[no-]truncate switch to contrib/recode.pl
+
+ * contrib/recode.pl: Added --[no-]truncate switch to make
+ debugging of failed charset guessing easier. Often times the
+ illegal character was truncated in the output.
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Changed Perl scripts to use #!/usr/bin/env perl
+
+ perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl
+
+2009-07-02 David D. Kilzer <ddkilzer at apple.com>
+
+ Replace Bugzilla favicon with webkit.org favicon
+
+ * favicon.ico: Removed.
+ * images/favicon.ico: Replaced. Copied from favicon.ico.
+
+2009-07-02 David Kilzer <ddkilzer at webkit.org>
+
+ Merged BugsSite to Bugzilla-3.2.3
+
+ Updated to the latest-and-greatest stable version.
+
+2009-07-02 David Kilzer <ddkilzer at webkit.org>
+
+ Merged BugsSite to Bugzilla-3.0.3
+
+ Nothing to see here. Move along.
+
+2009-06-09 Eric Seidel <eric at webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add support for displaying added png files in PrettyPatch diffs
+ https://bugs.webkit.org/show_bug.cgi?id=26210
+
+ Currently this is SVN only (git-send-bugzilla patches exclude binary data)
+ and only works for PNG files but could easily be made to work for other images as needed.
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-05-19 Eric Seidel <eric at webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Make PrettyPatch understand quoted filenames in git diffs.
+ https://bugs.webkit.org/show_bug.cgi?id=25881
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2009-05-15 Simon Fraser <simon.fraser at apple.com>
+
+ Carrying forwards Darin Adler's rubber stamp
+
+ Make the comment field wider too.
+
+ * skins/custom/global.css:
+
+2009-05-14 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Darin Adler
+
+ Make the URL, Summary and Keyword fields wider to mitigate the
+ effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
+ things generally better.
+
+ * skins/custom/global.css:
+ * template/en/custom/bug/edit.html.tmpl:
+
+2008-11-10 Darin Adler <darin at apple.com>
+
+ - fix more of https://bugs.webkit.org/show_bug.cgi?id=21400
+ "Edit" links for patches in comments, review queue, review emails
+ should be replaced by "Review Patch" links
+
+ * globals.pl: Fix cases that are automatically generated, such as links
+ in comments in bugs.
+
+ * template/en/custom/attachment/created.html.tmpl: Fix the link on the
+ "I just created an attachment" page.
+
+ * template/en/custom/request/queue.html.tmpl: Fix the link in the queue
+ page.
+
+2008-11-10 Darin Adler <darin at apple.com>
+
+ * template/en/default/request/queue.html.tmpl: Use review links instead
+ of edit links in the review queue.
+
+2008-11-10 Darin Adler <darin at apple.com>
+
+ * template/en/custom/request/email.txt.tmpl: Send review links instead
+ of edit links when flags are set on a bug.
+
+2008-10-27 Darin Adler <darin at apple.com>
+
+ * template/en/custom/attachment/reviewform.html.tmpl: Leave out the
+ comment if it's untouched.
+
+2008-10-23 Adam Roben <aroben at apple.com>
+
+ Fix Bug 21401: Comments field on "Review Patch" page should be
+ initially filled with quoted patch
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21401>
+
+ Reviewed by Dave Hyatt.
+
+ * attachment.cgi:
+ (edit): Retrieve the attachment data from the database instead of just
+ its length. When the attachment is a patch, create a quotedpatch
+ template variable that contains the patch data with each line
+ prepended with "> ".
+ * template/en/custom/attachment/reviewform.html.tmpl:
+ - Changed the comments field to have a monospace font
+ - Added an "Enter comments below:" caption above the comments field
+ to make it clearer that this is where comments should go, now that
+ the comments field is not initially empty
+ - Fill the comments field with the quoted patch
+
+2008-10-14 Adam Roben <aroben at apple.com>
+
+ Fix Bug 21602: Bugzilla times out trying to display formatted diff for
+ attachment 24345
+
+ https://bugs.webkit.org/show_bug.cgi?id=21602
+
+ Reviewed by Dave Kilzer.
+
+ * PrettyPatch/PrettyPatch.rb:
+ (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added.
+ (PrettyPatch.FileDiff.initialize): If any of the lines in the diff
+ are a binary file marker, mark this FileDiff as binary and stop trying
+ to process the lines.
+ (PrettyDiff.FileDiff.to_html): If we're binary, just print a string
+ saying so.
+
+2008-10-02 Adam Roben <aroben at apple.com>
+
+ * template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
+
+2008-10-02 Adam Roben <aroben at apple.com>
+
+ * template/en/custom/attachment/review.html.tmpl: Fix URLs
+
+2008-10-02 Adam Roben <aroben at apple.com>
+
+ Fix Bug 21315: bugs.webkit.org should have a nicer patch review
+ interface
+
+ https://bugs.webkit.org/show_bug.cgi?id=21315
+
+ Reviewed by Tim Hatcher.
+
+ * attachment.cgi:
+ (top level): Added support for the "review" and "reviewform" actions.
+ (sub edit): Accept the template name as a parameter. If no name is
+ give, use "edit" as before.
+ * template/en/custom/attachment/list.html.tmpl: Added a "Review Patch"
+ link for all patch attachments.
+ * template/en/custom/attachment/review.html.tmpl: Added. Simple
+ <frameset> page to show the patch on the top and a comment form on the
+ bottom.
+ * template/en/custom/attachment/reviewform.html.tmpl: Added. Simple
+ comment form for reviewing patches.
+
+2008-10-02 Adam Roben <aroben at apple.com>
+
+ Remove references to some backup files I created when implementing
+ PrettyPatch in Bugzilla
+
+ Reviewed by Tim Hatcher.
+
+ * attachment-aroben.cgi: Removed.
+ * template/en/default/attachment/edit-aroben.html.tmpl: Removed.
+
+ * template/en/custom/attachment/edit.html.tmpl: Removed an erroneous
+ reference to attachment-aroben.cgi. attachment.cgi will work just
+ fine.
+
+2008-06-25 David Kilzer <ddkilzer at apple.com>
+
+ Make PrettyPatch handle diffs with no Index or diff headers
+
+ Part of Bug 19290: More patches not handled by PrettyPatch.rb
+ <https://bugs.webkit.org/show_bug.cgi?id=19290>
+
+ Reviewed by Adam.
+
+ * PrettyPatch/PrettyPatch.rb:
+ (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
+ match on "+++ " lines for patches with no "Index" or "diff" header.
+ (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
+ when the first line of a patch has no "Index" or "diff" header.
+ (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
+ variable to determine when no "Index" or "diff" header has been
+ found, but a new patch has started with a "--- " line.
+
+2008-06-08 Dan Bernstein <mitz at apple.com>
+
+ Reviewed by Adam Roben.
+
+ - update trac URL in PrettyPatch
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2008-05-29 Adam Roben <aroben at apple.com>
+
+ Update PrettyPatch directory list
+
+ * PrettyPatch/PrettyPatch.rb:
+
+2008-05-28 Adam Roben <aroben at apple.com>
+
+ Make PrettyPatch able to handle diffs taken from outside the WebKit
+ source tree
+
+ Part of Bug 19290: More patches not handled by PrettyPatch.rb
+ <https://bugs.webkit.org/show_bug.cgi?id=19290>
+
+ Reviewed by David Kilzer.
+
+ * PrettyPatch/PrettyPatch.rb:
+ (PrettyPatch.find_url_and_path): Added. Searches the file path from
+ the bottom up looking for a directory that exists in the source tree.
+ (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.
+
+2008-05-28 Adam Roben <aroben at apple.com>
+
+ Print exceptions from PrettyPatch to stdout
+
+ This will make it much easier to debug problems with PrettyPatch,
+ since we'll be able to see the exceptions in the browser.
+
+ Reviewed by Sam Weinig.
+
+ * PrettyPatch/prettify.rb: Added a --html-exceptions option, which
+ will print exceptions to stdout as HTML.
+ * attachment.cgi: Changed to pass --html-exceptions to prettify.rb.
+
+2008-04-26 David Kilzer <ddkilzer at apple.com>
+
+ Removed temp files and added appropriate svn:ignore properties.
+
+ Rubber-stamped by Mark Rowe.
+
+ * data: Added svn:ignore property for "versioncache" and "versioncache.*" files.
+
+ * data/template: Added svn:ignore property for "template" subdirectory.
+ * data/template/template: Removed precompiled template subdirectory.
+
+ * data/versioncache: Removed.
+ * data/versioncache.*: Removed backup versioncache files.
+
+ * data/webdot: Added svn:ignore property for "*.dot" files.
+ * data/webdot/*.dot: Removed cached webdot files.
+
+2008-04-08 Adam Roben <aroben at apple.com>
+
+ Combine :equal operations with the following operation if they are
+ fewer than 3 characters long
+
+ This keeps us from showing lots of small changes on long lines, just
+ because some letters happened to be the same.
+
+ Inspired by
+ http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147
+
+ * PrettyPatch/PrettyPatch.rb:
+ (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
+ than 3 characters long. The characters from the removed operations
+ become part of the subsequent operation.
+ (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
+ <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
+ @toLineNumber.nil? checks as they are no longer reliable now that
+ we're removing operations.
+
+2008-04-08 Adam Roben <aroben at apple.com>
+
+ Change PrettyPatch to use DiffBuilder for intra-line diffs
+
+ This gives us much prettier intra-line diffs, largely because it can
+ distinguish multiple changes on the same line. e.g., if a line changes
+ from:
+
+ const int myConstant = 0;
+
+ to
+
+ static const unsigned myConstant;
+
+ You will see that "static " was inserted, "int" changed to "unsigned",
+ and " = 0" was deleted.
+
+ This seems to have also gotten rid of some spurious instances of
+ "<ins></ins>" and "<del></del>" at the end of a line.
+
+ * PrettyPatch/PrettyPatch.rb:
+ (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
+ setChangeExtentFromLine (which had been copied from Trac's diffing
+ code).
+ (PrettyPatch::CodeLine):
+ - Removed the changeExtent attribute
+ - Added the operations attribute
+ - Removed the setChangeExtentFromLine method
+ (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
+ what text to wrap in <ins> and <del> tags.
+ * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
+ (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
+ method, but left out the calls to perform_operation, since we build
+ the diff HTML outside of this class.
+ (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
+ convert_html_to_list_of_words, since we're not diffing HTML.
+
+2008-04-08 Adam Roben <aroben at apple.com>
+
+ Check in diff.rb
+
+ This came from
+ http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
+ revision 28521
+
+ * PrettyPatch/diff.rb: Added.
+
+2008-03-04 Adam Roben <aroben at apple.com>
+
+ * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to
+ be omitted from the hunk header.
+
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list