[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

mrobinson at webkit.org mrobinson at webkit.org
Wed Dec 22 12:27:02 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 3f80fed4cf64eab2485ebb47bbe7179e9414e8f6
Author: mrobinson at webkit.org <mrobinson at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Aug 23 23:32:09 2010 +0000

    2010-08-23  Martin Robinson  <mrobinson at igalia.com>
    
            Reviewed by Gustavo Noronha Silva.
    
            [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
            https://bugs.webkit.org/show_bug.cgi?id=44465
    
            Initialize the axes field of mouse button and motion events to null.
            This is the value that should be used for events originating from the
            mouse device.
    
            * DumpRenderTree/gtk/EventSender.cpp:
            (prepareMouseButtonEvent): Initalize button event axes field to null.
            (mouseMoveToCallback): Initialize motion event axes field to null.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 6323a4f..0177d34 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,18 @@
+2010-08-23  Martin Robinson  <mrobinson at igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
+        https://bugs.webkit.org/show_bug.cgi?id=44465
+
+        Initialize the axes field of mouse button and motion events to null.
+        This is the value that should be used for events originating from the
+        mouse device.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (prepareMouseButtonEvent): Initalize button event axes field to null.
+        (mouseMoveToCallback): Initialize motion event axes field to null.
+
 2010-08-23  Sheriff Bot  <webkit.review.bot at gmail.com>
 
         Unreviewed, rolling out r65703.
diff --git a/WebKitTools/DumpRenderTree/gtk/EventSender.cpp b/WebKitTools/DumpRenderTree/gtk/EventSender.cpp
index 4f4246f..546d8ce 100644
--- a/WebKitTools/DumpRenderTree/gtk/EventSender.cpp
+++ b/WebKitTools/DumpRenderTree/gtk/EventSender.cpp
@@ -164,6 +164,7 @@ bool prepareMouseButtonEvent(GdkEvent* event, int eventSenderButtonNumber)
     event->button.device = gdk_device_get_core_pointer();
     event->button.state = getStateFlags();
     event->button.time = GDK_CURRENT_TIME;
+    event->button.axes = 0;
 
     int xRoot, yRoot;
     gdk_window_get_root_coords(gtk_widget_get_window(GTK_WIDGET(view)), lastMousePositionX, lastMousePositionY, &xRoot, &yRoot);
@@ -290,6 +291,7 @@ static JSValueRef mouseMoveToCallback(JSContextRef context, JSObjectRef function
     event.motion.window = gtk_widget_get_window(GTK_WIDGET(view));
     event.motion.device = gdk_device_get_core_pointer();
     event.motion.state = getStateFlags();
+    event.motion.axes = 0;
 
     int xRoot, yRoot;
     gdk_window_get_root_coords(gtk_widget_get_window(GTK_WIDGET(view)), lastMousePositionX, lastMousePositionY, &xRoot, &yRoot);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list