[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
simon.fraser at apple.com
simon.fraser at apple.com
Wed Dec 22 12:30:03 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit bfe28066e2bc8f95dfdd818e00e404a3c1feda8f
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Aug 24 21:01:16 2010 +0000
2010-08-24 Simon Fraser <simon.fraser at apple.com>
Reviewed by Tony Chang.
After r65681, caret no longer displays promptly while editing form fields
https://bugs.webkit.org/show_bug.cgi?id=44294
The caret no longer eagerly updates its rect on every paint, so we have
to manually update it after scrolling the selection into view when
the selection changes.
Tested by the pixel results of fast/forms/input-text-scroll-left-on-blur.html
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3906e5e..a351b4a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2010-08-24 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Tony Chang.
+
+ After r65681, caret no longer displays promptly while editing form fields
+ https://bugs.webkit.org/show_bug.cgi?id=44294
+
+ The caret no longer eagerly updates its rect on every paint, so we have
+ to manually update it after scrolling the selection into view when
+ the selection changes.
+
+ Tested by the pixel results of fast/forms/input-text-scroll-left-on-blur.html
+
+ * page/Frame.cpp:
+ (WebCore::Frame::revealSelection):
+
2010-08-24 Adam Barth <abarth at webkit.org>
Reviewed by Darin Adler.
diff --git a/WebCore/page/Frame.cpp b/WebCore/page/Frame.cpp
index 271c223..a013f39 100644
--- a/WebCore/page/Frame.cpp
+++ b/WebCore/page/Frame.cpp
@@ -1084,8 +1084,10 @@ void Frame::revealSelection(const ScrollAlignment& alignment, bool revealExtent)
// FIXME: This code only handles scrolling the startContainer's layer, but
// the selection rect could intersect more than just that.
// See <rdar://problem/4799899>.
- if (RenderLayer* layer = start.node()->renderer()->enclosingLayer())
+ if (RenderLayer* layer = start.node()->renderer()->enclosingLayer()) {
layer->scrollRectToVisible(rect, false, alignment, alignment);
+ selection()->updateAppearance();
+ }
}
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list