[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[abarth at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit e7ba617acbdc2d30362c96ba4747bdf100343328
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Aug 25 01:49:24 2010 +0000

    2010-08-24  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Dimitri Glazkov.
    
            [Chromium] Hulu popups are blocked
            https://bugs.webkit.org/show_bug.cgi?id=44572
    
            We were blocking popups created by Flash Player because we were never
            setting the UserGestureIndicator for events.  Most WebKit ports handle
            events through EventHandler, but Chromium is special (for some unknown
            reason) and dispatches events directly.  That means Chromium misses out
            on some of the work done by EventHandler, including setting the
            UserGestureIndicator.
    
            I suspect this is covered by an existing LayoutTest, but I don't have
            the ability to run the Chromium LayoutTests on this machine.  :(
    
            * src/WebViewImpl.cpp:
            (WebKit::WebViewImpl::handleInputEvent):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 10d859b..047a69c 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,23 @@
+2010-08-24  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Hulu popups are blocked
+        https://bugs.webkit.org/show_bug.cgi?id=44572
+
+        We were blocking popups created by Flash Player because we were never
+        setting the UserGestureIndicator for events.  Most WebKit ports handle
+        events through EventHandler, but Chromium is special (for some unknown
+        reason) and dispatches events directly.  That means Chromium misses out
+        on some of the work done by EventHandler, including setting the
+        UserGestureIndicator.
+
+        I suspect this is covered by an existing LayoutTest, but I don't have
+        the ability to run the Chromium LayoutTests on this machine.  :(
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::handleInputEvent):
+
 2010-08-24  Jian Li  <jianli at chromium.org>
 
         Reviewed by Darin Fisher.
diff --git a/WebKit/chromium/src/WebViewImpl.cpp b/WebKit/chromium/src/WebViewImpl.cpp
index 62b20d5..383b716 100644
--- a/WebKit/chromium/src/WebViewImpl.cpp
+++ b/WebKit/chromium/src/WebViewImpl.cpp
@@ -88,6 +88,7 @@
 #include "Settings.h"
 #include "Timer.h"
 #include "TypingCommand.h"
+#include "UserGestureIndicator.h"
 #include "Vector.h"
 #include "WebAccessibilityObject.h"
 #include "WebDevToolsAgentPrivate.h"
@@ -980,6 +981,8 @@ const WebInputEvent* WebViewImpl::m_currentInputEvent = 0;
 
 bool WebViewImpl::handleInputEvent(const WebInputEvent& inputEvent)
 {
+    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
+
     // If we've started a drag and drop operation, ignore input events until
     // we're done.
     if (m_doingDragAndDrop)

-- 
WebKit Debian packaging