[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

andreas.kling at nokia.com andreas.kling at nokia.com
Wed Dec 22 12:35:37 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit e82d1689bd57d6d8bd93bf3d61e8754db4318d5b
Author: andreas.kling at nokia.com <andreas.kling at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Aug 25 20:08:20 2010 +0000

    2010-08-25  Andreas Kling  <andreas.kling at nokia.com>
    
            Reviewed by Ariya Hidayat.
    
            [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)
    
            We weren't setting it explicitly which caused us to use Qt::MiterJoin when
            we actually want Qt::SvgMiterJoin.
    
            Fixes display glitches on the "Monster" chrome experiment among other things.
    
            * platform/graphics/qt/GraphicsContextQt.cpp:
            (WebCore::GraphicsContext::GraphicsContext):
    2010-08-25  Andreas Kling  <andreas.kling at nokia.com>
    
            Reviewed by Ariya Hidayat.
    
            [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)
    
            Skip canvas/philip/tests/2d.path.rect.zero.1.html
            It was working because we didn't properly initialize the GC's LineJoin mode.
    
            * platform/qt/Skipped:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 2e75f8d..c565a4f 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-08-25  Andreas Kling  <andreas.kling at nokia.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)
+
+        Skip canvas/philip/tests/2d.path.rect.zero.1.html
+        It was working because we didn't properly initialize the GC's LineJoin mode.
+
+        * platform/qt/Skipped:
+
 2010-08-25  Fady Samuel  <fsamuel at chromium.org>
 
         Reviewed by Dimitri Glazkov.
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
index 131f7b2..9fd98ba 100644
--- a/LayoutTests/platform/qt/Skipped
+++ b/LayoutTests/platform/qt/Skipped
@@ -5285,6 +5285,9 @@ canvas/philip/tests/2d.drawImage.broken.html
 # https://bugs.webkit.org/show_bug.cgi?id=40362
 canvas/philip/tests/2d.path.stroke.overlap.html
 
+# Originally worked because we didn't set the GC's join style properly.
+canvas/philip/tests/2d.path.rect.zero.1.html
+
 # ============================================================================= #
 # failing transforms tests
 # ============================================================================= #
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 938d785..cd141de 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-08-25  Andreas Kling  <andreas.kling at nokia.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)
+
+        We weren't setting it explicitly which caused us to use Qt::MiterJoin when
+        we actually want Qt::SvgMiterJoin.
+
+        Fixes display glitches on the "Monster" chrome experiment among other things.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::GraphicsContext):
+
 2010-08-25  Rafael Antognolli  <antognolli at profusion.mobi>
 
         Unreviewed build fix.
diff --git a/WebCore/platform/graphics/qt/GraphicsContextQt.cpp b/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
index 67b55ed..41c9759 100644
--- a/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
+++ b/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
@@ -256,6 +256,9 @@ GraphicsContext::GraphicsContext(PlatformGraphicsContext* context)
         // Make sure the context starts in sync with our state.
         setPlatformFillColor(fillColor(), DeviceColorSpace);
         setPlatformStrokeColor(strokeColor(), DeviceColorSpace);
+
+        // Make sure we start with the correct join mode.
+        setLineJoin(MiterJoin);
     }
 }
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list