[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

benjamin.poulain at nokia.com benjamin.poulain at nokia.com
Wed Dec 22 12:38:17 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 2f2b67ebac3c56beb8e50f327b78ead8d9ca8720
Author: benjamin.poulain at nokia.com <benjamin.poulain at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Aug 26 12:06:22 2010 +0000

    2010-08-26  Benjamin Poulain  <benjamin.poulain at nokia.com>
    
            Reviewed by Simon Hausmann.
    
            [Qt] tst_QWebFrame::popupFocus() hardcode the element position
            https://bugs.webkit.org/show_bug.cgi?id=44674
    
            This patch dynamically find the position of the combo element instead
            of hardcoding a position to click.
    
            * tests/qwebframe/tst_qwebframe.cpp:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
index 9969ebd..0a4fd3d 100644
--- a/WebKit/qt/ChangeLog
+++ b/WebKit/qt/ChangeLog
@@ -1,3 +1,15 @@
+2010-08-26  Benjamin Poulain  <benjamin.poulain at nokia.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] tst_QWebFrame::popupFocus() hardcode the element position
+        https://bugs.webkit.org/show_bug.cgi?id=44674
+
+        This patch dynamically find the position of the combo element instead
+        of hardcoding a position to click.
+
+        * tests/qwebframe/tst_qwebframe.cpp:
+
 2010-08-25  Leo Yang  <leo.yang at torchmobile.com.cn>
 
         Reviewed by Simon Hausmann.
diff --git a/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp b/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
index 83b8600..64971d0 100644
--- a/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
+++ b/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
@@ -2678,7 +2678,8 @@ void tst_QWebFrame::popupFocus()
     QTRY_VERIFY(view.hasFocus());
 
     // open the popup by clicking. check if focus is on the popup
-    QTest::mouseClick(&view, Qt::LeftButton, 0, QPoint(25, 25));
+    const QWebElement webCombo = view.page()->mainFrame()->documentElement().findFirst(QLatin1String("select[name=select]"));
+    QTest::mouseClick(&view, Qt::LeftButton, 0, webCombo.geometry().center());
     QObject* webpopup = firstChildByClassName(&view, "QComboBox");
     QComboBox* combo = qobject_cast<QComboBox*>(webpopup);
     QVERIFY(combo != 0);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list