[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
simon.fraser at apple.com
simon.fraser at apple.com
Wed Dec 22 12:43:55 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 4ca10bb853f0727488a4ce197b7929bdf29466d6
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Aug 27 22:50:18 2010 +0000
2010-08-27 Simon Fraser <simon.fraser at apple.com>
Reviewed by Tony Chang.
Insertion point does not show when dragging text into an editable area
https://bugs.webkit.org/show_bug.cgi?id=44295
r65681 caused the caret to use the last-computed caret rect when
painting, rather than forcing a style update. Because of this,
we now need to eagerly update the caret rect when changing
the drag selection.
Not testable in DRT because the drag selection is always cleared
before EventSender returns, so the drag caret can never show in
the pixel results.
Tested by running editing/selection/drag-in-iframe.html manually.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index cfa6013..84c9be8 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,24 @@
+2010-08-27 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Tony Chang.
+
+ Insertion point does not show when dragging text into an editable area
+ https://bugs.webkit.org/show_bug.cgi?id=44295
+
+ r65681 caused the caret to use the last-computed caret rect when
+ painting, rather than forcing a style update. Because of this,
+ we now need to eagerly update the caret rect when changing
+ the drag selection.
+
+ Not testable in DRT because the drag selection is always cleared
+ before EventSender returns, so the drag caret can never show in
+ the pixel results.
+
+ Tested by running editing/selection/drag-in-iframe.html manually.
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setSelection):
+
2010-08-27 Adam Barth <abarth at webkit.org>
Attempt to fix the Windows build.
diff --git a/WebCore/editing/SelectionController.cpp b/WebCore/editing/SelectionController.cpp
index 3672e3e..97dde55 100644
--- a/WebCore/editing/SelectionController.cpp
+++ b/WebCore/editing/SelectionController.cpp
@@ -118,6 +118,7 @@ void SelectionController::setSelection(const VisibleSelection& s, bool closeTypi
m_selection = s;
m_caretRectNeedsUpdate = true;
invalidateCaretRect();
+ updateCaretRect();
return;
}
if (!m_frame) {
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list