[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
commit-queue at webkit.org
commit-queue at webkit.org
Wed Dec 22 13:02:52 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 9caa1dbfcb935f12ec9987b9965580f41c411e79
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 6 09:56:56 2010 +0000
2010-09-06 Robin Qiu <robin.qiu at torchmobile.com.cn>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=43982
This js file seems to be a popular script for detecting mobile WebKit but
it has a flaw that makes it fail on Android and BlackBerry.
The issue is that it looks for "Mobile/" but Android and BlackBerry
use "Mobile" with no numbering after it.
Changed RegExp pattern " Mobile/" to " Mobile\\b".
* misc/WebKitDetect.js:
(WebKitDetect.isMobile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitSite/ChangeLog b/WebKitSite/ChangeLog
index 34c4c02..33a3d21 100644
--- a/WebKitSite/ChangeLog
+++ b/WebKitSite/ChangeLog
@@ -1,3 +1,18 @@
+2010-09-06 Robin Qiu <robin.qiu at torchmobile.com.cn>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=43982
+ This js file seems to be a popular script for detecting mobile WebKit but
+ it has a flaw that makes it fail on Android and BlackBerry.
+
+ The issue is that it looks for "Mobile/" but Android and BlackBerry
+ use "Mobile" with no numbering after it.
+ Changed RegExp pattern " Mobile/" to " Mobile\\b".
+
+ * misc/WebKitDetect.js:
+ (WebKitDetect.isMobile):
+
2010-08-27 Darin Adler <darin at apple.com>
* coding/RefPtr.html: Minor revision, improve clarity and mention some
diff --git a/WebKitSite/misc/WebKitDetect.js b/WebKitSite/misc/WebKitDetect.js
index 1c5c692..f038d68 100644
--- a/WebKitSite/misc/WebKitDetect.js
+++ b/WebKitSite/misc/WebKitDetect.js
@@ -101,7 +101,7 @@ WebKitDetect.versionIsAtLeast = function versionIsAtLeast(minimumString)
WebKitDetect.isMobile = function isMobile()
{
- return WebKitDetect.isWebKit() && RegExp(" Mobile/").test(navigator.userAgent);
+ return WebKitDetect.isWebKit() && RegExp(" Mobile\\b").test(navigator.userAgent);
}
WebKitDetect.mobileDevice = function mobileDevice()
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list