[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

loislo at chromium.org loislo at chromium.org
Wed Dec 22 13:03:08 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit a188d692c09fc06adfd64133254e2d47f5dee924
Author: loislo at chromium.org <loislo at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Sep 6 14:31:23 2010 +0000

    2010-09-06  Ilya Tikhonovsky  <loislo at chromium.org>
    
            Reviewed by Yury Semikhatsky.
    
            WebInspector: it'd be nice to be able to pass undefined argument as a callback to InspectorBackend functions.
    
            There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
            will be called with additional argument for callback but with undefined value.
    
            https://bugs.webkit.org/show_bug.cgi?id=45265
    
            * inspector/CodeGeneratorInspector.pm:
    
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 4f0c733..e4f1328 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-06  Ilya Tikhonovsky  <loislo at chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        WebInspector: it'd be possible to pass undefined argument as a callback to InspectorBackend functions.
+
+        There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
+        will ibe called with additional argument for callback but with undefined value.
+
+        https://bugs.webkit.org/show_bug.cgi?id=45265
+
+        * inspector/report-API-errors.html:
+
 2010-09-06  Zoltan Herczeg  <zherczeg at webkit.org>
 
         Reviewed by Dirk Schulze.
diff --git a/LayoutTests/inspector/report-API-errors.html b/LayoutTests/inspector/report-API-errors.html
index 55d5579..da11ee0 100644
--- a/LayoutTests/inspector/report-API-errors.html
+++ b/LayoutTests/inspector/report-API-errors.html
@@ -14,6 +14,7 @@ function test()
     InspectorBackend.enableResourceTracking(1);
     InspectorBackend.enableResourceTracking();
     InspectorBackend.enableResourceTracking(true, "not a function");
+    InspectorBackend.enableMonitoringXHR(undefined);
     WebInspector_syncDispatch('{"type": "event", "domain": "dom", "event": "something-strange", "data": {}}');
 
     InspectorTest.completeTest();
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 97e9fa3..7701f15 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-06  Ilya Tikhonovsky  <loislo at chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        WebInspector: it'd be nice to be able to pass undefined argument as a callback to InspectorBackend functions.
+
+        There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
+        will be called with additional argument for callback but with undefined value.
+
+        https://bugs.webkit.org/show_bug.cgi?id=45265
+
+        * inspector/CodeGeneratorInspector.pm:
+
 2010-09-06  Zoltan Herczeg  <zherczeg at webkit.org>
 
         Reviewed by Dirk Schulze.
diff --git a/WebCore/inspector/CodeGeneratorInspector.pm b/WebCore/inspector/CodeGeneratorInspector.pm
index d76fbd3..c7907b4 100644
--- a/WebCore/inspector/CodeGeneratorInspector.pm
+++ b/WebCore/inspector/CodeGeneratorInspector.pm
@@ -533,7 +533,7 @@ WebInspector.InspectorBackendStub.prototype = {
         }
 
         if (args.length === 1) {
-            if (typeof args[0] !== "function") {
+            if (typeof args[0] !== "function" && typeof args[0] !== "undefined") {
                 console.error("Protocol Error: Optional callback argument for 'InspectorBackend.%s' call should be a function but its type is '%s'.", request.command, typeof args[0]);
                 return;
             }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list