[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:05:53 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit ad2a069e4e3780b526b3d886171d2519af1052a4
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 6 23:39:28 2010 +0000
2010-09-06 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Add a quick animation for opening/closing comment boxes
https://bugs.webkit.org/show_bug.cgi?id=45278
The 200ms animation slides in and out the line-by-line comment box.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 52d689f..d0e5a4b 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -2,6 +2,17 @@
Reviewed by Eric Seidel.
+ [reviewtool] Add a quick animation for opening/closing comment boxes
+ https://bugs.webkit.org/show_bug.cgi?id=45278
+
+ The 200ms animation slides in and out the line-by-line comment box.
+
+ * code-review.js:
+
+2010-09-06 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
[reviewtool] Add a field for overall comments
https://bugs.webkit.org/show_bug.cgi?id=45273
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 98ff999..4e3a66f 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -73,7 +73,9 @@
var comment_block = $('<div class="comment"><textarea data-comment-for="' + line.attr('id') + '"></textarea><div class="actions"><button class="ok">Ok</button><button class="cancel">Cancel</button></div></div>');
insertCommentFor(line, comment_block);
- comment_block.children('textarea').focus();
+ comment_block.hide().slideDown('fast', function() {
+ $(this).children('textarea').focus();
+ });
}
function addCommentField() {
@@ -192,9 +194,11 @@
function cancelComment() {
var line_id = $(this).parentsUntil('.comment').parent().find('textarea').attr('data-comment-for');
var line = $('#' + line_id)
- findCommentBlockFor(line).remove();
- line.removeAttr('data-has-comment');
- trimCommentContextToBefore(line);
+ findCommentBlockFor(line).slideUp('fast', function() {
+ $(this).remove();
+ line.removeAttr('data-has-comment');
+ trimCommentContextToBefore(line);
+ });
}
function unfreezeComment() {
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list