[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 11:56:53 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 0de2efc4f3e90389cec2e5a083776f6f2d7c8be2
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Aug 12 00:31:12 2010 +0000

    2010-08-11  Leo Yang  <leo.yang at torchmobile.com.cn>
    
            Reviewed by Geoffrey Garen.
    
            Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
            which means isNaN(new Date("")) should return true.
            https://bugs.webkit.org/show_bug.cgi?id=43793
            Tests: fast/js/date-constructor.html
    
            * runtime/JSGlobalData.cpp:
            (JSC::JSGlobalData::resetDateCache):
    2010-08-11  Leo Yang  <leo.yang at torchmobile.com.cn>
    
            Reviewed by Geoffrey Garen.
    
            Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
            https://bugs.webkit.org/show_bug.cgi?id=43793
    
            * fast/js/date-constructor-expected.txt:
            * fast/js/script-tests/date-constructor.js:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index 8a7fe17..94b65f6 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-08-11  Leo Yang  <leo.yang at torchmobile.com.cn>
+
+        Reviewed by Geoffrey Garen.
+
+        Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
+        which means isNaN(new Date("")) should return true.
+        https://bugs.webkit.org/show_bug.cgi?id=43793
+        Tests: fast/js/date-constructor.html
+
+        * runtime/JSGlobalData.cpp:
+        (JSC::JSGlobalData::resetDateCache):
+
 2010-08-11  Gavin Barraclough  <barraclough at apple.com>
 
         Windows & !JIT build fix.
diff --git a/JavaScriptCore/runtime/JSGlobalData.cpp b/JavaScriptCore/runtime/JSGlobalData.cpp
index abb2db2..ca8605b 100644
--- a/JavaScriptCore/runtime/JSGlobalData.cpp
+++ b/JavaScriptCore/runtime/JSGlobalData.cpp
@@ -283,6 +283,7 @@ void JSGlobalData::resetDateCache()
     cachedUTCOffset = NaN;
     dstOffsetCache.reset();
     cachedDateString = UString();
+    cachedDateStringValue = NaN;
     dateInstanceCache.reset();
 }
 
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 3b2845e..e079b52 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,13 @@
+2010-08-11  Leo Yang  <leo.yang at torchmobile.com.cn>
+
+        Reviewed by Geoffrey Garen.
+
+        Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
+        https://bugs.webkit.org/show_bug.cgi?id=43793
+
+        * fast/js/date-constructor-expected.txt:
+        * fast/js/script-tests/date-constructor.js:
+
 2010-08-11  Kenneth Russell  <kbr at google.com>
 
         Reviewed by David Levin.
diff --git a/LayoutTests/fast/js/date-constructor-expected.txt b/LayoutTests/fast/js/date-constructor-expected.txt
index 7bdb8d5..233c999 100644
--- a/LayoutTests/fast/js/date-constructor-expected.txt
+++ b/LayoutTests/fast/js/date-constructor-expected.txt
@@ -3,6 +3,7 @@ This test case tests the Date constructor. In particular, it tests many cases of
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS isNaN(new Date("")) is true
 PASS new Date(1111).getTime() is 1111
 PASS new Date(object).getTime() is 1111
 PASS new Date(new Date(1111)).getTime() is 1111
diff --git a/LayoutTests/fast/js/script-tests/date-constructor.js b/LayoutTests/fast/js/script-tests/date-constructor.js
index 7b21463..ffe0b0a 100644
--- a/LayoutTests/fast/js/script-tests/date-constructor.js
+++ b/LayoutTests/fast/js/script-tests/date-constructor.js
@@ -8,6 +8,8 @@ var object = new Object;
 object.valueOf = function() { return 1111; }
 object.toSTring = function() { return "2222"; }
 
+shouldBe('isNaN(new Date(""))', 'true');
+
 var timeZoneOffset = Date.parse("Dec 25 1995") - Date.parse("Dec 25 1995 GMT");
 
 shouldBe('new Date(1111).getTime()', '1111');

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list