[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 12:26:18 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 210a856202f16fd76d7b2144c322da15903130fa
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Aug 23 19:18:01 2010 +0000

    2010-08-23  Sheriff Bot  <webkit.review.bot at gmail.com>
    
            Unreviewed, rolling out r65814.
            http://trac.webkit.org/changeset/65814
            https://bugs.webkit.org/show_bug.cgi?id=44443
    
            broke svg/custom/missing-xlink.svg (Requested by kling on
            #webkit).
    
            * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
            * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
            * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed.
    2010-08-23  Sheriff Bot  <webkit.review.bot at gmail.com>
    
            Unreviewed, rolling out r65814.
            http://trac.webkit.org/changeset/65814
            https://bugs.webkit.org/show_bug.cgi?id=44443
    
            broke svg/custom/missing-xlink.svg (Requested by kling on
            #webkit).
    
            * dom/Element.cpp:
            (WebCore::Element::setAttributeNS):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 42980ee..6e08695 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2010-08-23  Sheriff Bot  <webkit.review.bot at gmail.com>
+
+        Unreviewed, rolling out r65814.
+        http://trac.webkit.org/changeset/65814
+        https://bugs.webkit.org/show_bug.cgi?id=44443
+
+        broke svg/custom/missing-xlink.svg (Requested by kling on
+        #webkit).
+
+        * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
+        * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
+        * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed.
+
 2010-08-23  Andreas Kling  <andreas.kling at nokia.com>
 
         Reviewed by Tor Arne Vestbø.
diff --git a/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js b/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js
deleted file mode 100644
index c07f4c0..0000000
--- a/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js
+++ /dev/null
@@ -1,5 +0,0 @@
-description("Test that calling setAttributeNS() with a prefixed qualifiedName and null NS throws NAMESPACE_ERR.");
-
-shouldThrow("document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz')", "'Error: NAMESPACE_ERR: DOM Exception 14'");
-
-var successfullyParsed = true;
diff --git a/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt b/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt
deleted file mode 100644
index 7dc6dc5..0000000
--- a/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-Test that calling setAttributeNS() with a prefixed qualifiedName and null NS throws NAMESPACE_ERR.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz') threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace.html b/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace.html
deleted file mode 100644
index edc9fd3..0000000
--- a/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace.html
+++ /dev/null
@@ -1,13 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<link rel="stylesheet" href="../js/resources/js-test-style.css">
-<script src="../js/resources/js-test-pre.js"></script>
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script src="script-tests/setAttributeNS-prefix-and-null-namespace.js"></script>
-<script src="../js/resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 00dcece..18b0bc1 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-08-23  Sheriff Bot  <webkit.review.bot at gmail.com>
+
+        Unreviewed, rolling out r65814.
+        http://trac.webkit.org/changeset/65814
+        https://bugs.webkit.org/show_bug.cgi?id=44443
+
+        broke svg/custom/missing-xlink.svg (Requested by kling on
+        #webkit).
+
+        * dom/Element.cpp:
+        (WebCore::Element::setAttributeNS):
+
 2010-08-23  Jian Li  <jianli at chromium.org>
 
         Reviewed by David Levin.
diff --git a/WebCore/dom/Element.cpp b/WebCore/dom/Element.cpp
index 2d44f62..a469a42 100644
--- a/WebCore/dom/Element.cpp
+++ b/WebCore/dom/Element.cpp
@@ -1213,11 +1213,6 @@ void Element::setAttributeNS(const AtomicString& namespaceURI, const AtomicStrin
     if (!Document::parseQualifiedName(qualifiedName, prefix, localName, ec))
         return;
 
-    if (namespaceURI.isNull() && !prefix.isNull()) {
-        ec = NAMESPACE_ERR;
-        return;
-    }
-
     QualifiedName qName(prefix, localName, namespaceURI);
 
     if (scriptingPermission == FragmentScriptingNotAllowed && (isEventHandlerAttribute(qName) || isAttributeToRemove(qName, value)))

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list