[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
dpranke at chromium.org
dpranke at chromium.org
Wed Dec 22 13:10:12 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit a247455e4e5635def208aaf9842aa1a7ade99dc1
Author: dpranke at chromium.org <dpranke at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Sep 8 02:23:16 2010 +0000
2010-09-07 Dirk Pranke <dpranke at chromium.org>
Reviewed by Kent Tamura.
Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.
Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.
https://bugs.webkit.org/show_bug.cgi?id=45357
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index ae49dfc..d709fd1 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,21 @@
+2010-09-07 Dirk Pranke <dpranke at chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ Fix regression introduced in previous change to new-run-webkit-tests
+ (bug 45090) to not try to run unittests for the Mac implementation
+ of the Port interface if we aren't running on a Mac.
+
+ Also fix the overrides implementation mock in the chromium unittests
+ to fix the case where there are overrides checked in that cause
+ problems.
+
+ https://bugs.webkit.org/show_bug.cgi?id=45357
+
+ * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+ * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+ * Scripts/webkitpy/layout_tests/port/port_testcase.py:
+
2010-09-01 Dirk Pranke <dpranke at chromium.org>
Reviewed by Ojan Vafai.
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
index 939b15b..7a005b1 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
@@ -108,5 +108,10 @@ class ChromiumDriverTest(unittest.TestCase):
port.test_expectations = lambda: """BUG_TEST SKIP : fast/js/not-good.js = TEXT
DEFER LINUX WIN : fast/js/very-good.js = TIMEOUT PASS"""
+ port.test_expectations_overrides = lambda: ''
+
skipped_tests = port.skipped_layout_tests(extra_test_files=[fake_test, ])
self.assertTrue("fast/js/not-good.js" in skipped_tests)
+
+if __name__ == '__main__':
+ unittest.main()
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac_unittest.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
index b579703..16c87d3 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
@@ -27,6 +27,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import StringIO
+import sys
import unittest
import mac
@@ -35,6 +36,8 @@ import port_testcase
class MacTest(port_testcase.PortTestCase):
def make_port(self, options=port_testcase.MockOptions()):
+ if sys.platform != 'darwin':
+ return None
port_obj = mac.MacPort(options=options)
port_obj._options.results_directory = port_obj.results_directory()
port_obj._options.configuration = 'Release'
@@ -42,6 +45,8 @@ class MacTest(port_testcase.PortTestCase):
def test_skipped_file_paths(self):
port = self.make_port()
+ if not port:
+ return
skipped_paths = port._skipped_file_paths()
# FIXME: _skipped_file_paths should return WebKit-relative paths.
# So to make it unit testable, we strip the WebKit directory from the path.
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/port_testcase.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/port_testcase.py
index 7a97916..2d650f5 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/port_testcase.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/port_testcase.py
@@ -51,11 +51,21 @@ class PortTestCase(unittest.TestCase):
def test_http_server(self):
port = self.make_port()
+ if not port:
+ return
port.start_http_server()
port.stop_http_server()
def test_image_diff(self):
port = self.make_port()
+ if not port:
+ return
+
+ # FIXME: not sure why this shouldn't always be True
+ #self.assertTrue(port.check_image_diff())
+ if not port.check_image_diff():
+ return
+
dir = port.layout_tests_dir()
file1 = os.path.join(dir, 'fast', 'css', 'button_center.png')
file2 = os.path.join(dir, 'fast', 'css',
@@ -72,5 +82,7 @@ class PortTestCase(unittest.TestCase):
def test_websocket_server(self):
port = self.make_port()
+ if not port:
+ return
port.start_websocket_server()
port.stop_websocket_server()
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list