[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

andreas.kling at nokia.com andreas.kling at nokia.com
Wed Dec 22 13:11:28 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 96412f468b0ab092745bb49f3ff52e94f6120d20
Author: andreas.kling at nokia.com <andreas.kling at nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Sep 8 16:07:01 2010 +0000

    2010-09-08  Andreas Kling  <andreas.kling at nokia.com>
    
            Reviewed by Kenneth Rohde Christiansen.
    
            Canvas: Remove unnecessary null-check of canvas() in getImageData()
            https://bugs.webkit.org/show_bug.cgi?id=45394
    
            canvas() is already dereferenced earlier in the function so there is
            no use in checking it for null later.
    
            * html/canvas/CanvasRenderingContext2D.cpp:
            (WebCore::CanvasRenderingContext2D::getImageData):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3d00a35..b7c590a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-08  Andreas Kling  <andreas.kling at nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Canvas: Remove unnecessary null-check of canvas() in getImageData()
+        https://bugs.webkit.org/show_bug.cgi?id=45394
+
+        canvas() is already dereferenced earlier in the function so there is
+        no use in checking it for null later.
+
+        * html/canvas/CanvasRenderingContext2D.cpp:
+        (WebCore::CanvasRenderingContext2D::getImageData):
+
 2010-09-08  Philippe Normand  <pnormand at igalia.com>
 
         Reviewed by Eric Carlson.
diff --git a/WebCore/html/canvas/CanvasRenderingContext2D.cpp b/WebCore/html/canvas/CanvasRenderingContext2D.cpp
index 5100950..791ad04 100644
--- a/WebCore/html/canvas/CanvasRenderingContext2D.cpp
+++ b/WebCore/html/canvas/CanvasRenderingContext2D.cpp
@@ -1605,7 +1605,7 @@ PassRefPtr<ImageData> CanvasRenderingContext2D::getImageData(float sx, float sy,
         scaledRect.setWidth(1);
     if (scaledRect.height() < 1)
         scaledRect.setHeight(1);
-    ImageBuffer* buffer = canvas() ? canvas()->buffer() : 0;
+    ImageBuffer* buffer = canvas()->buffer();
     if (!buffer)
         return createEmptyImageData(scaledRect.size());
     return buffer->getUnmultipliedImageData(scaledRect);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list