[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
aestes at apple.com
aestes at apple.com
Wed Dec 22 13:11:38 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 7b96021bb0f1724b4f1e89083f3de07b59d863ef
Author: aestes at apple.com <aestes at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Sep 8 18:17:25 2010 +0000
Incorporate additional feedback from
https://bugs.webkit.org/show_bug.cgi?id=45364.
Rubber-stamped by Darin Adler.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Rename urlParam to
urlParameter.
* loader/SubframeLoader.h: Add argument names to the definition of
SubframeLoader::resourceWillUsePlugin().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index d6421ca..cb41387 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-08 Andy Estes <aestes at apple.com>
+
+ Rubber-stamped by Darin Adler.
+
+ Incorporate additional feedback from
+ https://bugs.webkit.org/show_bug.cgi?id=45364.
+
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parametersForPlugin): Rename urlParam to
+ urlParameter.
+ * loader/SubframeLoader.h: Add argument names to the definition of
+ SubframeLoader::resourceWillUsePlugin().
+
2010-09-07 Oliver Hunt <oliver at apple.com>
Reviewed by Anders Carlsson.
diff --git a/WebCore/html/HTMLObjectElement.cpp b/WebCore/html/HTMLObjectElement.cpp
index 51eb232..e9c6f60 100644
--- a/WebCore/html/HTMLObjectElement.cpp
+++ b/WebCore/html/HTMLObjectElement.cpp
@@ -163,7 +163,7 @@ static void mapDataParamToSrc(Vector<String>* paramNames, Vector<String>* paramV
void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames, Vector<String>& paramValues, String& url, String& serviceType)
{
HashSet<StringImpl*, CaseFoldingHash> uniqueParamNames;
- String urlParam;
+ String urlParameter;
// Scan the PARAM children and store their name/value pairs.
// Get the URL and type from the params if we don't already have them.
@@ -181,8 +181,8 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames, Vector<S
paramValues.append(p->value());
// FIXME: url adjustment does not belong in this function.
- if (url.isEmpty() && urlParam.isEmpty() && (equalIgnoringCase(name, "src") || equalIgnoringCase(name, "movie") || equalIgnoringCase(name, "code") || equalIgnoringCase(name, "url")))
- urlParam = deprecatedParseURL(p->value());
+ if (url.isEmpty() && urlParameter.isEmpty() && (equalIgnoringCase(name, "src") || equalIgnoringCase(name, "movie") || equalIgnoringCase(name, "code") || equalIgnoringCase(name, "url")))
+ urlParameter = deprecatedParseURL(p->value());
// FIXME: serviceType calculation does not belong in this function.
if (serviceType.isEmpty() && equalIgnoringCase(name, "type")) {
serviceType = p->value();
@@ -222,10 +222,10 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames, Vector<S
// attribute, not by a param element. However, for compatibility, allow the
// resource's URL to be given by a param named "src", "movie", "code" or "url"
// if we know that resource points to a plug-in.
- if (url.isEmpty() && !urlParam.isEmpty()) {
+ if (url.isEmpty() && !urlParameter.isEmpty()) {
SubframeLoader* loader = document()->frame()->loader()->subframeLoader();
- if (loader->resourceWillUsePlugin(urlParam, serviceType))
- url = urlParam;
+ if (loader->resourceWillUsePlugin(urlParameter, serviceType))
+ url = urlParameter;
}
}
diff --git a/WebCore/loader/SubframeLoader.h b/WebCore/loader/SubframeLoader.h
index a6626cb..a573045 100644
--- a/WebCore/loader/SubframeLoader.h
+++ b/WebCore/loader/SubframeLoader.h
@@ -76,7 +76,7 @@ public:
bool containsPlugins() const { return m_containsPlugins; }
- bool resourceWillUsePlugin(const String&, const String&);
+ bool resourceWillUsePlugin(const String& url, const String& mimeType);
private:
Frame* loadOrRedirectSubframe(HTMLFrameOwnerElement*, const KURL&, const AtomicString& frameName, bool lockHistory, bool lockBackForwardList);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list