[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

Wed Dec 22 13:15:39 UTC 2010

The following commit has been merged in the debian/experimental branch:
commit 16e15dd58c4e8f509d100d5cad93e36608ccd67d
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Sep 10 01:07:58 2010 +0000

    2010-09-09  Simon Fraser  <simon.fraser at apple.com>
    
            Reviewed by Darin Adler.
    
            https://bugs.webkit.org/show_bug.cgi?id=45509
            <rdar://problem/8142166> REGRESSION: WebView setDrawsBackground:NO no
            longer works without setBackgroundColor:clearColor
    
            r61215 caused RenderView to paint the viewport background when the
            document element's renderer is known to not fill opaquely paint
            the entire viewport, i.e. more often than it did before.
    
            This exposed a latent, long-standing bug which was introduced
            in r14638 (the RenderCanvas -> RenderView rename), where a call
            to view()->isTransparent() was not converted to frameView()->isTransparent(),
            yet happened to still compile because of RenderObject::isTransparent().
    
            This resulted in us painting the viewport background, even when
            WebView clients explicitly said that they wanted a transparent
            WebView.
    
            Fixed by calling frameView()->isTransparent(), as intended.
    
            * rendering/RenderView.cpp:
            (WebCore::RenderView::paintBoxDecorations):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ebf6164..7b3fb8a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,29 @@
+2010-09-09  Simon Fraser  <simon.fraser at apple.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=45509
+        <rdar://problem/8142166> REGRESSION: WebView setDrawsBackground:NO no
+        longer works without setBackgroundColor:clearColor
+        
+        r61215 caused RenderView to paint the viewport background when the
+        document element's renderer is known to not fill opaquely paint
+        the entire viewport, i.e. more often than it did before.
+        
+        This exposed a latent, long-standing bug which was introduced
+        in r14638 (the RenderCanvas -> RenderView rename), where a call
+        to view()->isTransparent() was not converted to frameView()->isTransparent(),
+        yet happened to still compile because of RenderObject::isTransparent().
+        
+        This resulted in us painting the viewport background, even when
+        WebView clients explicitly said that they wanted a transparent
+        WebView.
+        
+        Fixed by calling frameView()->isTransparent(), as intended.
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::paintBoxDecorations):
+
 2010-09-09  Chris Rogers  <crogers at google.com>
 
         Reviewed by Kenneth Russell.
diff --git a/WebCore/rendering/RenderView.cpp b/WebCore/rendering/RenderView.cpp
index 5130ac1..c92ea5f 100644
--- a/WebCore/rendering/RenderView.cpp
+++ b/WebCore/rendering/RenderView.cpp
@@ -221,7 +221,7 @@ void RenderView::paintBoxDecorations(PaintInfo& paintInfo, int, int)
     // or there is a transform on the <html>.
     // Only fill with the base background color (typically white) if we're the root document, 
     // since iframes/frames with no background in the child document should show the parent's background.
-    if (view()->isTransparent()) // FIXME: This needs to be dynamic.  We should be able to go back to blitting if we ever stop being transparent.
+    if (frameView()->isTransparent()) // FIXME: This needs to be dynamic.  We should be able to go back to blitting if we ever stop being transparent.
         frameView()->setUseSlowRepaints(); // The parent must show behind the child.
     else {
         Color baseColor = frameView()->baseBackgroundColor();

-- 
WebKit Debian packaging

