[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 13:22:09 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 9eebeae45b151e7619360e341fc5978959cb0532
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 13 06:43:31 2010 +0000
2010-09-12 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634
Add tests recommended by Hixie.
* fast/parser/form-pointer-1-expected.txt: Added.
* fast/parser/form-pointer-1.html: Added.
* fast/parser/form-pointer-2-expected.txt: Added.
* fast/parser/form-pointer-2.html: Added.
* fast/parser/form-pointer-3-expected.txt: Added.
* fast/parser/form-pointer-3.html: Added.
* fast/parser/form-pointer-4-expected.txt: Added.
* fast/parser/form-pointer-4.html: Added.
2010-09-12 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634
The spec changed to say what we do here so this FIXME isn't needed
anymore.
Tests: fast/parser/form-pointer-1.html
fast/parser/form-pointer-2.html
fast/parser/form-pointer-3.html
fast/parser/form-pointer-4.html
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 4339b0d..f917e1f 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,21 @@
+2010-09-12 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove FIXME now that the HTML5 spec has been updated
+ https://bugs.webkit.org/show_bug.cgi?id=45634
+
+ Add tests recommended by Hixie.
+
+ * fast/parser/form-pointer-1-expected.txt: Added.
+ * fast/parser/form-pointer-1.html: Added.
+ * fast/parser/form-pointer-2-expected.txt: Added.
+ * fast/parser/form-pointer-2.html: Added.
+ * fast/parser/form-pointer-3-expected.txt: Added.
+ * fast/parser/form-pointer-3.html: Added.
+ * fast/parser/form-pointer-4-expected.txt: Added.
+ * fast/parser/form-pointer-4.html: Added.
+
2010-09-12 Robin Qiu <robin.qiu at torchmobile.com.cn>
Reviewed by Antonio Gomes.
diff --git a/LayoutTests/fast/dom/beforeload/image-object-before-load-expected.txt b/LayoutTests/fast/parser/form-pointer-1-expected.txt
similarity index 100%
copy from LayoutTests/fast/dom/beforeload/image-object-before-load-expected.txt
copy to LayoutTests/fast/parser/form-pointer-1-expected.txt
diff --git a/LayoutTests/fast/parser/form-pointer-1.html b/LayoutTests/fast/parser/form-pointer-1.html
new file mode 100644
index 0000000..b475fc4
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-1.html
@@ -0,0 +1,10 @@
+<script>
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+<table>
+<form onsubmit="document.write('PASS'); return false">
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-2-expected.txt b/LayoutTests/fast/parser/form-pointer-2-expected.txt
new file mode 100644
index 0000000..660b40f
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-2-expected.txt
@@ -0,0 +1 @@
+ PASS
diff --git a/LayoutTests/fast/parser/form-pointer-2.html b/LayoutTests/fast/parser/form-pointer-2.html
new file mode 100644
index 0000000..d4965cc
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-2.html
@@ -0,0 +1,11 @@
+<script>
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+<table>
+<form onsubmit="document.write('PASS'); return false">
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-3-expected.txt b/LayoutTests/fast/parser/form-pointer-3-expected.txt
new file mode 100644
index 0000000..370cf91
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-3-expected.txt
@@ -0,0 +1,2 @@
+
+ PASS PASS
diff --git a/LayoutTests/fast/parser/form-pointer-3.html b/LayoutTests/fast/parser/form-pointer-3.html
new file mode 100644
index 0000000..8a487de
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-3.html
@@ -0,0 +1,14 @@
+<script>
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+<form onsubmit="document.writeln('PASS'); return false">
+<table>
+<form onsubmit="document.writeln('FAIL'); return false">
+<input type=submit>
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+document.getElementsByTagName('input')[1].click();
+</script>
diff --git a/LayoutTests/fast/parser/form-pointer-4-expected.txt b/LayoutTests/fast/parser/form-pointer-4-expected.txt
new file mode 100644
index 0000000..a6cc104
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-4-expected.txt
@@ -0,0 +1,2 @@
+
+ ALPHA BETA BETA
diff --git a/LayoutTests/fast/parser/form-pointer-4.html b/LayoutTests/fast/parser/form-pointer-4.html
new file mode 100644
index 0000000..dc92f4d
--- /dev/null
+++ b/LayoutTests/fast/parser/form-pointer-4.html
@@ -0,0 +1,17 @@
+<script>
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+<form onsubmit="document.writeln('ALPHA'); return false">
+<table>
+<input type=submit>
+</form>
+<form onsubmit="document.writeln('BETA'); return false">
+<input type=submit>
+</table>
+<input type=submit>
+<script>
+document.getElementsByTagName('input')[0].click();
+document.getElementsByTagName('input')[1].click();
+document.getElementsByTagName('input')[2].click();
+</script>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 39d65b3..1731c7e 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-09-12 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove FIXME now that the HTML5 spec has been updated
+ https://bugs.webkit.org/show_bug.cgi?id=45634
+
+ The spec changed to say what we do here so this FIXME isn't needed
+ anymore.
+
+ Tests: fast/parser/form-pointer-1.html
+ fast/parser/form-pointer-2.html
+ fast/parser/form-pointer-3.html
+ fast/parser/form-pointer-4.html
+
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::processStartTagForInTable):
+
2010-09-12 Robin Qiu <robin.qiu at torchmobile.com.cn>
Reviewed by Antonio Gomes.
diff --git a/WebCore/html/parser/HTMLTreeBuilder.cpp b/WebCore/html/parser/HTMLTreeBuilder.cpp
index 7cd9f34..1f1e58b 100644
--- a/WebCore/html/parser/HTMLTreeBuilder.cpp
+++ b/WebCore/html/parser/HTMLTreeBuilder.cpp
@@ -1132,8 +1132,6 @@ void HTMLTreeBuilder::processStartTagForInTable(AtomicHTMLToken& token)
parseError(token);
if (m_tree.form())
return;
- // FIXME: This deviates from the spec:
- // http://www.w3.org/Bugs/Public/show_bug.cgi?id=10216
m_tree.insertHTMLFormElement(token, true);
m_tree.openElements()->pop();
return;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list