[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
mrobinson at webkit.org
mrobinson at webkit.org
Wed Dec 22 13:22:44 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 412de4f25ea8c5bef2df5860198ee2d2ce12fcc9
Author: mrobinson at webkit.org <mrobinson at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 13 15:25:36 2010 +0000
2010-09-13 Martin Robinson <mrobinson at igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
* platform/qt/Skipped: Unskip tests that are now passing.
2010-09-13 Martin Robinson <mrobinson at igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 4880280..1eb8a1b 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
+2010-09-13 Martin Robinson <mrobinson at igalia.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] DOM listeners get wrong keycodes for some keys
+ https://bugs.webkit.org/show_bug.cgi?id=43365
+
+ * platform/qt/Skipped: Unskip tests that are now passing.
+
2010-09-13 Jonathan Dixon <joth at chromium.org>
Reviewed by Steve Block.
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
index d2d96c9..102ff7d 100644
--- a/LayoutTests/platform/qt/Skipped
+++ b/LayoutTests/platform/qt/Skipped
@@ -5420,11 +5420,6 @@ fast/events/spatial-navigation/snav-clipped-overflowed-content.html
# See http://code.google.com/p/chromium/issues/detail?id=19897
svg/custom/getscreenctm-in-mixed-content2.xhtml
-# [Qt] DOM listeners get wrong keycodes for some keys
-# https://bugs.webkit.org/show_bug.cgi?id=43365
-fast/events/keydown-numpad-keys.html
-fast/events/special-key-events-in-input-text.html
-
# Still working out flakiness issues with the perf tests.
# https://bugs.webkit.org/show_bug.cgi?id=44199
perf/
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1b16426..edaca82 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-13 Martin Robinson <mrobinson at igalia.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] DOM listeners get wrong keycodes for some keys
+ https://bugs.webkit.org/show_bug.cgi?id=43365
+
+ Produce the proper keycodes for the print screen key as well as the
+ keypad insert and delete keys.
+
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
+
2010-09-13 Jonathan Dixon <joth at chromium.org>
Reviewed by Steve Block.
diff --git a/WebCore/platform/qt/PlatformKeyboardEventQt.cpp b/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
index 6dde9c4..d0edb16 100644
--- a/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
+++ b/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
@@ -188,6 +188,10 @@ int windowsKeyCodeForKeyEvent(unsigned int keycode, bool isKeypad)
return VK_RIGHT; // (27) RIGHT ARROW key
case Qt::Key_Down:
return VK_DOWN; // (28) DOWN ARROW key
+ case Qt::Key_Insert:
+ return VK_INSERT; // (2D) INS key
+ case Qt::Key_Delete:
+ return VK_DELETE; // (2E) DEL key
default:
return 0;
}
@@ -304,12 +308,9 @@ int windowsKeyCodeForKeyEvent(unsigned int keycode, bool isKeypad)
case Qt::Key_Select:
return VK_SELECT; // (29) SELECT key
case Qt::Key_Print:
- return VK_PRINT; // (2A) PRINT key
+ return VK_SNAPSHOT; // (2A) PRINT key
case Qt::Key_Execute:
return VK_EXECUTE; // (2B) EXECUTE key
- // dunno on this
- // case Qt::Key_PrintScreen:
- // return VK_SNAPSHOT; // (2C) PRINT SCREEN key
case Qt::Key_Insert:
return VK_INSERT; // (2D) INS key
case Qt::Key_Delete:
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list