[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 13:28:44 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit ec6d7f607bfc54ff1bc11ee218b8b72440da181c
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Sep 16 19:05:30 2010 +0000

    2010-09-16  Daniel Cheng  <dcheng at chromium.org>
    
            Reviewed by Simon Fraser.
    
            [chromium] Fix incorrect drag node/selection painting.
            https://bugs.webkit.org/show_bug.cgi?id=45573
    
            Drag selections were being incorrectly clipped when dragging a selection
            near the bottom of a page that was taller than the viewport. To fix
            this, we use paintContents() instead of paint().
    
            * page/chromium/FrameChromium.cpp:
            (WebCore::Frame::nodeImage):
            (WebCore::Frame::dragImageForSelection):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index d20fba0..b45c3f4 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,20 @@
 2010-09-16  Daniel Cheng  <dcheng at chromium.org>
 
+        Reviewed by Simon Fraser.
+
+        [chromium] Fix incorrect drag node/selection painting.
+        https://bugs.webkit.org/show_bug.cgi?id=45573
+
+        Drag selections were being incorrectly clipped when dragging a selection
+        near the bottom of a page that was taller than the viewport. To fix
+        this, we use paintContents() instead of paint().
+
+        * page/chromium/FrameChromium.cpp:
+        (WebCore::Frame::nodeImage):
+        (WebCore::Frame::dragImageForSelection):
+
+2010-09-16  Daniel Cheng  <dcheng at chromium.org>
+
         Reviewed by Tony Chang.
 
         Fix incorrect usage of dissolveDragImageToFraction().
diff --git a/WebCore/page/chromium/FrameChromium.cpp b/WebCore/page/chromium/FrameChromium.cpp
index b9097d0..15ff8b4 100644
--- a/WebCore/page/chromium/FrameChromium.cpp
+++ b/WebCore/page/chromium/FrameChromium.cpp
@@ -86,7 +86,7 @@ DragImageRef Frame::nodeImage(Node* node)
     buffer->context()->translate(-paintingRect.x(), -paintingRect.y());
     buffer->context()->clip(FloatRect(0, 0, paintingRect.right(), paintingRect.bottom()));
 
-    m_view->paint(buffer->context(), paintingRect);
+    m_view->paintContents(buffer->context(), paintingRect);
 
     RefPtr<Image> image = buffer->copyImage();
     return createDragImageFromImage(image.get());
@@ -109,7 +109,7 @@ DragImageRef Frame::dragImageForSelection()
     buffer->context()->translate(-paintingRect.x(), -paintingRect.y());
     buffer->context()->clip(FloatRect(0, 0, paintingRect.right(), paintingRect.bottom()));
 
-    m_view->paint(buffer->context(), paintingRect);
+    m_view->paintContents(buffer->context(), paintingRect);
 
     RefPtr<Image> image = buffer->copyImage();
     return createDragImageFromImage(image.get());

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list