[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

tonikitoo at webkit.org tonikitoo at webkit.org
Wed Dec 22 13:29:42 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit eaee25f29c8f5bcf63b56a90e80852613f64c4ba
Author: tonikitoo at webkit.org <tonikitoo at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Sep 17 01:32:42 2010 +0000

    2010-09-12  Antonio Gomes  <tonikitoo at webkit.org>
    
            Reviewed by Andreas Kling.
    
            Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
    
            We usually separate methods whose body are larger the a few lines from the class definition.
    
            * QtTestBrowser/webview.h:
            (WebViewGraphicsBased::yRotation):
            (WebViewGraphicsBased::setYRotation):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 5f5c412..9c52aa4 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -2,6 +2,18 @@
 
         Reviewed by Andreas Kling.
 
+        Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
+
+        We usually separate methods whose body are larger than a few lines from the class definition.
+
+        * QtTestBrowser/webview.h:
+        (WebViewGraphicsBased::yRotation):
+        (WebViewGraphicsBased::setYRotation):
+
+2010-09-12  Antonio Gomes  <tonikitoo at webkit.org>
+
+        Reviewed by Andreas Kling.
+
         Make initializeView method of LauncherWindow private.
 
         No one else needs to be able to call it but LauncherWindow.
diff --git a/WebKitTools/QtTestBrowser/webview.h b/WebKitTools/QtTestBrowser/webview.h
index d0e1e57..af67d19 100644
--- a/WebKitTools/QtTestBrowser/webview.h
+++ b/WebKitTools/QtTestBrowser/webview.h
@@ -87,21 +87,8 @@ public:
     void setResizesToContents(bool b);
     bool resizesToContents() const { return m_resizesToContents; }
 
-    void setYRotation(qreal angle)
-    {
-#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
-        QRectF r = m_item->boundingRect();
-        m_item->setTransform(QTransform()
-            .translate(r.width() / 2, r.height() / 2)
-            .rotate(angle, Qt::YAxis)
-            .translate(-r.width() / 2, -r.height() / 2));
-#endif
-        m_yRotation = angle;
-    }
-    qreal yRotation() const
-    {
-        return m_yRotation;
-    }
+    void setYRotation(qreal angle);
+    qreal yRotation() const { return m_yRotation; }
 
     GraphicsWebView* graphicsWebView() const { return m_item; }
 
@@ -128,4 +115,16 @@ private:
     FpsTimer m_fpsTimer;
 };
 
+inline void WebViewGraphicsBased::setYRotation(qreal angle)
+{
+#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
+    QRectF r = graphicsWebView()->boundingRect();
+    graphicsWebView()->setTransform(QTransform()
+        .translate(r.width() / 2, r.height() / 2)
+        .rotate(angle, Qt::YAxis)
+        .translate(-r.width() / 2, -r.height() / 2));
+#endif
+    m_yRotation = angle;
+}
+
 #endif

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list