[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

tkent at chromium.org tkent at chromium.org
Wed Dec 22 13:32:28 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 62a87646098e1c3d747b902d9095029660b49ff9
Author: tkent at chromium.org <tkent at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Sep 19 13:31:36 2010 +0000

    2010-09-19  Kent Tamura  <tkent at chromium.org>
    
            Reviewed by Dimitri Glazkov.
    
            [Chromium] Add is<input type>() functions to WebInputElement
            https://bugs.webkit.org/show_bug.cgi?id=46035
    
            * html/HTMLInputElement.h:
            (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
    2010-09-19  Kent Tamura  <tkent at chromium.org>
    
            Reviewed by Dimitri Glazkov.
    
            [Chromium] Add is<input type>() functions to WebInputElement
            https://bugs.webkit.org/show_bug.cgi?id=46035
    
            We're going to stop exposing HTMLInputElemnt::InputType. So, add
            isFoo() functions in order to remove WebInputElement::InputType.
    
            * public/WebInputElement.h:
            * src/WebInputElement.cpp:
            (WebKit::WebInputElement::isTextField):
            (WebKit::WebInputElement::isText):
            (WebKit::WebInputElement::isPasswordField):
            (WebKit::WebInputElement::isImageButton):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index aac82fb..75f52bf 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-19  Kent Tamura  <tkent at chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add is<input type>() functions to WebInputElement
+        https://bugs.webkit.org/show_bug.cgi?id=46035
+
+        * html/HTMLInputElement.h:
+        (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
+
 2010-09-18  Andreas Kling  <andreas.kling at nokia.com>
 
         Reviewed by Antonio Gomes.
diff --git a/WebCore/html/HTMLInputElement.h b/WebCore/html/HTMLInputElement.h
index a29ed02..245bedc 100644
--- a/WebCore/html/HTMLInputElement.h
+++ b/WebCore/html/HTMLInputElement.h
@@ -110,6 +110,7 @@ public:
     virtual bool isPasswordField() const { return m_type == PASSWORD; }
     virtual bool isCheckbox() const { return m_type == CHECKBOX; }
 
+    bool isText() const { return m_type == TEXT; }
     bool isEmailField() const { return m_type == EMAIL; }
     bool isFileUpload() const { return m_type == FILE; }
     bool isImageButton() const { return m_type == IMAGE; }
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index e2aaac8..147c60f 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,20 @@
+2010-09-19  Kent Tamura  <tkent at chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add is<input type>() functions to WebInputElement
+        https://bugs.webkit.org/show_bug.cgi?id=46035
+
+        We're going to stop exposing HTMLInputElemnt::InputType. So, add
+        isFoo() functions in order to remove WebInputElement::InputType.
+
+        * public/WebInputElement.h:
+        * src/WebInputElement.cpp:
+        (WebKit::WebInputElement::isTextField):
+        (WebKit::WebInputElement::isText):
+        (WebKit::WebInputElement::isPasswordField):
+        (WebKit::WebInputElement::isImageButton):
+
 2010-09-17  Darin Adler  <darin at apple.com>
 
         Reviewed by Sam Weinig.
diff --git a/WebKit/chromium/public/WebInputElement.h b/WebKit/chromium/public/WebInputElement.h
index ef3b577..3ef92de 100644
--- a/WebKit/chromium/public/WebInputElement.h
+++ b/WebKit/chromium/public/WebInputElement.h
@@ -79,9 +79,17 @@ namespace WebKit {
             Week
         };
 
+        // This returns true for all of textfield-looking types such as text,
+        // password, search, email, url, and number.
+        WEBKIT_API bool isTextField() const;
+        // This returns true only for type=text.
+        WEBKIT_API bool isText() const;
+        WEBKIT_API bool isPasswordField() const;
+        WEBKIT_API bool isImageButton() const;
         WEBKIT_API bool autoComplete() const;
         WEBKIT_API bool isReadOnly() const;
         WEBKIT_API bool isEnabledFormControl() const;
+        // Deperated.
         WEBKIT_API InputType inputType() const;
         WEBKIT_API int maxLength() const;
         WEBKIT_API bool isActivatedSubmit() const;
diff --git a/WebKit/chromium/src/WebInputElement.cpp b/WebKit/chromium/src/WebInputElement.cpp
index 7bf6407..25af3b0 100644
--- a/WebKit/chromium/src/WebInputElement.cpp
+++ b/WebKit/chromium/src/WebInputElement.cpp
@@ -40,6 +40,26 @@ using namespace WebCore;
 
 namespace WebKit {
 
+bool WebInputElement::isTextField() const
+{
+    return constUnwrap<HTMLInputElement>()->isTextField();
+}
+
+bool WebInputElement::isText() const
+{
+    return constUnwrap<HTMLInputElement>()->isText();
+}
+
+bool WebInputElement::isPasswordField() const
+{
+    return constUnwrap<HTMLInputElement>()->isPasswordField();
+}
+
+bool WebInputElement::isImageButton() const
+{
+    return constUnwrap<HTMLInputElement>()->isImageButton();
+}
+
 bool WebInputElement::autoComplete() const
 {
     return constUnwrap<HTMLInputElement>()->autoComplete();

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list