[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
darin at apple.com
darin at apple.com
Wed Dec 22 13:36:09 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 2ca3f55f05654506e5a641ca66139de3fb96b3cf
Author: darin at apple.com <darin at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Sep 21 06:44:52 2010 +0000
2010-09-20 Darin Adler <darin at apple.com>
Reviewed by Adam Barth.
Add Preview button and link to bug to patch review bar
https://bugs.webkit.org/show_bug.cgi?id=46153
* PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
* code-review.js: Added Preview button and link to bug.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index fdabb05..74a58ea 100644
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-20 Darin Adler <darin at apple.com>
+
+ Reviewed by Adam Barth.
+
+ Add Preview button and link to bug to patch review bar
+ https://bugs.webkit.org/show_bug.cgi?id=46153
+
+ * PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
+ * code-review.js: Added Preview button and link to bug.
+
2010-09-19 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
diff --git a/BugsSite/PrettyPatch/PrettyPatch.rb b/BugsSite/PrettyPatch/PrettyPatch.rb
index 06d9780..5f534db 100644
--- a/BugsSite/PrettyPatch/PrettyPatch.rb
+++ b/BugsSite/PrettyPatch/PrettyPatch.rb
@@ -306,7 +306,7 @@ body {
}
</style>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
-<script src="code-review.js?version=9"></script>
+<script src="code-review.js?version=10"></script>
EOF
def self.revisionOrDescription(string)
diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 3d63e59..f550de7 100644
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -254,7 +254,7 @@
$(document).ready(function() {
crawlDiff();
fetchHistory();
- $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="post_comments">Publish</button></div><div class="message"><span class="commentStatus"></span> <span class="help">Double-click a line to add a comment.</span></div></div>');
+ $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="preview_comments">Preview</button><button id="post_comments">Publish</button></div><div class="message"> <span class="commentStatus"></span> <span class="help">Double-click a line or click or drag on line numbers to add a comment.</span></div></div>');
$(document.body).prepend('<div id="comment_form" class="inactive"><div class="winter"></div><div class="lightbox"><iframe id="reviewform" src="attachment.cgi?id=' + attachment_id + '&action=reviewform"></iframe></div></div>');
$(document.body).append('<div class="overallComments"><div class="description">Overall comments:</div><textarea></textarea></div>');
});
@@ -434,7 +434,7 @@
$('#comment_form').addClass('inactive');
});
- $('#post_comments').live('click', function() {
+ function fillInReviewForm() {
var comments_in_context = []
forEachLine(function(line) {
if (line.attr('data-has-comment') != 'true')
@@ -466,6 +466,15 @@
return;
$(this).attr('selectedIndex', control.attr('selectedIndex'));
});
+ }
+
+ $('#preview_comments').live('click', function() {
+ fillInReviewForm();
+ $('#comment_form').removeClass('inactive');
+ });
+
+ $('#post_comments').live('click', function() {
+ fillInReviewForm();
review_form.find('form').submit();
});
})();
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list