[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

kbalazs at webkit.org kbalazs at webkit.org
Wed Dec 22 13:38:47 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 424b2485cb9e4ccac8f3842be1d086bb74d93378
Author: kbalazs at webkit.org <kbalazs at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Sep 22 08:55:17 2010 +0000

    2010-09-22  Balazs Kelemen  <kb at inf.u-szeged.hu>
    
            Reviewed by Darin Adler.
    
            check-webkit-style and the coding style guidelines page are inconsistent
            https://bugs.webkit.org/show_bug.cgi?id=46099
    
            * coding/coding-style.html:
            Making clear that includes of system headers must come after includes of other headers.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitSite/ChangeLog b/WebKitSite/ChangeLog
index 629d2a4..b499018 100644
--- a/WebKitSite/ChangeLog
+++ b/WebKitSite/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-22  Balazs Kelemen  <kb at inf.u-szeged.hu>
+
+        Reviewed by Darin Adler.
+
+        check-webkit-style and the coding style guidelines page are inconsistent
+        https://bugs.webkit.org/show_bug.cgi?id=46099
+
+        * coding/coding-style.html:
+        Making clear that includes of system headers must come after includes of other headers.
+
 2010-09-16  Tony Gentilcore  <tonyg at chromium.org>
 
         Reviewed by Adam Barth.
diff --git a/WebKitSite/coding/coding-style.html b/WebKitSite/coding/coding-style.html
index 10527f2..86d5158 100644
--- a/WebKitSite/coding/coding-style.html
+++ b/WebKitSite/coding/coding-style.html
@@ -755,6 +755,33 @@ Don't bother to organize them in a logical order.
 #include "QualifiedName.h"
 #include "Attribute.h"
 </pre>
+
+<li>Includes of system headers must come after includes of other headers.
+
+<h4 class="right">Right:</h4>
+<pre class="code">
+// ConnectionQt.cpp
+#include "ArgumentEncoder.h"
+#include "ProcessLauncher.h"
+#include "WebPageProxyMessageKinds.h"
+#include "WorkItem.h"
+#include &ltQApplication&gt
+#include &ltQLocalServer&gt
+#include &ltQLocalSocket&gt
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+// ConnectionQt.cpp
+#include "ArgumentEncoder.h"
+#include "ProcessLauncher.h"
+#include &ltQApplication&gt
+#include &ltQLocalServer&gt
+#include &ltQLocalSocket&gt
+#include "WebPageProxyMessageKinds.h"
+#include "WorkItem.h"
+</pre>
+</li>
 </ol>
 
 <h3>"using" Statements</h3>

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list