[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
commit-queue at webkit.org
commit-queue at webkit.org
Wed Dec 22 13:40:34 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 11d9d820dfb485926bd160ee1f0511161858594e
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Sep 23 01:48:10 2010 +0000
2010-09-22 Mario Sanchez Prada <msanchez at igalia.com>
Reviewed by Martin Robinson.
[GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c
https://bugs.webkit.org/show_bug.cgi?id=46284
Use g_idle_add() whenever g_timeout_add() was being used.
This is desired because it's better to rely on the main loop to
decide when it's a good moment to execute the task (when idle)
than manually setting a timeout, which also sets a minimum amount
of time needed to get the function executed.
* tests/testatk.c:
(testWekitAtkTextSelections):
(testWebkitAtkGetExtents):
(testWebkitAtkListsOfItems):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 9b66c80..1ce8228 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -2,6 +2,26 @@
Reviewed by Martin Robinson.
+ [GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c
+ https://bugs.webkit.org/show_bug.cgi?id=46284
+
+ Use g_idle_add() whenever g_timeout_add() was being used.
+
+ This is desired because it's better to rely on the main loop to
+ decide when it's a good moment to execute the task (when idle)
+ than manually setting a timeout, which also sets a minimum amount
+ of time needed to get the function executed.
+
+ * tests/testatk.c:
+ (testWekitAtkTextSelections):
+ (testWebkitAtkGetExtents):
+ (testWebkitAtkListsOfItems):
+ (main):
+
+2010-09-22 Mario Sanchez Prada <msanchez at igalia.com>
+
+ Reviewed by Martin Robinson.
+
[Gtk] object:text-changed events should be emitted for entries and password text
https://bugs.webkit.org/show_bug.cgi?id=25898
diff --git a/WebKit/gtk/tests/testatk.c b/WebKit/gtk/tests/testatk.c
index 9e72334..19a525a 100644
--- a/WebKit/gtk/tests/testatk.c
+++ b/WebKit/gtk/tests/testatk.c
@@ -763,7 +763,7 @@ static void testWekitAtkTextSelections(void)
webkit_web_view_load_string(webView, textForSelections, NULL, NULL, NULL);
loop = g_main_loop_new(NULL, TRUE);
- g_timeout_add(100, (GSourceFunc)bail_out, loop);
+ g_idle_add((GSourceFunc)bail_out, loop);
g_main_loop_run(loop);
obj = gtk_widget_get_accessible(GTK_WIDGET(webView));
@@ -861,7 +861,7 @@ static void testWekitAtkTextSelections(void)
g_object_unref(webView);
}
-static void test_webkit_atk_get_extents(void)
+static void testWebkitAtkGetExtents(void)
{
WebKitWebView* webView;
AtkObject* obj;
@@ -874,7 +874,7 @@ static void test_webkit_atk_get_extents(void)
webkit_web_view_load_string(webView, centeredContents, NULL, NULL, NULL);
loop = g_main_loop_new(NULL, TRUE);
- g_timeout_add(100, (GSourceFunc)bail_out, loop);
+ g_idle_add((GSourceFunc)bail_out, loop);
g_main_loop_run(loop);
obj = gtk_widget_get_accessible(GTK_WIDGET(webView));
@@ -982,7 +982,7 @@ static void testWebkitAtkListsOfItems(void)
webkit_web_view_load_string(webView, listsOfItems, NULL, NULL, NULL);
loop = g_main_loop_new(NULL, TRUE);
- g_timeout_add(100, (GSourceFunc)bail_out, loop);
+ g_idle_add((GSourceFunc)bail_out, loop);
g_main_loop_run(loop);
obj = gtk_widget_get_accessible(GTK_WIDGET(webView));
@@ -1118,7 +1118,7 @@ int main(int argc, char** argv)
g_test_add_func("/webkit/atk/getHeadersInTable", testWebkitAtkGetHeadersInTable);
g_test_add_func("/webkit/atk/textAttributes", testWebkitAtkTextAttributes);
g_test_add_func("/webkit/atk/textSelections", testWekitAtkTextSelections);
- g_test_add_func("/webkit/atk/get_extents", test_webkit_atk_get_extents);
+ g_test_add_func("/webkit/atk/getExtents", testWebkitAtkGetExtents);
g_test_add_func("/webkit/atk/listsOfItems", testWebkitAtkListsOfItems);
g_test_add_func("/webkit/atk/textChangedNotifications", testWebkitAtkTextChangedNotifications);
return g_test_run ();
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list