[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
commit-queue at webkit.org
commit-queue at webkit.org
Wed Dec 22 13:45:02 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 72532fd016350087eb36dae73411608ff6bb42d6
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Sep 24 22:04:19 2010 +0000
2010-09-24 Kenichi Ishibashi <bashi at google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests prints out nothing when build-dumprendertree fails
https://bugs.webkit.org/show_bug.cgi?id=37563
Print error message when build-dumprendertree fails.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 79ed1e9..744a6b9 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,15 @@
+2010-09-24 Kenichi Ishibashi <bashi at google.com>
+
+ Reviewed by Eric Seidel.
+
+ new-run-webkit-tests prints out nothing when build-dumprendertree fails
+ https://bugs.webkit.org/show_bug.cgi?id=37563
+
+ Print error message when build-dumprendertree fails.
+
+ * Scripts/webkitpy/layout_tests/port/webkit.py:
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
2010-09-24 Mihai Parparita <mihaip at chromium.org>
Reviewed by Tony Chang.
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
index 7ec815a..456ea91 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
@@ -84,10 +84,14 @@ class WebKitPort(base.Port):
return ''
def _build_driver(self):
- return not self._executive.run_command([
+ exit_code = self._executive.run_command([
self.script_path("build-dumprendertree"),
self.flag_from_configuration(self._options.configuration),
], return_exit_code=True)
+ if exit_code != 0:
+ _log.error("Failed to build DumpRenderTree")
+ return False
+ return True
def _check_driver(self):
driver_path = self._path_to_driver()
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 9a0d24c..e9c6d2c 100755
--- a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -1401,6 +1401,7 @@ def run(port, options, args, regular_output=sys.stderr,
printer.print_update("Checking build ...")
if not port.check_build(test_runner.needs_http()):
+ _log.error("Build check failed")
return -1
result_summary = test_runner.set_up_run()
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list