[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
tonikitoo at webkit.org
tonikitoo at webkit.org
Wed Dec 22 13:46:28 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 13f65df062017463113416a23b9f107d79ef17c0
Author: tonikitoo at webkit.org <tonikitoo at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun Sep 26 19:00:45 2010 +0000
document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492
Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes at rim.com>
WebCore:
As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.
Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.
* dom/Document.idl:
LayoutTests:
Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.
* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index ac31b10..5faad7c 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,20 @@
+2010-09-25 Antonio Gomes <agomes at rim.com>
+
+ Reviewed by Kenneth Christiansen and Andreas Kling.
+
+ document.nodesFromRect() needs to be removed from Document.idl
+ https://bugs.webkit.org/show_bug.cgi?id=46492
+
+ Skip the tests relying on document.nodesFromRect in all platform for
+ the moment, and adjusting the expected results tests also accordingly.
+
+ * fast/dom/Window/window-properties-expected.txt:
+ * platform/gtk/Skipped:
+ * platform/mac/Skipped:
+ * platform/qt/Skipped:
+ * platform/qt/fast/dom/Window/window-properties-expected.txt:
+ * platform/win/Skipped:
+
2010-09-26 Renata Hodovan <reni at inf.u-szeged.hu>
Reviewed by Dirk Schulze.
diff --git a/LayoutTests/fast/dom/Window/window-properties-expected.txt b/LayoutTests/fast/dom/Window/window-properties-expected.txt
index d484cfe..8d03e81 100644
--- a/LayoutTests/fast/dom/Window/window-properties-expected.txt
+++ b/LayoutTests/fast/dom/Window/window-properties-expected.txt
@@ -626,7 +626,6 @@ window.Document.prototype.isSameNode [function]
window.Document.prototype.isSupported [function]
window.Document.prototype.lookupNamespaceURI [function]
window.Document.prototype.lookupPrefix [function]
-window.Document.prototype.nodesFromRect [function]
window.Document.prototype.normalize [function]
window.Document.prototype.queryCommandEnabled [function]
window.Document.prototype.queryCommandIndeterm [function]
diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
index 9a891d7..16f65a3 100644
--- a/LayoutTests/platform/gtk/Skipped
+++ b/LayoutTests/platform/gtk/Skipped
@@ -5928,3 +5928,6 @@ media/video-controls-with-mutation-event-handler.html
# FileSystem API is not supported.
fast/filesystem
+
+# LayoutTestController::nodesFromRect is not supported.
+fast/dom/nodesFromRect-basic.html
diff --git a/LayoutTests/platform/mac/Skipped b/LayoutTests/platform/mac/Skipped
index 420790c..85ece4c 100644
--- a/LayoutTests/platform/mac/Skipped
+++ b/LayoutTests/platform/mac/Skipped
@@ -317,3 +317,6 @@ media/context-menu-actions.html
# FileSystem API is not supported.
fast/filesystem
+
+# LayoutTestController::nodesFromRect is not supported.
+fast/dom/nodesFromRect-basic.html
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
index 7aa7960..24e6017 100644
--- a/LayoutTests/platform/qt/Skipped
+++ b/LayoutTests/platform/qt/Skipped
@@ -5477,3 +5477,6 @@ fast/parser/pre-html5-parser-quirks.html
# FileSystem API is not supported.
fast/filesystem
+
+# LayoutTestController::nodesFromRect is not supported.
+fast/dom/nodesFromRect-basic.html
diff --git a/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt b/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
index ba0f202..ef92d97 100644
--- a/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
+++ b/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
@@ -624,7 +624,6 @@ window.Document.prototype.isSameNode [function]
window.Document.prototype.isSupported [function]
window.Document.prototype.lookupNamespaceURI [function]
window.Document.prototype.lookupPrefix [function]
-window.Document.prototype.nodesFromRect [function]
window.Document.prototype.normalize [function]
window.Document.prototype.queryCommandEnabled [function]
window.Document.prototype.queryCommandIndeterm [function]
diff --git a/LayoutTests/platform/win/Skipped b/LayoutTests/platform/win/Skipped
index 738a406..adfd96c 100644
--- a/LayoutTests/platform/win/Skipped
+++ b/LayoutTests/platform/win/Skipped
@@ -1003,3 +1003,6 @@ fast/parser/pre-html5-parser-quirks.html
# FileSystem API is not supported.
fast/filesystem
+
+# LayoutTestController::nodesFromRect is not supported.
+fast/dom/nodesFromRect-basic.html
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index d8b19dc..f57f854 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2010-09-25 Antonio Gomes <agomes at rim.com>
+
+ Reviewed by Kenneth Christiansen and Andreas Kling.
+
+ document.nodesFromRect() needs to be removed from Document.idl
+ https://bugs.webkit.org/show_bug.cgi?id=46492
+
+ As discussed with Sam Weinig on IRC, it was decided to removed
+ nodesFromRect() from the Document.idl, and that way, not exposing
+ it to Web content.
+
+ Reason: there is no plan to make it standard at the moment, and at the
+ very least, the method should had been originally added with the "webkit"
+ prefix, which was not the case.
+
+ * dom/Document.idl:
+
2010-09-26 Renata Hodovan <reni at inf.u-szeged.hu>
Reviewed by Dirk Schulze.
diff --git a/WebCore/dom/Document.idl b/WebCore/dom/Document.idl
index 296bd44..e551f88 100644
--- a/WebCore/dom/Document.idl
+++ b/WebCore/dom/Document.idl
@@ -186,11 +186,6 @@ module core {
readonly attribute [ConvertNullStringTo=Undefined] DOMString defaultCharset;
readonly attribute [ConvertNullStringTo=Undefined] DOMString readyState;
-
- NodeList nodesFromRect(in long x, in long y,
- in unsigned long hPadding,
- in unsigned long vPadding,
- in boolean ignoreClipping);
Element elementFromPoint(in long x, in long y);
Range caretRangeFromPoint(in long x, in long y);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list