[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

weinig at apple.com weinig at apple.com
Wed Dec 22 13:47:48 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit b3481c7705b93a63d722123a322f9968fb4d5f9d
Author: weinig at apple.com <weinig at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Sep 27 15:19:37 2010 +0000

    Opening links in a new window asserts while decoding decidePolicyForNewWindowAction.
    <rdar://problem/8479445>
    https://bugs.webkit.org/show_bug.cgi?id=46623
    
    Reviewed by Adam Roben.
    
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::didReceiveMessage): Fix the order of decoding to
    match the order of encoding. (Swapping url and mouseButton).
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 4922654..5b5a07f 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,15 @@
+2010-09-27  Sam Weinig  <sam at webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Opening links in a new window asserts while decoding decidePolicyForNewWindowAction.
+        <rdar://problem/8479445>
+        https://bugs.webkit.org/show_bug.cgi?id=46623
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didReceiveMessage): Fix the order of decoding to
+        match the order of encoding. (Swapping url and mouseButton).
+
 2010-09-27  Adam Roben  <aroben at apple.com>
 
         Stop leaking the web process's process handle on Windows
diff --git a/WebKit2/UIProcess/WebPageProxy.cpp b/WebKit2/UIProcess/WebPageProxy.cpp
index 0ee3451..2828a79 100644
--- a/WebKit2/UIProcess/WebPageProxy.cpp
+++ b/WebKit2/UIProcess/WebPageProxy.cpp
@@ -730,7 +730,7 @@ void WebPageProxy::didReceiveMessage(CoreIPC::Connection* connection, CoreIPC::M
             int32_t mouseButton;
             String url;
             uint64_t listenerID;
-            if (!arguments->decode(CoreIPC::Out(frameID, navigationType, modifiers, url, mouseButton, listenerID)))
+            if (!arguments->decode(CoreIPC::Out(frameID, navigationType, modifiers, mouseButton, url, listenerID)))
                 return;
             decidePolicyForNewWindowAction(process()->webFrame(frameID), static_cast<NavigationType>(navigationType), static_cast<WebEvent::Modifiers>(modifiers), static_cast<WebMouseEvent::Button>(mouseButton), url, listenerID);
             break;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list