[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

andersca at apple.com andersca at apple.com
Wed Dec 22 13:49:04 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 259d373611e1288661f9f5d7da190ff01155f1f4
Author: andersca at apple.com <andersca at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Sep 27 21:48:35 2010 +0000

    Try to fix Windows build.
    
    Reviewed by Adam Roben.
    
    * runtime/JSCell.h:
    (JSC::MSVCBugWorkaround::MSVCBugWorkaround):
    (JSC::MSVCBugWorkaround::~MSVCBugWorkaround):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index 28b1ab9..9ebb4c6 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-27  Anders Carlsson  <andersca at apple.com>
+
+        Reviewed by Adam Roben.
+
+        Try to fix Windows build.
+
+        * runtime/JSCell.h:
+        (JSC::MSVCBugWorkaround::MSVCBugWorkaround):
+        (JSC::MSVCBugWorkaround::~MSVCBugWorkaround):
+
 2010-09-27  Erik Arvidsson  <arv at chromium.org>
 
         Reviewed by Darin Adler.
diff --git a/JavaScriptCore/runtime/JSCell.h b/JavaScriptCore/runtime/JSCell.h
index 653cd9e..49bece5 100644
--- a/JavaScriptCore/runtime/JSCell.h
+++ b/JavaScriptCore/runtime/JSCell.h
@@ -34,7 +34,22 @@
 
 namespace JSC {
 
+#if COMPILER(MSVC)
+    // If WTF_MAKE_NONCOPYABLE is applied to JSCell we end up with a bunch of
+    // undefined references to the JSCell copy constructor and assignment operator
+    // when linking JavaScriptCore.
+    class MSVCBugWorkaround {
+        WTF_MAKE_NONCOPYABLE(MSVCBugWorkaround);
+
+    protected:
+        MSVCBugWorkaround() { }
+        ~MSVCBugWorkaround() { }
+    };
+
+    class JSCell : MSVCBugWorkaround {
+#else
     class JSCell {
+#endif
         WTF_MAKE_NONCOPYABLE(JSCell);
 
         friend class GetterSetter;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list