[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

crogers at google.com crogers at google.com
Wed Dec 22 13:52:14 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 06263d29f50d96cd333e6aa0b4ebc420372add2f
Author: crogers at google.com <crogers at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Sep 28 17:31:30 2010 +0000

    2010-09-28  Chris Rogers  <crogers at google.com>
    
            Reviewed by Kenneth Russell.
    
            Fix possible illegal float values in AudioParam
            https://bugs.webkit.org/show_bug.cgi?id=46681
    
            No new tests since audio API is not yet implemented.
    
            * webaudio/AudioParam.h:
            (WebCore::AudioParam::setValue):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 73e78f3..0d0f1c3 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-09-28  Chris Rogers  <crogers at google.com>
+
+        Reviewed by Kenneth Russell.
+
+        Fix possible illegal float values in AudioParam
+        https://bugs.webkit.org/show_bug.cgi?id=46681
+
+        No new tests since audio API is not yet implemented.
+
+        * webaudio/AudioParam.h:
+        (WebCore::AudioParam::setValue):
+
 2010-09-28  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
 
         Reviewed by Simon Hausmann.
diff --git a/WebCore/webaudio/AudioParam.h b/WebCore/webaudio/AudioParam.h
index 2fbd805..7643cf3 100644
--- a/WebCore/webaudio/AudioParam.h
+++ b/WebCore/webaudio/AudioParam.h
@@ -60,7 +60,14 @@ public:
     }
 
     float value() const { return static_cast<float>(m_value); }
-    void setValue(float value) { m_value = value; }
+    
+    void setValue(float value)
+    {
+        // Check against JavaScript giving us bogus floating-point values.
+        // Don't ASSERT, since this can happen if somebody writes bad JS.
+        if (!isnan(value) && !isinf(value))
+            m_value = value;
+    }
 
     String name() const { return m_name; }
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list