[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
andreip at google.com
andreip at google.com
Wed Dec 22 13:52:33 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 6d3c4e6b173fa4a06ccd01384c949dd6ded6540c
Author: andreip at google.com <andreip at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Sep 28 18:28:21 2010 +0000
2010-09-28 Andrei Popescu <andreip at google.com>
Reviewed by Jeremy Orlow.
IDBRequest should not have a method called abort.
https://bugs.webkit.org/show_bug.cgi?id=46720
* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/resources/shared.js:
(verifyEventCommon):
(verifyResult):
* storage/indexeddb/transaction-basics-expected.txt:
2010-09-28 Andrei Popescu <andreip at google.com>
Reviewed by Jeremy Orlow.
IDBRequest should not have a method called abort.
https://bugs.webkit.org/show_bug.cgi?id=46720
IDBRequest::abort() was dropped from the spec following discussion in
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10165
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::scheduleEvent):
* storage/IDBRequest.h:
* storage/IDBRequest.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 1036dd6..94aac8e 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,23 @@
+2010-09-28 Andrei Popescu <andreip at google.com>
+
+ Reviewed by Jeremy Orlow.
+
+ IDBRequest should not have a method called abort.
+ https://bugs.webkit.org/show_bug.cgi?id=46720
+
+ * storage/indexeddb/basics-expected.txt:
+ * storage/indexeddb/database-basics-expected.txt:
+ * storage/indexeddb/index-basics-expected.txt:
+ * storage/indexeddb/index-cursor-expected.txt:
+ * storage/indexeddb/objectstore-basics-expected.txt:
+ * storage/indexeddb/objectstore-cursor-expected.txt:
+ * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
+ * storage/indexeddb/open-cursor-expected.txt:
+ * storage/indexeddb/resources/shared.js:
+ (verifyEventCommon):
+ (verifyResult):
+ * storage/indexeddb/transaction-basics-expected.txt:
+
2010-09-28 Ryosuke Niwa <rniwa at webkit.org>
Unreviewed.
diff --git a/LayoutTests/storage/indexeddb/basics-expected.txt b/LayoutTests/storage/indexeddb/basics-expected.txt
index 5365901..7632e40 100644
--- a/LayoutTests/storage/indexeddb/basics-expected.txt
+++ b/LayoutTests/storage/indexeddb/basics-expected.txt
@@ -8,7 +8,6 @@ PASS indexedDB == null is false
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -20,7 +19,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
diff --git a/LayoutTests/storage/indexeddb/database-basics-expected.txt b/LayoutTests/storage/indexeddb/database-basics-expected.txt
index fc224cc..42c9879 100644
--- a/LayoutTests/storage/indexeddb/database-basics-expected.txt
+++ b/LayoutTests/storage/indexeddb/database-basics-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -27,7 +25,6 @@ Testing setVersion.
db.setVersion("version a")
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -39,14 +36,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
db.setVersion("version b")
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -58,7 +53,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -70,7 +64,6 @@ PASS db.objectStores.contains('') is false
db.createObjectStore("test123")
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -82,7 +75,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -94,3 +86,4 @@ PASS db.objectStores.contains('test123') is true
PASS successfullyParsed is true
TEST COMPLETE
+
diff --git a/LayoutTests/storage/indexeddb/index-basics-expected.txt b/LayoutTests/storage/indexeddb/index-basics-expected.txt
index a99bc86..564bdc8 100644
--- a/LayoutTests/storage/indexeddb/index-basics-expected.txt
+++ b/LayoutTests/storage/indexeddb/index-basics-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -26,7 +24,6 @@ db = event.result
db.createObjectStore('storeName', null)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -38,7 +35,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -46,7 +42,6 @@ store = event.result
event.result.createIndex('indexName', 'x')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -58,7 +53,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -79,7 +73,6 @@ PASS 'get' in indexObject is true
event.source.add({x: 'value', y: 'zzz'}, 'key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -91,14 +84,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
event.source.add({x: 'value2', y: 'zzz2'}, 'key2')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -110,14 +101,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
indexObject.get('value')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -129,7 +118,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -137,7 +125,6 @@ PASS event.result is "key"
indexObject.getObject('value')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -149,7 +136,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -158,7 +144,6 @@ PASS event.result.y is "zzz"
indexObject.get('does not exist')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -170,7 +155,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -178,7 +162,6 @@ PASS event.code is IDBDatabaseException.NOT_FOUND_ERR
indexObject.getObject('does not exist')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -190,7 +173,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -198,7 +180,6 @@ PASS event.code is IDBDatabaseException.NOT_FOUND_ERR
indexObject.openCursor()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -210,7 +191,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -220,7 +200,6 @@ PASS event.result.value is "key"
event.result.continue()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -232,7 +211,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -242,7 +220,6 @@ PASS event.result.value is "key2"
event.result.continue()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -254,7 +231,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -262,7 +238,6 @@ PASS event.result === null is true
indexObject.openObjectCursor()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -274,7 +249,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -285,7 +259,6 @@ PASS event.result.value.y is "zzz"
event.result.continue()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -297,7 +270,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -308,7 +280,6 @@ PASS event.result.value.y is "zzz2"
event.result.continue()
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -320,7 +291,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
diff --git a/LayoutTests/storage/indexeddb/index-cursor-expected.txt b/LayoutTests/storage/indexeddb/index-cursor-expected.txt
index 1442ad4..6d1417f 100644
--- a/LayoutTests/storage/indexeddb/index-cursor-expected.txt
+++ b/LayoutTests/storage/indexeddb/index-cursor-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('someDB', 'some description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -26,7 +24,6 @@ db = event.result
db.createObjectStore('someObjectStore')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -38,7 +35,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -46,7 +42,6 @@ objectStore = event.result
objectStore.createIndex('someIndex', 'x')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -58,7 +53,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -71,14 +65,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -90,14 +82,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -109,14 +99,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -128,14 +116,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -147,14 +133,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -166,14 +150,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -185,14 +167,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -204,14 +184,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add({'x': testData[nextToAdd]}, nextToAdd)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
diff --git a/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt b/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt
index 9a91cdf..7b5439a 100644
--- a/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt
+++ b/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -19,7 +18,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -27,7 +25,6 @@ db = event.result
db.createObjectStore('storeName', null)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -40,7 +37,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -57,7 +53,6 @@ FAIL Asking for a store that doesn't exist should have thrown.
event.result.createIndex('indexName', 'x', true)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -70,7 +65,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -85,7 +79,6 @@ FAIL Asking for a store that doesn't exist should have thrown.
event.source.add({x: 'value'}, 'key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -98,7 +91,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -106,7 +98,6 @@ PASS event.result is "key"
event.source.add({x: 'value'}, 'zzz')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -119,7 +110,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -129,7 +119,6 @@ store = transaction.objectStore('storeName')
store.get('key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -142,7 +131,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -151,7 +139,6 @@ store = event.source
store.remove('key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -164,7 +151,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
diff --git a/LayoutTests/storage/indexeddb/objectstore-cursor-expected.txt b/LayoutTests/storage/indexeddb/objectstore-cursor-expected.txt
index ce5514a..e7211f6 100644
--- a/LayoutTests/storage/indexeddb/objectstore-cursor-expected.txt
+++ b/LayoutTests/storage/indexeddb/objectstore-cursor-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('someDB', 'some description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -26,7 +24,6 @@ db = event.result
db.createObjectStore('someObjectStore')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -38,7 +35,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -51,14 +47,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -70,14 +64,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -89,14 +81,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -108,14 +98,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -127,14 +115,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -146,14 +132,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -165,14 +149,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
objectStore.add('', testData[nextToAdd])
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
diff --git a/LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt b/LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt
index 60fedec..b7ba473 100644
--- a/LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt
+++ b/LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -26,7 +24,6 @@ db = event.result
db.createObjectStore('storeName', null)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -38,14 +35,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
event.result.add('value', 'key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -57,7 +52,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -66,7 +60,6 @@ store = transaction.objectStore('storeName')
store.get('key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -78,7 +71,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -86,7 +78,6 @@ PASS event.result is "value"
event.source.createIndex('indexName', '')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -98,7 +89,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -106,7 +96,6 @@ PASS event.source.indexNames.contains('indexName') is true
db.removeObjectStore('storeName')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -118,14 +107,12 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
db.createObjectStore('storeName', null)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -137,7 +124,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -146,7 +132,6 @@ store = transaction.objectStore('storeName')
store.get('key')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -158,7 +143,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
diff --git a/LayoutTests/storage/indexeddb/open-cursor-expected.txt b/LayoutTests/storage/indexeddb/open-cursor-expected.txt
index e4ddc69..bda103f 100644
--- a/LayoutTests/storage/indexeddb/open-cursor-expected.txt
+++ b/LayoutTests/storage/indexeddb/open-cursor-expected.txt
@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -18,7 +17,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -26,7 +24,6 @@ db = event.result
db.createObjectStore('test')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -38,7 +35,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -46,7 +42,6 @@ objectStore = event.result
objectStore.add('myValue', 'myKey')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -54,7 +49,6 @@ Opening cursor
objectStore.openCursor(keyRange)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -67,7 +61,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -79,7 +72,6 @@ Opening an empty cursor.
objectStore.openCursor(keyRange)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -92,10 +84,10 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
PASS successfullyParsed is true
TEST COMPLETE
+
diff --git a/LayoutTests/storage/indexeddb/resources/shared.js b/LayoutTests/storage/indexeddb/resources/shared.js
index 112bf18..65da3bf 100644
--- a/LayoutTests/storage/indexeddb/resources/shared.js
+++ b/LayoutTests/storage/indexeddb/resources/shared.js
@@ -11,7 +11,6 @@ function verifyEventCommon(event)
shouldBeTrue("event.source != null");
shouldBeTrue("'onsuccess' in event.target");
shouldBeTrue("'onerror' in event.target");
- shouldBeTrue("'abort' in event.target");
shouldBeTrue("'readyState' in event.target");
shouldBe("event.target.readyState", "event.target.DONE");
debug("");
@@ -45,7 +44,6 @@ function verifyResult(result)
{
shouldBeTrue("'onsuccess' in result");
shouldBeTrue("'onerror' in result");
- shouldBeTrue("'abort' in result");
shouldBeTrue("'readyState' in result");
debug("An event should fire shortly...");
debug("");
diff --git a/LayoutTests/storage/indexeddb/transaction-basics-expected.txt b/LayoutTests/storage/indexeddb/transaction-basics-expected.txt
index 25d0694..bba62f0 100644
--- a/LayoutTests/storage/indexeddb/transaction-basics-expected.txt
+++ b/LayoutTests/storage/indexeddb/transaction-basics-expected.txt
@@ -8,7 +8,6 @@ PASS indexedDB == null is false
indexedDB.open('name', 'description')
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -21,7 +20,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -29,7 +27,6 @@ db = event.result
db.createObjectStore('storeName', null)
PASS 'onsuccess' in result is true
PASS 'onerror' in result is true
-PASS 'abort' in result is true
PASS 'readyState' in result is true
An event should fire shortly...
@@ -41,7 +38,6 @@ PASS 'source' in event is true
PASS event.source != null is true
PASS 'onsuccess' in event.target is true
PASS 'onerror' in event.target is true
-PASS 'abort' in event.target is true
PASS 'readyState' in event.target is true
PASS event.target.readyState is event.target.DONE
@@ -53,3 +49,4 @@ PASS event.type is "abort"
PASS successfullyParsed is true
TEST COMPLETE
+
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 6d652bf..9ea5201 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,22 @@
+2010-09-28 Andrei Popescu <andreip at google.com>
+
+ Reviewed by Jeremy Orlow.
+
+ IDBRequest should not have a method called abort.
+ https://bugs.webkit.org/show_bug.cgi?id=46720
+
+ IDBRequest::abort() was dropped from the spec following discussion in
+ http://www.w3.org/Bugs/Public/show_bug.cgi?id=10165
+
+ * storage/IDBRequest.cpp:
+ (WebCore::IDBRequest::IDBRequest):
+ (WebCore::IDBRequest::~IDBRequest):
+ (WebCore::IDBRequest::resetReadyState):
+ (WebCore::IDBRequest::timerFired):
+ (WebCore::IDBRequest::scheduleEvent):
+ * storage/IDBRequest.h:
+ * storage/IDBRequest.idl:
+
2010-09-28 Chris Fleizach <cfleizach at apple.com>
Reviewed by Beth Dakin.
diff --git a/WebCore/storage/IDBRequest.cpp b/WebCore/storage/IDBRequest.cpp
index a7760f4..c672642 100644
--- a/WebCore/storage/IDBRequest.cpp
+++ b/WebCore/storage/IDBRequest.cpp
@@ -51,7 +51,6 @@ IDBRequest::IDBRequest(ScriptExecutionContext* context, PassRefPtr<IDBAny> sourc
, m_source(source)
, m_transaction(transaction)
, m_timer(this, &IDBRequest::timerFired)
- , m_aborted(false)
, m_readyState(LOADING)
{
if (transaction)
@@ -69,13 +68,10 @@ IDBRequest::~IDBRequest()
// so having a non-zero pointer at IDBRequest destruction time shows that the events have not
// yet fired and there is a transaction waiting to be notified. This is an error.
ASSERT(!m_transaction);
- abort();
}
bool IDBRequest::resetReadyState()
{
- if (m_aborted)
- return false;
ASSERT(m_readyState == DONE);
m_readyState = LOADING;
return true;
@@ -123,15 +119,6 @@ void IDBRequest::onSuccess(PassRefPtr<SerializedScriptValue> serializedScriptVal
scheduleEvent(IDBAny::create(serializedScriptValue), 0);
}
-void IDBRequest::abort()
-{
- m_timer.stop();
- m_aborted = true;
- m_pendingEvents.clear();
-
- // FIXME: This should cancel any pending work being done in the backend.
-}
-
ScriptExecutionContext* IDBRequest::scriptExecutionContext() const
{
return ActiveDOMObject::scriptExecutionContext();
@@ -157,7 +144,6 @@ EventTargetData* IDBRequest::ensureEventTargetData()
void IDBRequest::timerFired(Timer<IDBRequest>*)
{
ASSERT(m_selfRef);
- ASSERT(!m_aborted);
ASSERT(m_pendingEvents.size());
// We need to keep self-referencing ourself, otherwise it's possible we'll be deleted.
@@ -190,9 +176,6 @@ void IDBRequest::scheduleEvent(PassRefPtr<IDBAny> result, PassRefPtr<IDBDatabase
ASSERT(m_readyState < DONE);
ASSERT(!!m_selfRef == m_timer.isActive());
- if (m_aborted)
- return;
-
PendingEvent pendingEvent;
pendingEvent.m_result = result;
pendingEvent.m_error = error;
diff --git a/WebCore/storage/IDBRequest.h b/WebCore/storage/IDBRequest.h
index c0515aa..75cd9a8 100644
--- a/WebCore/storage/IDBRequest.h
+++ b/WebCore/storage/IDBRequest.h
@@ -50,7 +50,6 @@ public:
virtual ~IDBRequest();
// Defined in the IDL
- void abort();
enum ReadyState {
LOADING = 1,
DONE = 2
@@ -106,7 +105,6 @@ private:
Timer<IDBRequest> m_timer;
RefPtr<IDBRequest> m_selfRef; // This is set to us iff there's an event pending.
- bool m_aborted;
ReadyState m_readyState;
EventTargetData m_eventTargetData;
};
diff --git a/WebCore/storage/IDBRequest.idl b/WebCore/storage/IDBRequest.idl
index 3036b6b..58872f0 100644
--- a/WebCore/storage/IDBRequest.idl
+++ b/WebCore/storage/IDBRequest.idl
@@ -32,7 +32,6 @@ module storage {
Conditional=INDEXED_DATABASE,
EventTarget
] IDBRequest {
- void abort();
// States
const unsigned short LOADING = 1;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list