[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

mitz at apple.com mitz at apple.com
Wed Dec 22 13:55:38 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 6ed9799a526250b55eb2e5e0a78abd7fadb6c178
Author: mitz at apple.com <mitz at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Sep 29 21:12:44 2010 +0000

    Removed input type site-specific quirk for mail.google.com
    https://bugs.webkit.org/show_bug.cgi?id=46836
    
    Reviewed by Sam Weinig.
    
    * bindings/js/JSHTMLInputElementCustom.cpp:
    (WebCore::needsGmailQuirk): Removed.
    (WebCore::JSHTMLInputElement::type): Removed this custom getter.
    * html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute
    from the type attribute.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 91057fc..621e779 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-09-29  Dan Bernstein  <mitz at apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Removed input type site-specific quirk for mail.google.com
+        https://bugs.webkit.org/show_bug.cgi?id=46836
+
+        * bindings/js/JSHTMLInputElementCustom.cpp:
+        (WebCore::needsGmailQuirk): Removed.
+        (WebCore::JSHTMLInputElement::type): Removed this custom getter. 
+        * html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute
+        from the type attribute.
+
 2010-09-29  Joseph Pecoraro  <joepeck at webkit.org>
 
         Reviewed by Simon Fraser.
diff --git a/WebCore/bindings/js/JSHTMLInputElementCustom.cpp b/WebCore/bindings/js/JSHTMLInputElementCustom.cpp
index 23db266..412a096 100644
--- a/WebCore/bindings/js/JSHTMLInputElementCustom.cpp
+++ b/WebCore/bindings/js/JSHTMLInputElementCustom.cpp
@@ -26,47 +26,13 @@
 #include "config.h"
 #include "JSHTMLInputElement.h"
 
-#include "Document.h"
 #include "HTMLInputElement.h"
-#include "Settings.h"
 #include <runtime/Error.h>
 
 using namespace JSC;
 
 namespace WebCore {
 
-static bool needsGmailQuirk(HTMLInputElement* input)
-{
-    Document* document = input->document();
-
-    const KURL& url = document->url();
-    if (url.host() != "mail.google.com")
-        return false;
-
-    // As with other site-specific quirks, allow website developers to turn this off.
-    // In theory, this allows website developers to check if their fixes are effective.
-    Settings* settings = document->settings();
-    if (!settings)
-        return false;
-    if (!settings->needsSiteSpecificQuirks())
-        return false;
-
-    return true;
-}
-
-JSValue JSHTMLInputElement::type(ExecState* exec) const
-{
-    HTMLInputElement* input = static_cast<HTMLInputElement*>(impl());
-    const AtomicString& type = input->type();
-
-    DEFINE_STATIC_LOCAL(const AtomicString, url, ("url"));
-    DEFINE_STATIC_LOCAL(const AtomicString, text, ("text"));
-
-    if (type == url && needsGmailQuirk(input))
-        return jsString(exec, text);
-    return jsString(exec, type);
-}
-
 JSValue JSHTMLInputElement::selectionStart(ExecState* exec) const
 {
     HTMLInputElement* input = static_cast<HTMLInputElement*>(impl());
diff --git a/WebCore/html/HTMLInputElement.idl b/WebCore/html/HTMLInputElement.idl
index 19dfa5a..0cfb386 100644
--- a/WebCore/html/HTMLInputElement.idl
+++ b/WebCore/html/HTMLInputElement.idl
@@ -56,7 +56,7 @@ module html {
 #endif
         attribute [Reflect, URL] DOMString src;
         attribute [Reflect] DOMString step;
-        attribute [ConvertNullToNullString, JSCCustomGetter] DOMString type; // readonly dropped as part of DOM level 2
+        attribute [ConvertNullToNullString] DOMString type; // readonly dropped as part of DOM level 2
         attribute [Reflect] DOMString useMap;
         attribute [ConvertNullToNullString] DOMString value;
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list