[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

crogers at google.com crogers at google.com
Wed Dec 22 13:56:16 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit d77c0affccc39e9d94e5d772d31a0f344c7020bc
Author: crogers at google.com <crogers at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Sep 30 01:12:20 2010 +0000

    2010-09-29  Chris Rogers  <crogers at google.com>
    
            Reviewed by Kenneth Russell.
    
            Add AudioGainNode files
            https://bugs.webkit.org/show_bug.cgi?id=46286
    
            No new tests since audio API is not yet implemented.
    
            * webaudio/AudioGainNode.cpp: Added.
            (WebCore::AudioGainNode::AudioGainNode):
            (WebCore::AudioGainNode::process):
            (WebCore::AudioGainNode::reset):
            (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
            * webaudio/AudioGainNode.h: Added.
            (WebCore::AudioGainNode::create):
            (WebCore::AudioGainNode::gain):
            * webaudio/AudioGainNode.idl: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0cadcd0..f20398a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -2,6 +2,25 @@
 
         Reviewed by Kenneth Russell.
 
+        Add AudioGainNode files
+        https://bugs.webkit.org/show_bug.cgi?id=46286
+
+        No new tests since audio API is not yet implemented.
+
+        * webaudio/AudioGainNode.cpp: Added.
+        (WebCore::AudioGainNode::AudioGainNode):
+        (WebCore::AudioGainNode::process):
+        (WebCore::AudioGainNode::reset):
+        (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
+        * webaudio/AudioGainNode.h: Added.
+        (WebCore::AudioGainNode::create):
+        (WebCore::AudioGainNode::gain):
+        * webaudio/AudioGainNode.idl: Added.
+
+2010-09-29  Chris Rogers  <crogers at google.com>
+
+        Reviewed by Kenneth Russell.
+
         Add AudioChannelMerger files
         https://bugs.webkit.org/show_bug.cgi?id=46291
 
diff --git a/WebCore/webaudio/AudioGainNode.cpp b/WebCore/webaudio/AudioGainNode.cpp
new file mode 100644
index 0000000..332929d
--- /dev/null
+++ b/WebCore/webaudio/AudioGainNode.cpp
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *     notice, this list of conditions and the following disclaimer in the
+ *     documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
+ *     its contributors may be used to endorse or promote products derived
+ *     from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#if ENABLE(WEB_AUDIO)
+
+#include "AudioGainNode.h"
+
+#include "AudioBus.h"
+#include "AudioNodeInput.h"
+#include "AudioNodeOutput.h"
+
+namespace WebCore {
+
+AudioGainNode::AudioGainNode(AudioContext* context, double sampleRate)
+    : AudioNode(context, sampleRate)
+    , m_lastGain(1.0)
+{
+    m_gain = AudioGain::create("gain", 1.0, 0.0, 1.0);
+
+    addInput(adoptPtr(new AudioNodeInput(this)));
+    addOutput(adoptPtr(new AudioNodeOutput(this, 1)));
+    
+    setType(NodeTypeGain);
+    
+    initialize();
+}
+
+void AudioGainNode::process(size_t /*framesToProcess*/)
+{
+    // FIXME: there is a nice optimization to avoid processing here, and let the gain change
+    // happen in the summing junction input of the AudioNode we're connected to.
+    // Then we can avoid all of the following:
+
+    AudioBus* outputBus = output(0)->bus();
+    ASSERT(outputBus);
+
+    // The realtime thread can't block on this lock, so we call tryLock() instead.
+    if (m_processLock.tryLock()) {
+        if (!isInitialized() || !input(0)->isConnected())
+            outputBus->zero();
+        else {
+            AudioBus* inputBus = input(0)->bus();
+
+            // Apply the gain with de-zippering into the output bus.
+            outputBus->copyWithGainFrom(*inputBus, &m_lastGain, gain()->value());
+        }
+
+        m_processLock.unlock();
+    } else {
+        // Too bad - the tryLock() failed.  We must be in the middle of re-connecting and were already outputting silence anyway...
+        outputBus->zero();
+    }
+}
+
+void AudioGainNode::reset()
+{
+    // Snap directly to desired gain.
+    m_lastGain = gain()->value();
+}
+
+// FIXME: this can go away when we do mixing with gain directly in summing junction of AudioNodeInput
+//
+// As soon as we know the channel count of our input, we can lazily initialize.
+// Sometimes this may be called more than once with different channel counts, in which case we must safely
+// uninitialize and then re-initialize with the new channel count.
+void AudioGainNode::checkNumberOfChannelsForInput(AudioNodeInput* input)
+{
+    ASSERT(input && input == this->input(0));
+    if (input != this->input(0))
+        return;
+        
+    unsigned numberOfChannels = input->numberOfChannels();    
+
+    if (isInitialized() && numberOfChannels != output(0)->numberOfChannels()) {
+        // We're already initialized but the channel count has changed.
+        // We need to be careful since we may be actively processing right now, so synchronize with process().
+        MutexLocker locker(m_processLock);
+        uninitialize();
+    }
+
+    // This will propagate the channel count to any nodes connected further downstream in the graph.
+    output(0)->setNumberOfChannels(numberOfChannels);
+
+    initialize();
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(WEB_AUDIO)
diff --git a/WebCore/webaudio/AudioGainNode.h b/WebCore/webaudio/AudioGainNode.h
new file mode 100644
index 0000000..91f9d16
--- /dev/null
+++ b/WebCore/webaudio/AudioGainNode.h
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *     notice, this list of conditions and the following disclaimer in the
+ *     documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
+ *     its contributors may be used to endorse or promote products derived
+ *     from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef AudioGainNode_h
+#define AudioGainNode_h
+
+#include "AudioGain.h"
+#include "AudioNode.h"
+#include <wtf/PassRefPtr.h>
+#include <wtf/Threading.h>
+
+namespace WebCore {
+
+class AudioContext;
+    
+// AudioGainNode is an AudioNode with one input and one output which applies a gain (volume) change to the audio signal.
+// De-zippering (smoothing) is applied when the gain value is changed dynamically.
+
+class AudioGainNode : public AudioNode {
+public:
+    static PassRefPtr<AudioGainNode> create(AudioContext* context, double sampleRate)
+    {
+        return adoptRef(new AudioGainNode(context, sampleRate));      
+    }
+    
+    // AudioNode
+    virtual void process(size_t framesToProcess);
+    virtual void reset();
+
+    // Called in the main thread when the number of channels for the input may have changed.
+    virtual void checkNumberOfChannelsForInput(AudioNodeInput*);
+
+    // JavaScript interface
+    AudioGain* gain() { return m_gain.get(); }                                   
+    
+private:
+    AudioGainNode(AudioContext*, double sampleRate);
+
+    double m_lastGain; // for de-zippering
+    RefPtr<AudioGain> m_gain;
+
+    // This synchronizes live channel count changes which require an uninitialization / re-initialization.
+    // FIXME: this can go away when we implement optimization for mixing with gain directly in summing junction of AudioNodeInput.
+    mutable Mutex m_processLock;
+};
+
+} // namespace WebCore
+
+#endif // AudioGainNode_h
diff --git a/WebCore/webaudio/AudioGainNode.idl b/WebCore/webaudio/AudioGainNode.idl
new file mode 100644
index 0000000..8bf117a
--- /dev/null
+++ b/WebCore/webaudio/AudioGainNode.idl
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *     notice, this list of conditions and the following disclaimer in the
+ *     documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
+ *     its contributors may be used to endorse or promote products derived
+ *     from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+module audio {
+    interface [
+        Conditional=WEB_AUDIO,
+        GenerateToJS
+    ] AudioGainNode : AudioNode {
+        // FIXME: eventually it will be interesting to remove the readonly restriction, but need to properly deal with thread safety here.
+        readonly attribute AudioGain gain;
+    };
+}

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list