[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[abarth at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit aca55697ea8e01cde0f5c7ee4a045f36988a7673
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Sep 30 04:07:22 2010 +0000

    2010-09-29  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            Remove revisions_casuing_failures
            https://bugs.webkit.org/show_bug.cgi?id=46872
    
            This function exists only to be unit tested.
    
            * Scripts/webkitpy/common/net/failuremap.py:
            * Scripts/webkitpy/common/net/failuremap_unittest.py:
            * Scripts/webkitpy/tool/mocktool.py:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index b272c77..6823524 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -2,6 +2,19 @@
 
         Reviewed by Eric Seidel.
 
+        Remove revisions_casuing_failures
+        https://bugs.webkit.org/show_bug.cgi?id=46872
+
+        This function exists only to be unit tested.
+
+        * Scripts/webkitpy/common/net/failuremap.py:
+        * Scripts/webkitpy/common/net/failuremap_unittest.py:
+        * Scripts/webkitpy/tool/mocktool.py:
+
+2010-09-29  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Eric Seidel.
+
         SheriffBot should post the list of failing tests to bugs
         https://bugs.webkit.org/show_bug.cgi?id=46871
 
diff --git a/WebKitTools/Scripts/webkitpy/common/net/failuremap.py b/WebKitTools/Scripts/webkitpy/common/net/failuremap.py
index 2938d38..ef680a3 100644
--- a/WebKitTools/Scripts/webkitpy/common/net/failuremap.py
+++ b/WebKitTools/Scripts/webkitpy/common/net/failuremap.py
@@ -54,18 +54,6 @@ class FailureMap(object):
                  if revision in failure_info['regression_window'].revisions()]
         return sorted(set(sum(failing_tests, [])))
 
-    # FIXME: Consider removing this method.  It might now exist only for
-    #        unit testing!
-    def revisions_causing_failures(self):
-        revision_to_failing_bots = {}
-        for failure_info in self._failures:
-            revisions = failure_info['regression_window'].revisions()
-            for revision in revisions:
-                failing_bots = revision_to_failing_bots.get(revision, [])
-                failing_bots.append(failure_info['builder'])
-                revision_to_failing_bots[revision] = failing_bots
-        return revision_to_failing_bots
-
     def _old_failures(self, is_old_failure):
         return filter(lambda revision: is_old_failure(revision),
                       self.failing_revisions())
diff --git a/WebKitTools/Scripts/webkitpy/common/net/failuremap_unittest.py b/WebKitTools/Scripts/webkitpy/common/net/failuremap_unittest.py
index b79c687..e572da8 100644
--- a/WebKitTools/Scripts/webkitpy/common/net/failuremap_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/common/net/failuremap_unittest.py
@@ -59,19 +59,14 @@ class FailureMapTest(unittest.TestCase):
     def test_new_failures(self):
         failure_map = self._make_failure_map()
         failure_map.filter_out_old_failures(lambda revision: False)
-        self.assertEquals(failure_map.revisions_causing_failures(), {
-            1234: [self.builder1, self.builder2],
-            1235: [self.builder2],
-        })
+        self.assertEquals(failure_map.failing_revisions(), [1234, 1235])
 
     def test_new_failures_with_old_revisions(self):
         failure_map = self._make_failure_map()
         failure_map.filter_out_old_failures(lambda revision: revision == 1234)
-        self.assertEquals(failure_map.revisions_causing_failures(), {})
+        self.assertEquals(failure_map.failing_revisions(), [])
 
     def test_new_failures_with_more_old_revisions(self):
         failure_map = self._make_failure_map()
         failure_map.filter_out_old_failures(lambda revision: revision == 1235)
-        self.assertEquals(failure_map.revisions_causing_failures(), {
-            1234: [self.builder1],
-        })
+        self.assertEquals(failure_map.failing_revisions(), [1234])
diff --git a/WebKitTools/Scripts/webkitpy/tool/mocktool.py b/WebKitTools/Scripts/webkitpy/tool/mocktool.py
index 03f2864..31f4539 100644
--- a/WebKitTools/Scripts/webkitpy/tool/mocktool.py
+++ b/WebKitTools/Scripts/webkitpy/tool/mocktool.py
@@ -357,11 +357,6 @@ class MockFailureMap(object):
     def is_empty(self):
         return False
 
-    def revisions_causing_failures(self):
-        return {
-            "29837": [self._buildbot.builder_with_name("Builder1")],
-        }
-
     def filter_out_old_failures(self, is_old_revision):
         pass
 

-- 
WebKit Debian packaging