[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

kseo at webkit.org kseo at webkit.org
Wed Dec 22 14:13:05 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 5301b8160b440ba9ab8813ca4582b0949747df6b
Author: kseo at webkit.org <kseo at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Oct 5 16:42:34 2010 +0000

    [BREWMP] Use PlatformRefPtr in getDisplayInfo
    https://bugs.webkit.org/show_bug.cgi?id=47023
    
    Reviewed by Kent Tamura.
    
    Use PlatformRefPtr to release IBitmap* automatically.
    
    * platform/brew/ScreenBrew.cpp:
    (WebCore::getDisplayInfo):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 510b944..3781c08 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-10-05  Kwang Yul Seo  <skyul at company100.net>
+
+        Reviewed by Kent Tamura.
+
+        [BREWMP] Use PlatformRefPtr in getDisplayInfo
+        https://bugs.webkit.org/show_bug.cgi?id=47023
+
+        Use PlatformRefPtr to release IBitmap* automatically.
+
+        * platform/brew/ScreenBrew.cpp:
+        (WebCore::getDisplayInfo):
+
 2010-10-05  Kristian Monsen  <kristianm at google.com>
 
         Reviewed by Steve Block.
diff --git a/WebCore/platform/brew/ScreenBrew.cpp b/WebCore/platform/brew/ScreenBrew.cpp
index b141b34..53e53d0 100644
--- a/WebCore/platform/brew/ScreenBrew.cpp
+++ b/WebCore/platform/brew/ScreenBrew.cpp
@@ -36,6 +36,7 @@
 
 #include <AEEAppGen.h>
 #include <AEEStdLib.h>
+#include <wtf/brew/RefPtrBrew.h>
 
 namespace WebCore {
 
@@ -48,17 +49,14 @@ struct DisplayInfo {
 static void getDisplayInfo(DisplayInfo& info)
 {
     IDisplay* display = reinterpret_cast<AEEApplet*>(GETAPPINSTANCE())->m_pIDisplay;
-    IBitmap* bitmap = IDisplay_GetDestination(display);
-    ASSERT(bitmap);
+    PlatformRefPtr<IBitmap> bitmap = adoptPlatformRef(IDisplay_GetDestination(display));
 
     AEEBitmapInfo bitmapInfo;
-    IBitmap_GetInfo(bitmap, &bitmapInfo, sizeof(AEEBitmapInfo));
+    IBitmap_GetInfo(bitmap.get(), &bitmapInfo, sizeof(AEEBitmapInfo));
 
     info.width  = bitmapInfo.cx;
     info.height = bitmapInfo.cy;
     info.depth  = bitmapInfo.nDepth;
-
-    IBitmap_Release(bitmap);
 }
 
 FloatRect screenRect(Widget*)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list