[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
atwilson at chromium.org
atwilson at chromium.org
Wed Dec 22 14:14:31 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit babc1b35733dea2c9b5c6d13df636b6bb4e1ed2c
Author: atwilson at chromium.org <atwilson at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 5 20:41:15 2010 +0000
2010-10-05 Andrew Wilson <atwilson at chromium.org>
Reviewed by Andreas Kling.
Notification onclick() events don't act like user gestures
https://bugs.webkit.org/show_bug.cgi?id=47137
* src/WebNotification.cpp:
(WebKit::WebNotification::dispatchClickEvent):
Use UserGestureIndicator to make sure click events are treated like user gestures.
2010-10-05 Andrew Wilson <atwilson at chromium.org>
Reviewed by Andreas Kling.
Notification onclick() events don't act like user gestures
https://bugs.webkit.org/show_bug.cgi?id=47137
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):
Use UserGestureIndicator to make sure click events are treated like user gestures.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 7fd3321..1edf8f4 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,14 @@
+2010-10-05 Andrew Wilson <atwilson at chromium.org>
+
+ Reviewed by Andreas Kling.
+
+ Notification onclick() events don't act like user gestures
+ https://bugs.webkit.org/show_bug.cgi?id=47137
+
+ * src/WebNotification.cpp:
+ (WebKit::WebNotification::dispatchClickEvent):
+ Use UserGestureIndicator to make sure click events are treated like user gestures.
+
2010-10-05 Alok Priyadarshi <alokp at chromium.org>
Reviewed by Kenneth Russell.
diff --git a/WebKit/chromium/src/WebNotification.cpp b/WebKit/chromium/src/WebNotification.cpp
index bfc1bec..c3b1f51 100644
--- a/WebKit/chromium/src/WebNotification.cpp
+++ b/WebKit/chromium/src/WebNotification.cpp
@@ -34,6 +34,7 @@
#if ENABLE(NOTIFICATIONS)
#include "Notification.h"
+#include "UserGestureIndicator.h"
#include "WebString.h"
#include "WebTextDirection.h"
@@ -140,6 +141,8 @@ void WebNotification::dispatchCloseEvent(bool /* byUser */)
void WebNotification::dispatchClickEvent()
{
+ // Make sure clicks on notifications are treated as user gestures.
+ UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
RefPtr<Event> event = Event::create(eventNames().clickEvent, false, true);
m_private->dispatchEvent(event.release());
}
diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
index 69df521..006fbdb 100644
--- a/WebKit/qt/ChangeLog
+++ b/WebKit/qt/ChangeLog
@@ -1,3 +1,14 @@
+2010-10-05 Andrew Wilson <atwilson at chromium.org>
+
+ Reviewed by Andreas Kling.
+
+ Notification onclick() events don't act like user gestures
+ https://bugs.webkit.org/show_bug.cgi?id=47137
+
+ * WebCoreSupport/NotificationPresenterClientQt.cpp:
+ (WebCore::NotificationPresenterClientQt::notificationClicked):
+ Use UserGestureIndicator to make sure click events are treated like user gestures.
+
2010-10-05 Robert Hogan <robert at webkit.org>
Reviewed by Andreas Kling.
diff --git a/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp b/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
index 7b33d9e..0324c0d 100644
--- a/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
+++ b/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
@@ -40,6 +40,7 @@
#include "QtPlatformPlugin.h"
#include "ScriptExecutionContext.h"
#include "SecurityOrigin.h"
+#include "UserGestureIndicator.h"
#include "qwebframe_p.h"
#include "qwebkitglobal.h"
@@ -262,8 +263,11 @@ void NotificationPresenterClientQt::cancel(NotificationWrapper* wrapper)
void NotificationPresenterClientQt::notificationClicked(NotificationWrapper* wrapper)
{
Notification* notification = notificationForWrapper(wrapper);
- if (notification)
+ if (notification) {
+ // Make sure clicks on notifications are treated as user gestures.
+ UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
sendEvent(notification, eventNames().clickEvent);
+ }
}
void NotificationPresenterClientQt::notificationClicked(const QString& title)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list