[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 14:27:30 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit f7966a322778df7939a36443622211b6fc34e19e
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Oct 9 07:11:08 2010 +0000

    2010-10-09  Pratik Solanki  <psolanki at apple.com>
    
            Reviewed by Dan Bernstein.
    
            https://bugs.webkit.org/show_bug.cgi?id=47450
            Crash in WebCore::SocketStreamHandle::chooseProxyFromArray because proxyArray passed is nil
            <rdar://problem/8244376>
    
            * platform/network/cf/SocketStreamHandleCFNet.cpp:
            (WebCore::SocketStreamHandle::chooseProxyFromArray): If proxyArray is
            NULL, return early to avoid crash.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 51055f6..cc4da63 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-10-09  Pratik Solanki  <psolanki at apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        https://bugs.webkit.org/show_bug.cgi?id=47450
+        Crash in WebCore::SocketStreamHandle::chooseProxyFromArray because proxyArray passed is nil
+        <rdar://problem/8244376>
+
+        * platform/network/cf/SocketStreamHandleCFNet.cpp:
+        (WebCore::SocketStreamHandle::chooseProxyFromArray): If proxyArray is
+        NULL, return early to avoid crash.
+
 2010-10-08  Chris Rogers  <crogers at google.com>
 
         Reviewed by James Robinson.
diff --git a/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp b/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
index a945986..800301a 100644
--- a/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
+++ b/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
@@ -194,8 +194,10 @@ void SocketStreamHandle::chooseProxy()
 
 void SocketStreamHandle::chooseProxyFromArray(CFArrayRef proxyArray)
 {
-    if (!proxyArray)
+    if (!proxyArray) {
         m_connectionType = Direct;
+        return;
+    }
 
     CFIndex proxyArrayCount = CFArrayGetCount(proxyArray);
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list