[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
mrobinson at webkit.org
mrobinson at webkit.org
Wed Dec 22 14:27:36 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 5f5c701ebdfb1d0cce2a9dbafbbe4955037eba71
Author: mrobinson at webkit.org <mrobinson at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sat Oct 9 15:17:25 2010 +0000
2010-10-09 Martin Robinson <mrobinson at igalia.com>
Reviewed by Xan Lopez.
[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435
Added a pixel test result for this issue.
* platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
* platform/gtk/fast/forms/slider-padding-expected.png: Added.
2010-10-09 Martin Robinson <mrobinson at igalia.com>
Reviewed by Xan Lopez.
[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435
Instead of painting the track rectangle for ranges onto the entire RenderBox
rectangle, simply paint it on the content rectangle. This prevents misrendering
sliders with padding.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect
of the slider instead of the entire area (which includes padding).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index a82669b..805b9ae 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2010-10-09 Martin Robinson <mrobinson at igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Slider padding translate into a larger track rect
+ https://bugs.webkit.org/show_bug.cgi?id=47435
+
+ Added a pixel test result for this issue.
+
+ * platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
+ * platform/gtk/fast/forms/slider-padding-expected.png: Added.
+
2010-10-09 Csaba Osztrogonác <ossy at webkit.org>
Unreviewed fix after r69413.
diff --git a/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.checksum b/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.checksum
new file mode 100644
index 0000000..2e6b490
--- /dev/null
+++ b/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.checksum
@@ -0,0 +1 @@
+bd7672e2a7a5c5f26c577a01321e2a27
\ No newline at end of file
diff --git a/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png b/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png
new file mode 100644
index 0000000..10bd49a
Binary files /dev/null and b/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png differ
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 134f147..3df883d 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-10-09 Martin Robinson <mrobinson at igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Slider padding translate into a larger track rect
+ https://bugs.webkit.org/show_bug.cgi?id=47435
+
+ Instead of painting the track rectangle for ranges onto the entire RenderBox
+ rectangle, simply paint it on the content rectangle. This prevents misrendering
+ sliders with padding.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect
+ of the slider instead of the entire area (which includes padding).
+
2010-10-09 Kent Tamura <tkent at chromium.org>
Unreviewed, trivial regression fix for r69445.
diff --git a/WebCore/platform/gtk/RenderThemeGtk.cpp b/WebCore/platform/gtk/RenderThemeGtk.cpp
index 1039e42..e647eee 100644
--- a/WebCore/platform/gtk/RenderThemeGtk.cpp
+++ b/WebCore/platform/gtk/RenderThemeGtk.cpp
@@ -549,7 +549,7 @@ bool RenderThemeGtk::paintSliderTrack(RenderObject* object, const PaintInfo& inf
if (part == SliderVerticalPart)
gtkPart = MOZ_GTK_SCALE_VERTICAL;
- return paintRenderObject(gtkPart, object, info.context, rect);
+ return paintRenderObject(gtkPart, object, info.context, toRenderBox(object)->absoluteContentBox());
}
void RenderThemeGtk::adjustSliderTrackStyle(CSSStyleSelector*, RenderStyle* style, Element*) const
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list