[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
cfleizach at apple.com
cfleizach at apple.com
Wed Dec 22 14:28:19 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 74d91a4c4aa6b23ca967375bab4aef348e384f7e
Author: cfleizach at apple.com <cfleizach at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun Oct 10 22:18:30 2010 +0000
2010-10-10 Chris Fleizach <cfleizach at apple.com>
Reviewed by Beth Dakin.
AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443
* platform/mac/accessibility/live-region-on-span-expected.txt: Added.
* platform/mac/accessibility/live-region-on-span.html: Added.
2010-10-10 Chris Fleizach <cfleizach at apple.com>
Reviewed by Beth Dakin.
AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443
If an element has aria attributes, but has no other native role associated with it,
accessibility should fallback to exposing that element as an AXGroup.
Test: platform/mac/accessibility/live-region-on-span.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index b692ff6..cee585d 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,13 @@
+2010-10-10 Chris Fleizach <cfleizach at apple.com>
+
+ Reviewed by Beth Dakin.
+
+ AX: if aria-live is on a <span> or ignored element, live regions don't work
+ https://bugs.webkit.org/show_bug.cgi?id=47443
+
+ * platform/mac/accessibility/live-region-on-span-expected.txt: Added.
+ * platform/mac/accessibility/live-region-on-span.html: Added.
+
2010-10-10 Daniel Cheng <dcheng at chromium.org>
Reviewed by Adam Barth.
diff --git a/LayoutTests/platform/mac/accessibility/live-region-on-span-expected.txt b/LayoutTests/platform/mac/accessibility/live-region-on-span-expected.txt
new file mode 100644
index 0000000..8e046c9
--- /dev/null
+++ b/LayoutTests/platform/mac/accessibility/live-region-on-span-expected.txt
@@ -0,0 +1,14 @@
+text
+This tests that if aria-live is on a , that that is not ignored, and that is has the appropriate aria live information.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS divElement.childAtIndex(0).role is 'AXRole: AXGroup'
+PASS divElement.childAtIndex(0).childAtIndex(0).role is 'AXRole: AXStaticText'
+PASS divElement.childAtIndex(0).isAttributeSupported('AXARIALive') is true
+PASS divElement.childAtIndex(0).isAttributeSupported('AXARIARelevant') is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/mac/accessibility/live-region-on-span.html b/LayoutTests/platform/mac/accessibility/live-region-on-span.html
new file mode 100644
index 0000000..2a7ff4e
--- /dev/null
+++ b/LayoutTests/platform/mac/accessibility/live-region-on-span.html
@@ -0,0 +1,39 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css">
+<script>
+var successfullyParsed = false;
+</script>
+<script src="../../../fast/js/resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="div" tabindex="0">
+ <span aria-live="polite" aria-relevant="all">text</span>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that if aria-live is on a <span>, that that <span> is not ignored, and that is has the appropriate aria live information.");
+
+ if (window.accessibilityController) {
+
+ document.getElementById("div").focus();
+ var divElement = accessibilityController.focusedElement;
+ shouldBe("divElement.childAtIndex(0).role", "'AXRole: AXGroup'");
+ shouldBe("divElement.childAtIndex(0).childAtIndex(0).role", "'AXRole: AXStaticText'");
+
+ shouldBe("divElement.childAtIndex(0).isAttributeSupported('AXARIALive')", "true");
+ shouldBe("divElement.childAtIndex(0).isAttributeSupported('AXARIARelevant')", "true");
+ }
+
+ successfullyParsed = true;
+</script>
+
+<script src="../../../fast/js/resources/js-test-post.js"></script>
+</body>
+</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index b82358a..c8cbe8a 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-10-10 Chris Fleizach <cfleizach at apple.com>
+
+ Reviewed by Beth Dakin.
+
+ AX: if aria-live is on a <span> or ignored element, live regions don't work
+ https://bugs.webkit.org/show_bug.cgi?id=47443
+
+ If an element has aria attributes, but has no other native role associated with it,
+ accessibility should fallback to exposing that element as an AXGroup.
+
+ Test: platform/mac/accessibility/live-region-on-span.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+
2010-10-10 Daniel Cheng <dcheng at chromium.org>
Reviewed by Adam Barth.
diff --git a/WebCore/accessibility/AccessibilityRenderObject.cpp b/WebCore/accessibility/AccessibilityRenderObject.cpp
index 42c9889..0b82c67 100644
--- a/WebCore/accessibility/AccessibilityRenderObject.cpp
+++ b/WebCore/accessibility/AccessibilityRenderObject.cpp
@@ -3088,6 +3088,10 @@ AccessibilityRole AccessibilityRenderObject::determineAccessibilityRole()
if (m_renderer->isBlockFlow() || (node && node->hasTagName(labelTag)))
return GroupRole;
+ // If the element does not have role, but it has ARIA attributes, accessibility should fallback to exposing it as a group.
+ if (supportsARIAAttributes())
+ return GroupRole;
+
return UnknownRole;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list