[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

simon.fraser at apple.com simon.fraser at apple.com
Wed Dec 22 14:32:09 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 09d6f08f4874ff637c1d75bb70520a80a90b88b1
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Oct 12 21:06:01 2010 +0000

    2010-10-08  Simon Fraser  <simon.fraser at apple.com>
    
            Reviewed by Alexey Proskuryakov.
    
            Screen.availLeft should be signed
            https://bugs.webkit.org/show_bug.cgi?id=34397
    
            For the screen to the left of the main screen, screen.availLeft
            can be negative, so the Screen API needs to use signed numbers
            for availLeft and availTop.
    
            * manual-tests/screen-availLeft.html: Added.
            * page/Screen.cpp:
            (WebCore::Screen::availLeft):
            (WebCore::Screen::availTop):
            * page/Screen.h:
            * page/Screen.idl:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0b6827c..21d0d8b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-10-08  Simon Fraser  <simon.fraser at apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Screen.availLeft should be signed
+        https://bugs.webkit.org/show_bug.cgi?id=34397
+
+        For the screen to the left of the main screen, screen.availLeft
+        can be negative, so the Screen API needs to use signed numbers
+        for availLeft and availTop.
+
+        * manual-tests/screen-availLeft.html: Added.
+        * page/Screen.cpp:
+        (WebCore::Screen::availLeft):
+        (WebCore::Screen::availTop):
+        * page/Screen.h:
+        * page/Screen.idl:
+
 2010-10-12  Anders Carlsson  <andersca at apple.com>
 
         Reviewed by Sam Weinig.
diff --git a/WebCore/page/Screen.cpp b/WebCore/page/Screen.cpp
index d2bb60f..bddc030 100644
--- a/WebCore/page/Screen.cpp
+++ b/WebCore/page/Screen.cpp
@@ -81,18 +81,18 @@ unsigned Screen::pixelDepth() const
     return static_cast<unsigned>(screenDepth(m_frame->view()));
 }
 
-unsigned Screen::availLeft() const
+int Screen::availLeft() const
 {
     if (!m_frame)
         return 0;
-    return static_cast<unsigned>(screenAvailableRect(m_frame->view()).x());
+    return static_cast<int>(screenAvailableRect(m_frame->view()).x());
 }
 
-unsigned Screen::availTop() const
+int Screen::availTop() const
 {
     if (!m_frame)
         return 0;
-    return static_cast<unsigned>(screenAvailableRect(m_frame->view()).y());
+    return static_cast<int>(screenAvailableRect(m_frame->view()).y());
 }
 
 unsigned Screen::availHeight() const
diff --git a/WebCore/page/Screen.h b/WebCore/page/Screen.h
index 2c84abd..5716d46 100644
--- a/WebCore/page/Screen.h
+++ b/WebCore/page/Screen.h
@@ -48,8 +48,8 @@ namespace WebCore {
         unsigned width() const;
         unsigned colorDepth() const;
         unsigned pixelDepth() const;
-        unsigned availLeft() const;
-        unsigned availTop() const;
+        int availLeft() const;
+        int availTop() const;
         unsigned availHeight() const;
         unsigned availWidth() const;
 
diff --git a/WebCore/page/Screen.idl b/WebCore/page/Screen.idl
index cd181eb..50f87ee 100644
--- a/WebCore/page/Screen.idl
+++ b/WebCore/page/Screen.idl
@@ -34,8 +34,8 @@ module window {
         readonly attribute unsigned long width;
         readonly attribute unsigned long colorDepth;
         readonly attribute unsigned long pixelDepth;
-        readonly attribute unsigned long availLeft;
-        readonly attribute unsigned long availTop;
+        readonly attribute long availLeft;
+        readonly attribute long availTop;
         readonly attribute unsigned long availHeight;
         readonly attribute unsigned long availWidth;
     };

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list