[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 14:36:46 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 8642a9a7eabc67a214b3c41126a60b240edb2bfe
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Oct 14 05:00:17 2010 +0000
2010-10-13 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
Introduce the ChromiumXVFBPort for running commit-queue on EC2
https://bugs.webkit.org/show_bug.cgi?id=47653
I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.
* Scripts/webkitpy/common/config/ports.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 7be99d4..878a2cc 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,18 @@
+2010-10-13 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Introduce the ChromiumXVFBPort for running commit-queue on EC2
+ https://bugs.webkit.org/show_bug.cgi?id=47653
+
+ I'm not entirely sure this is the best way to do this, but we need to
+ run the tests under XVFB on EC2 because the EC2 instances don't have a
+ real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
+ that way. The idea is that XVFB is like a platform for the Chromium
+ port, but we don't have a real notion of platform separate from port.
+
+ * Scripts/webkitpy/common/config/ports.py:
+
2010-10-13 Sergio Villar Senin <svillar at igalia.com>
Reviewed by Martin Robinson.
diff --git a/WebKitTools/Scripts/webkitpy/common/config/ports.py b/WebKitTools/Scripts/webkitpy/common/config/ports.py
index ebd88b1..d9b9c43 100644
--- a/WebKitTools/Scripts/webkitpy/common/config/ports.py
+++ b/WebKitTools/Scripts/webkitpy/common/config/ports.py
@@ -45,6 +45,7 @@ class WebKitPort(object):
def port(port_name):
ports = {
"chromium": ChromiumPort,
+ "chromium-xvfb": ChromiumXVFBPort,
"gtk": GtkPort,
"mac": MacPort,
"win": WinPort,
@@ -217,3 +218,24 @@ class ChromiumPort(WebKitPort):
command = WebKitPort.build_webkit_command(build_style=build_style)
command.append("--chromium")
return command
+
+ @classmethod
+ def run_webkit_tests_command(cls):
+ return [
+ cls.script_path("new-run-webkit-tests"),
+ "--chromium",
+ "--use-drt",
+ "--no-pixel-tests",
+ ]
+
+
+class ChromiumXVFBPort(ChromiumPort):
+
+ @classmethod
+ def flag(cls):
+ return "--port=chromium-xvfb"
+
+ @classmethod
+ def run_webkit_tests_command(cls):
+ # FIXME: We should find a better way to do this.
+ return ["xvfb-run"] + cls.run_webkit_tests_command()
diff --git a/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py b/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
index 42c4f2d..7e13d8f 100644
--- a/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
@@ -64,7 +64,7 @@ class WebKitPortTest(unittest.TestCase):
def test_chromium_port(self):
self.assertEquals(ChromiumPort.name(), "Chromium")
self.assertEquals(ChromiumPort.flag(), "--port=chromium")
- self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("run-webkit-tests")])
+ self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--use-drt", "--no-pixel-tests"])
self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium"])
self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium"])
self.assertEquals(ChromiumPort.update_webkit_command(), [WebKitPort.script_path("update-webkit"), "--chromium"])
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list