[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
abarth at webkit.org
abarth at webkit.org
Wed Dec 22 14:37:57 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 8e823d300980d45bf68d67f49734a5d2d3bfec31
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Oct 14 16:40:08 2010 +0000
2010-10-14 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=47655
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index b28db9e..93f46e4 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,13 @@
+2010-10-14 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
+ https://bugs.webkit.org/show_bug.cgi?id=47655
+
+ * Scripts/webkitpy/common/config/ports.py:
+ * Scripts/webkitpy/common/config/ports_unittest.py:
+
2010-10-13 Eric Seidel <eric at webkit.org>
Reviewed by Adam Barth.
diff --git a/WebKitTools/Scripts/webkitpy/common/config/ports.py b/WebKitTools/Scripts/webkitpy/common/config/ports.py
index 5a85f7d..79cb0c2 100644
--- a/WebKitTools/Scripts/webkitpy/common/config/ports.py
+++ b/WebKitTools/Scripts/webkitpy/common/config/ports.py
@@ -242,4 +242,4 @@ class ChromiumXVFBPort(ChromiumPort):
@classmethod
def run_webkit_tests_command(cls):
# FIXME: We should find a better way to do this.
- return ["xvfb-run"] + cls.run_webkit_tests_command()
+ return ["xvfb-run"] + ChromiumPort.run_webkit_tests_command()
diff --git a/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py b/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
index 7e13d8f..3bdf0e6 100644
--- a/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
@@ -29,7 +29,7 @@
import unittest
-from webkitpy.common.config.ports import WebKitPort, MacPort, GtkPort, QtPort, ChromiumPort
+from webkitpy.common.config.ports import *
class WebKitPortTest(unittest.TestCase):
@@ -69,6 +69,8 @@ class WebKitPortTest(unittest.TestCase):
self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium"])
self.assertEquals(ChromiumPort.update_webkit_command(), [WebKitPort.script_path("update-webkit"), "--chromium"])
+ def test_chromium_xvfb_port(self):
+ self.assertEquals(ChromiumXVFBPort.run_webkit_tests_command(), ["xvfb-run", "WebKitTools/Scripts/new-run-webkit-tests", "--chromium", "--use-drt", "--no-pixel-tests"])
if __name__ == '__main__':
unittest.main()
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list