[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
kbr at google.com
kbr at google.com
Wed Dec 22 14:45:53 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit aa809ef994b844d827d01c067c493fcee6fd06e1
Author: kbr at google.com <kbr at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 19 17:56:44 2010 +0000
2010-10-19 Kenneth Russell <kbr at google.com>
Reviewed by David Levin.
chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
https://bugs.webkit.org/show_bug.cgi?id=47874
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 839397d..36095e1 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,13 @@
+2010-10-19 Kenneth Russell <kbr at google.com>
+
+ Reviewed by David Levin.
+
+ chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
+ https://bugs.webkit.org/show_bug.cgi?id=47874
+
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+
2010-10-19 Tony Chang <tony at chromium.org>
Reviewed by Kent Tamura.
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
index 505c9b5..ee84e8b 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
@@ -90,7 +90,7 @@ class ChromiumGpuLinuxPort(chromium_linux.ChromiumLinuxPort):
chromium_linux.ChromiumLinuxPort.__init__(self, **kwargs)
def baseline_search_path(self):
- return ([self._webkit_baseline_path('chromium-gpu-linux')] +
+ return (map(self._webkit_baseline_path, ['chromium-gpu-linux', 'chromium-gpu']) +
chromium_linux.ChromiumLinuxPort.baseline_search_path(self))
def path_to_test_expectations_file(self):
@@ -108,7 +108,7 @@ class ChromiumGpuMacPort(chromium_mac.ChromiumMacPort):
chromium_mac.ChromiumMacPort.__init__(self, **kwargs)
def baseline_search_path(self):
- return ([self._webkit_baseline_path('chromium-gpu-mac')] +
+ return (map(self._webkit_baseline_path, ['chromium-gpu-mac', 'chromium-gpu']) +
chromium_mac.ChromiumMacPort.baseline_search_path(self))
def path_to_test_expectations_file(self):
@@ -126,7 +126,7 @@ class ChromiumGpuWinPort(chromium_win.ChromiumWinPort):
chromium_win.ChromiumWinPort.__init__(self, **kwargs)
def baseline_search_path(self):
- return ([self._webkit_baseline_path('chromium-gpu-win')] +
+ return (map(self._webkit_baseline_path, ['chromium-gpu-win', 'chromium-gpu']) +
chromium_win.ChromiumWinPort.baseline_search_path(self))
def path_to_test_expectations_file(self):
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
index 3f13b93..8c7fbe0 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
@@ -52,11 +52,12 @@ class ChromiumGpuTest(unittest.TestCase):
# we use startswith() instead of Equal to gloss over platform versions.
self.assertTrue(port.name().startswith(port_name))
- # test that it has the right directory in front of the search path.
- path = port.baseline_search_path()[0]
- self.assertEqual(port._webkit_baseline_path(port_name), path)
+ # test that it has the right directories in front of the search path.
+ paths = port.baseline_search_path()
+ self.assertEqual(port._webkit_baseline_path(port_name), paths[0])
+ self.assertEqual(port._webkit_baseline_path('chromium-gpu'), paths[1])
- # test that we have the right expectations file.
+ # Test that we have the right expectations file.
self.assertTrue('chromium-gpu' in
port.path_to_test_expectations_file())
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list