[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 14:54:23 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 339c2dfedb893ab443b93a1cc4b54cde720924e9
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Oct 24 02:19:36 2010 +0000

    2010-10-23  Daniel Bates  <dbates at rim.com>
    
            Reviewed by Adam Barth.
    
            Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
            https://bugs.webkit.org/show_bug.cgi?id=48197
    
            With the landing of the patch for bug #45365 in
            changeset 67182 <http://trac.webkit.org/changeset/67182>,
            HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed.
            Therefore, we remove it.
    
            Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach
            callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182
            removed this callback.
    
            No functionality was changed. So, no new tests.
    
            * html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback().
            * html/HTMLFrameElementBase.h: Ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 8449371..2c4d065 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,24 @@
+2010-10-23  Daniel Bates  <dbates at rim.com>
+
+        Reviewed by Adam Barth.
+
+        Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
+        https://bugs.webkit.org/show_bug.cgi?id=48197
+
+        With the landing of the patch for bug #45365 in
+        changeset 67182 <http://trac.webkit.org/changeset/67182>, 
+        HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed.
+        Therefore, we remove it.
+
+        Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach
+        callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182
+        removed this callback.
+
+        No functionality was changed. So, no new tests.
+
+        * html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback().
+        * html/HTMLFrameElementBase.h: Ditto.
+
 2010-10-23  Xan Lopez  <xlopez at igalia.com>
 
         Reviewed by Sam Weinig.
diff --git a/WebCore/html/HTMLFrameElementBase.cpp b/WebCore/html/HTMLFrameElementBase.cpp
index f8d682c..d153845 100644
--- a/WebCore/html/HTMLFrameElementBase.cpp
+++ b/WebCore/html/HTMLFrameElementBase.cpp
@@ -166,11 +166,6 @@ void HTMLFrameElementBase::setNameAndOpenURL()
     openURL();
 }
 
-void HTMLFrameElementBase::setNameAndOpenURLCallback(Node* n)
-{
-    static_cast<HTMLFrameElementBase*>(n)->setNameAndOpenURL();
-}
-
 void HTMLFrameElementBase::updateOnReparenting()
 {
     ASSERT(m_remainsAliveOnRemovalFromTree);
diff --git a/WebCore/html/HTMLFrameElementBase.h b/WebCore/html/HTMLFrameElementBase.h
index ae41e75..ef25f30 100644
--- a/WebCore/html/HTMLFrameElementBase.h
+++ b/WebCore/html/HTMLFrameElementBase.h
@@ -70,8 +70,6 @@ private:
     void setNameAndOpenURL();
     void openURL(bool lockHistory = true, bool lockBackForwardList = true);
 
-    static void setNameAndOpenURLCallback(Node*);
-
     AtomicString m_URL;
     AtomicString m_frameName;
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list