[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

rwlbuis at webkit.org rwlbuis at webkit.org
Wed Dec 22 14:59:54 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 2e0e16df963b22d59bde6878577a3876efc88e46
Author: rwlbuis at webkit.org <rwlbuis at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Oct 27 06:38:35 2010 +0000

    2010-10-26  Rob Buis  <rwlbuis at gmail.com>
    
            Reviewed by Nikolas Zimmermann.
    
            Title-Element has no popup on <svg>-Elements, but on <g>
            https://bugs.webkit.org/show_bug.cgi?id=47669
    
            Allow tooltips on non-root svg elements.
    
            No new tests.
    
            * svg/SVGStyledElement.cpp:
            (WebCore::SVGStyledElement::title):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ce1081d..04951d6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-10-26  Rob Buis  <rwlbuis at gmail.com>
+
+        Reviewed by Nikolas Zimmermann.
+
+        Title-Element has no popup on <svg>-Elements, but on <g>
+        https://bugs.webkit.org/show_bug.cgi?id=47669
+
+        Allow tooltips on non-root svg elements.
+
+        No new tests.
+
+        * svg/SVGStyledElement.cpp:
+
 2010-10-26  Dai Mikurube  <dmikurube at google.com>
 
         Reviewed by Kent Tamura.
diff --git a/WebCore/svg/SVGStyledElement.cpp b/WebCore/svg/SVGStyledElement.cpp
index d4fa89c..64030bc 100644
--- a/WebCore/svg/SVGStyledElement.cpp
+++ b/WebCore/svg/SVGStyledElement.cpp
@@ -66,10 +66,13 @@ SVGStyledElement::~SVGStyledElement()
 
 String SVGStyledElement::title() const
 {
-    // According to spec, we should not return titles when hovering over <svg> elements (those 
+    // According to spec, we should not return titles when hovering over root <svg> elements (those
     // <title> elements are the title of the document, not a tooltip) so we instantly return.
-    if (hasTagName(SVGNames::svgTag))
-        return String();
+    if (hasTagName(SVGNames::svgTag)) {
+        const SVGSVGElement* svg = static_cast<const SVGSVGElement*>(this);
+        if (svg->isOutermostSVG())
+            return String();
+    }
     
     // Walk up the tree, to find out whether we're inside a <use> shadow tree, to find the right title.
     Node* parent = const_cast<SVGStyledElement*>(this);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list