[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
apavlov at chromium.org
apavlov at chromium.org
Wed Dec 22 15:02:57 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 8a7dc4febe1abc8ba3c8f772f5503fbe96cebb1c
Author: apavlov at chromium.org <apavlov at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Oct 27 18:53:55 2010 +0000
2010-10-27 Alexander Pavlov <apavlov at chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.InspectorTest.enableResourceTracking):
(initialize_InspectorTest.InspectorTest.disableResourceTracking):
* http/tests/inspector/resource-parameters.html:
* inspector/audits-panel-functional.html:
* inspector/styles-source-offsets.html:
2010-10-27 Alexander Pavlov <apavlov at chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._createPanelEnabler):
(WebInspector.ResourcesPanel.prototype._enableResourceTracking):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 4819bcf..315ad72 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,17 @@
+2010-10-27 Alexander Pavlov <apavlov at chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=48431
+
+ * http/tests/inspector/inspector-test2.js:
+ (initialize_InspectorTest.InspectorTest.enableResourceTracking):
+ (initialize_InspectorTest.InspectorTest.disableResourceTracking):
+ * http/tests/inspector/resource-parameters.html:
+ * inspector/audits-panel-functional.html:
+ * inspector/styles-source-offsets.html:
+
2010-10-27 Abhishek Arya <inferno at chromium.org>
Reviewed by Dave Hyatt.
diff --git a/LayoutTests/http/tests/inspector/inspector-test2.js b/LayoutTests/http/tests/inspector/inspector-test2.js
index 8d97340..5a982e1 100644
--- a/LayoutTests/http/tests/inspector/inspector-test2.js
+++ b/LayoutTests/http/tests/inspector/inspector-test2.js
@@ -118,7 +118,7 @@ InspectorTest.enableResourceTracking = function(callback)
callback();
else {
InspectorTest._reloadPageCallback = callback;
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
}
}
@@ -128,7 +128,7 @@ InspectorTest.disableResourceTracking = function()
return;
if (WebInspector.panels.resources.resourceTrackingEnabled)
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
}
InspectorTest.findDOMNode = function(root, filter, callback)
diff --git a/LayoutTests/http/tests/inspector/resource-parameters.html b/LayoutTests/http/tests/inspector/resource-parameters.html
index 16fb4dc..83e9cde 100644
--- a/LayoutTests/http/tests/inspector/resource-parameters.html
+++ b/LayoutTests/http/tests/inspector/resource-parameters.html
@@ -33,7 +33,7 @@ function onIframeLoad()
function frontend_enableResourceTracking(testController)
{
if (!WebInspector.panels.resources.resourceTrackingEnabled) {
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
return "enabling";
}
return "enabled";
@@ -43,7 +43,7 @@ function frontend_dumpFormData(testController)
{
var resource = WebInspector.resourceForURL("http://localhost:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=");
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
if (!resource) {
testController.notifyDone("No resource found");
diff --git a/LayoutTests/inspector/audits-panel-functional.html b/LayoutTests/inspector/audits-panel-functional.html
index 05f5c35..2c27441 100644
--- a/LayoutTests/inspector/audits-panel-functional.html
+++ b/LayoutTests/inspector/audits-panel-functional.html
@@ -41,7 +41,7 @@ function frontend_runAudits(testController)
return "refreshing";
}
} else if (!WebInspector.panels.resources.resourceTrackingEnabled) {
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
return "refreshing";
}
@@ -60,7 +60,7 @@ function frontend_runAudits(testController)
var output = frontend_collectAuditResults();
// Avoid influencing tests that require resource tracking to be disabled.
if (!Preferences.networkPanelEnabled)
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
testController.runAfterPendingDispatches(function() {
testController.notifyDone(output.join("\n"));
});
diff --git a/LayoutTests/inspector/styles-source-offsets.html b/LayoutTests/inspector/styles-source-offsets.html
index 205f467..02c7929 100644
--- a/LayoutTests/inspector/styles-source-offsets.html
+++ b/LayoutTests/inspector/styles-source-offsets.html
@@ -25,7 +25,7 @@ function doit()
function frontend_runTest(testController)
{
if (!Preferences.networkPanelEnabled && !WebInspector.panels.resources.resourceTrackingEnabled) {
- WebInspector.panels.resources._toggleResourceTracking();
+ WebInspector.panels.resources.toggleResourceTracking();
return "refreshing";
}
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 09fbe97..b6d4018 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-10-27 Alexander Pavlov <apavlov at chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=48431
+
+ * inspector/front-end/AuditsPanel.js:
+ (WebInspector.AuditsPanel.prototype._reloadResources):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype._createPanelEnabler):
+ (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
+
2010-10-27 Abhishek Arya <inferno at chromium.org>
Reviewed by Dave Hyatt.
diff --git a/WebCore/inspector/front-end/AuditsPanel.js b/WebCore/inspector/front-end/AuditsPanel.js
index 8947f2c..b4eb202 100644
--- a/WebCore/inspector/front-end/AuditsPanel.js
+++ b/WebCore/inspector/front-end/AuditsPanel.js
@@ -206,7 +206,7 @@ WebInspector.AuditsPanel.prototype = {
this._resourceTrackingCallback = callback;
if (WebInspector.panels.resources && !WebInspector.panels.resources.resourceTrackingEnabled) {
- InspectorBackend.enableResourceTracking(false);
+ WebInspector.panels.resources.toggleResourceTracking(false);
this._updateLauncherViewControls(true);
} else
InspectorBackend.reloadPage();
diff --git a/WebCore/inspector/front-end/ResourcesPanel.js b/WebCore/inspector/front-end/ResourcesPanel.js
index 56458b0..b35fc4b 100644
--- a/WebCore/inspector/front-end/ResourcesPanel.js
+++ b/WebCore/inspector/front-end/ResourcesPanel.js
@@ -439,7 +439,7 @@ WebInspector.ResourcesPanel.prototype = {
this.element.appendChild(this.panelEnablerView.element);
this.enableToggleButton = new WebInspector.StatusBarButton("", "enable-toggle-status-bar-item");
- this.enableToggleButton.addEventListener("click", this._toggleResourceTracking.bind(this), false);
+ this.enableToggleButton.addEventListener("click", this.toggleResourceTracking.bind(this), false);
},
_createStatusbarButtons: function()
@@ -1065,10 +1065,10 @@ WebInspector.ResourcesPanel.prototype = {
{
if (this._resourceTrackingEnabled)
return;
- this._toggleResourceTracking(this.panelEnablerView.alwaysEnabled);
+ this.toggleResourceTracking(this.panelEnablerView.alwaysEnabled);
},
- _toggleResourceTracking: function(optionalAlways)
+ toggleResourceTracking: function(optionalAlways)
{
function callback(newState) {
if (newState)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list